From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94BE6C83F1A for ; Mon, 21 Jul 2025 01:03:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D5A3E6B008A; Sun, 20 Jul 2025 21:03:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D0B016B008C; Sun, 20 Jul 2025 21:03:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF9AF6B0093; Sun, 20 Jul 2025 21:03:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id AB29D6B008A for ; Sun, 20 Jul 2025 21:03:26 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D9179C02C2 for ; Mon, 21 Jul 2025 01:03:25 +0000 (UTC) X-FDA: 83686473570.06.2D846F6 Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf18.hostedemail.com (Postfix) with ESMTP id 3B6CD1C0013 for ; Mon, 21 Jul 2025 01:03:22 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; spf=pass (imf18.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1753059804; a=rsa-sha256; cv=none; b=TkvbRn02zop0B6kbhXlhI2Y/9GUUSckFO7Wn7fHyFrQtvKAtIUjWmKXbh1ez8ma6GEgV+O p6KEDsXgfWNPUZWeiAQBQ7yoFXwnpoUaS+hnyp3vDFWCH+OFslJgtlLNBPbtTNdtFDGQWZ uC2qm7k+pSU05+gj0QxD7V1AtbA4k70= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf18.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1753059804; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cZRhGWP74cWM4YUnfn07E87umTK+vXhiEBd2qiFKAKI=; b=B2x6vv9Wn4PtbSB50bYFIN30IRwDHzNIB+XhwoifGx4NRsPZBAyCw9RGQ95m4N7Ee8C+D5 y3sYEAr8ZYXI5uvGVIty6MeZ/3omIzqXW+TS831bz9p8b8AOnARLO9z8mbFsbCo0eBUfN0 mzMpPjR92qB0F+fOAuN+PUlB+32QuVg= X-AuditID: a67dfc5b-669ff7000002311f-0d-687d91d6d773 Date: Mon, 21 Jul 2025 10:03:13 +0900 From: Byungchul Park To: Pavel Begunkov Cc: kernel test robot , willy@infradead.org, netdev@vger.kernel.org, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, almasrymina@google.com, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, akpm@linux-foundation.org, andrew+netdev@lunn.ch, toke@redhat.com, david@redhat.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com, hannes@cmpxchg.org, ziy@nvidia.com, jackmanb@google.com, wei.fang@nxp.com, shenwei.wang@nxp.com, xiaoning.wang@nxp.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org Subject: Re: [Intel-wired-lan] [PATCH net-next v11 12/12] libeth: xdp: access ->pp through netmem_desc instead of page Message-ID: <20250721010313.GA21807@system.software.com> References: <20250717070052.6358-13-byungchul@sk.com> <202507180111.jygqJHzk-lkp@intel.com> <20250718004346.GA38833@system.software.com> <20250718011407.GB38833@system.software.com> <35592824-6749-4fa4-89d9-2de9caccc695@gmail.com> <1fe747ea-56ce-4418-92cb-057d989e3732@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1fe747ea-56ce-4418-92cb-057d989e3732@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRjHfc85O+e4HByn6ZtCwSICTSsRepUUiT68BUEQfinBRh7caF6Y d9HSFDJB81akLpjmXWM6ZU5RqXmZUZSYlyWmstS8pKZmeUvbUaK+/Xj+z/N7ng8PS0r3KTdW GRnLqyPlKhktpsRLDmVeI/mpinNdVj+k0TXQqH4zEVVPGUVIU2cAaL3HTCPNh0wKbei2STTT Z2VQvf4amqyapVBO5g6JOreWGTRgyBWh1rQpBn1s19BoomFfhGZNORRayLDSaDI3CPVpXZCp dohAPbpWAo3s7xKocFBLo8FuK4VK03MB0nVZRGi1w7ZqZ9PmMA/N2ILeCSboBO7+tkLiltpP BG4r+cxgrT4ON9d44Bcd8wTW1z2isX6tgMHjIx007n+2Q+G55mKA24zrBM7JWKZx07KRwKsz YxRe6RqmrzvdFF8M41XKeF59NvC2WDFnORL9VpyYttBIpoHHbDZgWcj5QoPZMRvYH6BW/5QS mOJOwZrqcUZgmjsNLZYtUmBnzhMujppsdTFLcu9FcGxhgRA8Tlwi3NXECz0SDsH9qSUg9Ei5 MgJOr24zh4EjfFM8fbCA5DygZW/+YJbk3GH1HiuU7bkA2DLWIhL4KHcSvjKYCcEDuScs1OV8 ER0eegy+rrFQeYAr+U9b8p+25J9WC8g6IFVGxkfIlSpfb0VSpDLR+05UhB7Y3qIqdfeWEawN 3DABjgUyB0k0laqQiuTxMUkRJgBZUuYsweZkhVQSJk9K5tVRoeo4FR9jAu4sJXOV+PxMCJNy 4fJY/i7PR/PqvynB2rulgYd7ejtVpWkuuqy/bjYAeRb+7myO8rliN9Yk9b8q818tbw9xyqov vb/V1Uscv3cptNa9AYz8qAguckTv/Ppfli+6pbv0qMYvV1gT8kOMKUzwbCUzM+pFBhZEtOUv B38dzst6vuHgLK9NUaVfyPju+stBdSZcvF3UuPegdCXXXSqjYhTy8x6kOkb+BwduVGISAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA02Ra0hTcRjG+Z/bjtPBaZmeFK0WMTDSgqI/eckv4Z+o6FNBILry0IZzyqY2 DWuhXzSmaRdyzZok3kmd5iVMcppLtKVObYm3REWXF+YFvCxtMyK//Xif53mfF14aF04RfrRM kcwpFRK5iOIT/GuhmaeG8zOkp9sei6G+ppqCVRtqWDbZTEJ9ZSOAq51mCuq/ZRFwvWYLhzNd UzxYZbwKJ0pnCajN2sbhx80lHuwo6iZhX2MuCZs0kzxo/aCn4Hj1LglnTVoC2jOnKDiRGwm7 DD7QVDGIwc6aJgwO7zox+HTAQMGBjikCvnqUC2BNm42EjlZX3/aGa4d5cMYlfB7nRR5FHQvL OGqo+IGhFt0YDxmMKai+PAi9bZ3HkLEym0LGlQIeGh1updCXl9sEmqsvBKileRVD2swlCtUt NWPIMTNCoOW2Ieq69y1+WBwnl6VyypCIWL50zuaZ1MNXa+y1uAbk0TnAg2aZs6zB+IJwM8Gc YMvLRnluphgxa7Nt4m72Zk6yv76bXHM+jTMWkh2x27EcQNMHGTXr1Ke6PQIGsruTi8DtETLF GDvt2OL9FQ6w3YXTewU4E8Tadub3sjjjz5bt7N3gwYSzDSMNpJsPMcfZT41m7AkQ6PaldfvS uv9pA8ArgbdMkZogkcnPBavipWkKmTr4TmKCEbg+X5rhzG8Ga9YoE2BoIPISJBEZUiEpSVWl JZgAS+MibwEyp0uFgjhJWjqnTIxRpsg5lQn404TIV3D5JhcrZO5Kkrl4jkvilP9UjPbw04De 5+evDFrHHhaRMnDjniMt0LM1JiTAXlf7bHVebFm/1MIxmlKzVlAc6Fhp75X+VAca4Gt/y+0H bT3vFpdnQzcXRxPz+vs9+D6/ndH3q7LZ2qGFkguxFwNKet6EN60de69SI/MRbZ81SuFbMKL0 MhyOtnzNbgmLWNxJELcXAxGhkkrOBOFKleQP7wjHK/UCAAA= X-CFilter-Loop: Reflected X-Stat-Signature: ye5sq6r5gfiiw64sd7r8str1nns7ucdm X-Rspam-User: X-Rspamd-Queue-Id: 3B6CD1C0013 X-Rspamd-Server: rspam02 X-HE-Tag: 1753059802-902423 X-HE-Meta: U2FsdGVkX192LzaslNxqrfPEpTW/DdWEktMskj38n+eGOqFlcO9PjQmA7TjYJErRwdonQoIIUffEzS+weP7gjzBh0p5LeV/8bZm/sPJO1++iGI3ynwI7OBQobhWq/cymUlzBnx645WuC3X2BHf9EXM0hfiE4GilccnbeEQzvmsQ/jb8X1l0x/c/atkIVe0ZvoEh1UsTUwlLBEg0OCHsKbQ3XZGLMSK6gP+JjnanFNAoK8VoSWodlU5AqrSRduz3y9n7o6AnhR2uHmQWKYLNde78Au2fsD5XKb7n7uAzg6JWar+uJjVOqCvy9ad4wfrh7vYutoAIAIQNrkoi6/wna94jft8z+7MKmjcxkU1PMQmQnOtjRLCOZEBwi5faO1PfIYJcYQ9/IcS9w0m6vPnFvH9bZnx8Z/c3vrlBIun7IAK+r9cSnGVe++jlBEGepKauonB31m9JGTPt6FhkEWP16pjnHnXgagUZiLNBj0cfiCVEP+K7LW9Ie5Ejrp+Bi9gUFEW/NOqeOnWYenMgvldkmSYqDNdwU0tMcpEcTtSKvJtPJSa8Mw3dsWh+Osv4KwOjIMhQutLXJG5/0ZpeF0gkzVuqYTCOVa2jyE4ATxsfN7zg8g8ZYeI0hMtBR8S3DuvBHfWIpTXeHHbJoxZAwD0NYjtiRlxm4mOkxZELWKlNzPjl7aA1Vls3udhEjuqHeZ7KV+nczvuzeowt7mCAejYBSpwm0kQFbZT8erFrsGZ/5KoNVRI8d5E+uRD/HqqLHqoqsip4TGJ1KJHUDUY1lEBqxTHwjMsZQMh0cwrS+VuH9fYaNWS4U4z8MSBfl/uYCU1IdO2tLCs9C4lhle15oitrPbw7h6Ycmqg88qgMem/PW/JkfHRIUM+sIye7Mx0FpuJL31eSUaho63siZAcXGJCNIyPw1R9SsRRF7crwR2Cxxxir38WrCU5xElFM4XbrKSFLBvTaBgSgKJ+2B6Ija3up Wr3V0lwG UM1P/wou8JGaBomSi50XhcSFlplEw8P18a3oU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 18, 2025 at 10:32:38AM +0100, Pavel Begunkov wrote: > On 7/18/25 10:18, Pavel Begunkov wrote: > > On 7/18/25 02:14, Byungchul Park wrote: > ...>>>> include/linux/mm.h:4176:54: note: expected 'struct page *' but argument is of type 'const struct page *' > > > > > static inline bool page_pool_page_is_pp(struct page *page) > > > > > ~~~~~~~~~~~~~^~~~ > > > > > > > > Oh. page_pool_page_is_pp() in the mainline code already has this issue > > > > that the helper cannot take const struct page * as argument. > > > > Probably not, and probably for wrong reasons. netmem_ref is define > > as an integer, compilers cast away such const unlike const pointers. > > Taking a look libeth, at least at the reported spot it does > page->pp->p.offset, that should be fine. And your problem > is caused by the is_pp check in pp_page_to_nmdesc(). Exactly, but you asked me to add the check, DEBUG_NET_WARN_ON_ONCE(!page_pool_page_is_pp(p)) in pp_page_to_nmdesc(). What I meant was, in order to apply that, page_pool_page_is_pp() should take 'const struct page *' as argument. I think it's good idea to change the proto type like, as you said: static inline bool page_pool_page_is_pp(const struct page *page); Thanks. Byungchul > > -- > Pavel Begunkov >