linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Dave Airlie <airlied@gmail.com>
To: dri-devel@lists.freedesktop.org, linux-mm@kvack.org,
	Johannes Weiner <hannes@cmpxchg.org>,
	Christian Koenig <christian.koenig@amd.com>
Cc: Dave Chinner <david@fromorbit.com>, Kairui Song <kasong@tencent.com>
Subject: drm/ttm/memcg/lru: enable memcg tracking for ttm and amdgpu driver (complete series v3)
Date: Tue, 22 Jul 2025 11:43:13 +1000	[thread overview]
Message-ID: <20250722014942.1878844-1-airlied@gmail.com> (raw)

Hi all,

This is a 2nd repost with some fixes and cleanups. Original post is below.

https://lore.kernel.org/dri-devel/20250714052243.1149732-1-airlied@gmail.com/ is the 2nd post.
https://lore.kernel.org/dri-devel/20250630045005.1337339-1-airlied@gmail.com/ is the 1st post.

Differences since last posting:
1. Shakeel suggested I squash some export additions - done now
2. Shakeel suggested I use lruvec in the earlier vmstat accounting - done
3. Christian asked for the turn off patch to be more generic - added Kconfig/module option

I would probably squash 16 into other places, but left it alone for now so we can see it.

Christian has an outstanding statement on suspend/resume breakage that I'm waiting for a respone.

I'd like to at least land 01->06 in drm-misc-next soon, to at least reduce the patch load.

Patch order is now:
01->02: add support for global gpu stat counters
03->06: port ttm pools to list_lru for numa awareness
07->13,16: add memcg stats + gpu apis, then port ttm pools to memcg aware list_lru and shrinker
14: enable amdgpu to use new functionality.

Differences since last posting:
1. Added patch 18: add a module option to allow pooled pages to not be stored in the lru per-memcg
   (Requested by Christian Konig)
2. Converged the naming and stats between vmstat and memcg (Suggested by Shakeel Butt)
3. Cleaned up the charge/uncharge code and some other bits.

Dave.

Original cover letter:
tl;dr: start using list_lru/numa/memcg in GPU driver core and amdgpu driver for now.

This is a complete series of patches, some of which have been sent before and reviewed,
but I want to get the complete picture for others, and try to figure out how best to land this.

There are 3 pieces to this:
01->02: add support for global gpu stat counters (previously posted, patch 2 is newer)
03->07: port ttm pools to list_lru for numa awareness
08->14: add memcg stats + gpu apis, then port ttm pools to memcg aware list_lru and shrinker
15->17: enable amdgpu to use new functionality.

The biggest difference in the memcg code from previously is I discovered what
obj cgroups were designed for and I'm reusing the page/objcg intergration that 
already exists, to avoid reinventing that wheel right now.

There are some igt-gpu-tools tests I've written at:
https://gitlab.freedesktop.org/airlied/igt-gpu-tools/-/tree/amdgpu-cgroups?ref_type=heads

One problem is there are a lot of delayed action, that probably means the testing
needs a bit more robustness, but the tests validate all the basic paths.

Regards,
Dave.



             reply	other threads:[~2025-07-22  1:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-22  1:43 Dave Airlie [this message]
2025-07-22  1:43 ` [PATCH 01/15] mm: add gpu active/reclaim per-node stat counters (v2) Dave Airlie
2025-07-22  1:43 ` [PATCH 02/15] drm/ttm: use gpu mm stats to track gpu memory allocations. (v4) Dave Airlie
2025-07-22  1:43 ` [PATCH 03/15] ttm/pool: port to list_lru. (v2) Dave Airlie
2025-07-22  1:43 ` [PATCH 04/15] ttm/pool: drop numa specific pools Dave Airlie
2025-07-22  1:43 ` [PATCH 05/15] ttm/pool: make pool shrinker NUMA aware Dave Airlie
2025-07-22  1:43 ` [PATCH 06/15] ttm/pool: track allocated_pages per numa node Dave Airlie
2025-07-22  1:43 ` [PATCH 07/15] memcg: add support for GPU page counters. (v2) Dave Airlie
2025-07-22  1:43 ` [PATCH 08/15] ttm: add a memcg accounting flag to the alloc/populate APIs Dave Airlie
2025-07-22  1:43 ` [PATCH 09/15] ttm/pool: initialise the shrinker earlier Dave Airlie
2025-07-22  1:43 ` [PATCH 10/15] ttm: add objcg pointer to bo and tt Dave Airlie
2025-07-22  1:43 ` [PATCH 11/15] ttm/pool: enable memcg tracking and shrinker. (v2) Dave Airlie
2025-07-22 21:19   ` kernel test robot
2025-07-22  1:43 ` [PATCH 12/15] ttm: hook up memcg placement flags Dave Airlie
2025-07-22  1:43 ` [PATCH 13/15] memcontrol: allow objcg api when memcg is config off Dave Airlie
2025-07-22  1:43 ` [PATCH 14/15] amdgpu: add support for memory cgroups Dave Airlie
2025-07-22  1:43 ` [PATCH 15/15] ttm: add support for a module option to disable memcg integration Dave Airlie
2025-07-22 16:52   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250722014942.1878844-1-airlied@gmail.com \
    --to=airlied@gmail.com \
    --cc=christian.koenig@amd.com \
    --cc=david@fromorbit.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hannes@cmpxchg.org \
    --cc=kasong@tencent.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).