[PATCH] selftests/damon: fix selftests by installing drgn related script

[PATCH] selftests/damon: fix selftests by installing drgn related script

[Sang-Heon Jeon]

drgn_dump_damon_status is not installed while kselftest setup.
It can breaks other tests which depend on drgn_dump_damon_status.
Install drgn_dump_damon_status files to fix broken test.

Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
Cc: Alexandre Ghiti <alexghiti@rivosinc.com>
---
While setup kselftest executable environment and test this patch [1],
I found similiar issue. Honestly, I don't know exact solution for this
situation. So I just make a new patch. Sorry if it is wrong direction,
then please let me know how to do next.

[1] https://lore.kernel.org/damon/20250812-alex-fixes_manual-v1-1-c4e99b1f80e4@rivosinc.com/

---
 tools/testing/selftests/damon/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/damon/Makefile b/tools/testing/selftests/damon/Makefile
index 44a4a819df55..029de547f31c 100644
--- a/tools/testing/selftests/damon/Makefile
+++ b/tools/testing/selftests/damon/Makefile
@@ -4,6 +4,7 @@
 TEST_GEN_FILES += access_memory access_memory_even
 
 TEST_FILES = _damon_sysfs.py
+TEST_FILES += drgn_dump_damon_status.py
 
 # functionality tests
 TEST_PROGS += sysfs.sh
-- 
2.43.0

Re: [PATCH] selftests/damon: fix selftests by installing drgn related script

[SeongJae Park]

On Tue, 12 Aug 2025 23:00:46 +0900 Sang-Heon Jeon <ekffu200098@gmail.com> wrote:

> drgn_dump_damon_status is not installed while kselftest setup.
> It can breaks other tests which depend on drgn_dump_damon_status.
> Install drgn_dump_damon_status files to fix broken test.

This patch conflicts with the similar one from Alexandre Ghiti.  Could you
please rebase yours on top of Alexandre's one (and mention the dependency on
the comment section under '---' line), unless Andrew resolves the conflict on
his own?

> 
> Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
> Cc: Alexandre Ghiti <alexghiti@rivosinc.com>

Reviewed-by: SeongJae Park <sj@kernel.org>

> ---
> While setup kselftest executable environment and test this patch [1],
> I found similiar issue. Honestly, I don't know exact solution for this
> situation. So I just make a new patch. Sorry if it is wrong direction,
> then please let me know how to do next.
> 
> [1] https://lore.kernel.org/damon/20250812-alex-fixes_manual-v1-1-c4e99b1f80e4@rivosinc.com/

For patches that you are not really confident about and hence not insisting to
merge as-is, but wanna ask other's opinions first, you can ask questions via
plain text mails, or post patches with RFC tag on the subject.

I think this is the right patch, though.

You could refer to the TEST_FILES part of documentation[1] and "Install
selftests" section on the document for more details.

[1] https://origin.kernel.org/doc/html/latest/dev-tools/kselftest.html#contributing-new-tests-details


Thanks,
SJ

[...]

Re: [PATCH] selftests/damon: fix selftests by installing drgn related script

[Andrew Morton]

On Tue, 12 Aug 2025 10:59:39 -0700 SeongJae Park <sj@kernel.org> wrote:

> On Tue, 12 Aug 2025 23:00:46 +0900 Sang-Heon Jeon <ekffu200098@gmail.com> wrote:
> 
> > drgn_dump_damon_status is not installed while kselftest setup.
> > It can breaks other tests which depend on drgn_dump_damon_status.
> > Install drgn_dump_damon_status files to fix broken test.
> 
> This patch conflicts with the similar one from Alexandre Ghiti.  Could you
> please rebase yours on top of Alexandre's one (and mention the dependency on
> the comment section under '---' line), unless Andrew resolves the conflict on
> his own?
> 
> > 
> > Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
> > Cc: Alexandre Ghiti <alexghiti@rivosinc.com>
> 
> Reviewed-by: SeongJae Park <sj@kernel.org>

I'll add

Fixes: f3e8e1e51362 ("selftests/damon: add drgn script for extracting damon status")

Re: [PATCH] selftests/damon: fix selftests by installing drgn related script

[Sang-Heon Jeon]

Hi SeongJae

On Wed, Aug 13, 2025 at 2:59 AM SeongJae Park <sj@kernel.org> wrote:
>
> On Tue, 12 Aug 2025 23:00:46 +0900 Sang-Heon Jeon <ekffu200098@gmail.com> wrote:
>
> > drgn_dump_damon_status is not installed while kselftest setup.
> > It can breaks other tests which depend on drgn_dump_damon_status.
> > Install drgn_dump_damon_status files to fix broken test.
>
> This patch conflicts with the similar one from Alexandre Ghiti.  Could you
> please rebase yours on top of Alexandre's one (and mention the dependency on
> the comment section under '---' line), unless Andrew resolves the conflict on
> his own?

Oh, I didn't know that I can use the baseline with an unmerged patch.
As your solution, I can avoid conflict (This time Andrew already did
it) Thanks for letting me know. I'll keep that in my mind as well.

> >
> > Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
> > Cc: Alexandre Ghiti <alexghiti@rivosinc.com>
>
> Reviewed-by: SeongJae Park <sj@kernel.org>
>
> > ---
> > While setup kselftest executable environment and test this patch [1],
> > I found similiar issue. Honestly, I don't know exact solution for this
> > situation. So I just make a new patch. Sorry if it is wrong direction,
> > then please let me know how to do next.
> >
> > [1] https://lore.kernel.org/damon/20250812-alex-fixes_manual-v1-1-c4e99b1f80e4@rivosinc.com/
>
> For patches that you are not really confident about and hence not insisting to
> merge as-is, but wanna ask other's opinions first, you can ask questions via
> plain text mails, or post patches with RFC tag on the subject.

My meaning of "don't know exact solution" was about conflict patch
(Now I read again, I think other people might be confused. That's you,
sob) I will use the method mentioned above from now on. Anyway, thanks
for reminding me about RFC.

> I think this is the right patch, though.
>
> You could refer to the TEST_FILES part of documentation[1] and "Install
> selftests" section on the document for more details.

Thank you for this comment too, and for your always kindness.

> [1] https://origin.kernel.org/doc/html/latest/dev-tools/kselftest.html#contributing-new-tests-details
>
>
> Thanks,
> SJ
>
> [...]

Best Regards.
Sang-Heon Jeon

Re: [PATCH] selftests/damon: fix selftests by installing drgn related script

[Sang-Heon Jeon]

Hello Andrew

On Wed, Aug 13, 2025 at 7:17 AM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Tue, 12 Aug 2025 10:59:39 -0700 SeongJae Park <sj@kernel.org> wrote:
>
> > On Tue, 12 Aug 2025 23:00:46 +0900 Sang-Heon Jeon <ekffu200098@gmail.com> wrote:
> >
> > > drgn_dump_damon_status is not installed while kselftest setup.
> > > It can breaks other tests which depend on drgn_dump_damon_status.
> > > Install drgn_dump_damon_status files to fix broken test.
> >
> > This patch conflicts with the similar one from Alexandre Ghiti.  Could you
> > please rebase yours on top of Alexandre's one (and mention the dependency on
> > the comment section under '---' line), unless Andrew resolves the conflict on
> > his own?
> >
> > >
> > > Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
> > > Cc: Alexandre Ghiti <alexghiti@rivosinc.com>
> >
> > Reviewed-by: SeongJae Park <sj@kernel.org>
>
> I'll add
> Fixes: f3e8e1e51362 ("selftests/damon: add drgn script for extracting damon status")

Thank you for your help. I'll do better next time :)

Best Regards.
Sang-Heon Jeon

Re: [PATCH] selftests/damon: fix selftests by installing drgn related script

[SeongJae Park]

On Wed, 13 Aug 2025 11:24:27 +0900 Sang-Heon Jeon <ekffu200098@gmail.com> wrote:

> Hi SeongJae
> 
> On Wed, Aug 13, 2025 at 2:59 AM SeongJae Park <sj@kernel.org> wrote:
> >
> > On Tue, 12 Aug 2025 23:00:46 +0900 Sang-Heon Jeon <ekffu200098@gmail.com> wrote:
[...]
> > > While setup kselftest executable environment and test this patch [1],
> > > I found similiar issue. Honestly, I don't know exact solution for this
> > > situation. So I just make a new patch. Sorry if it is wrong direction,
> > > then please let me know how to do next.
> > >
> > > [1] https://lore.kernel.org/damon/20250812-alex-fixes_manual-v1-1-c4e99b1f80e4@rivosinc.com/
> >
> > For patches that you are not really confident about and hence not insisting to
> > merge as-is, but wanna ask other's opinions first, you can ask questions via
> > plain text mails, or post patches with RFC tag on the subject.
> 
> My meaning of "don't know exact solution" was about conflict patch
> (Now I read again, I think other people might be confused.

Thank you for clarifying!

> That's you,
> sob) I will use the method mentioned above from now on.

In the case, another (and probably more common) approach would be sharing your
finding of remaining bugs with the original patch author.  Probably sharing
that as a reply-to-all to the patch would be good.  Then, the original author
could revise and post the next version of the patch in a more complete form.

[...]
> Thank you for this comment too, and for your always kindness.

The pleasure is mine :)


Thanks,
SJ

[...]