From: SeongJae Park <sj@kernel.org>
To: Quanmin Yan <yanquanmin1@huawei.com>
Cc: SeongJae Park <sj@kernel.org>,
akpm@linux-foundation.org, damon@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
wangkefeng.wang@huawei.com, zuoze1@huawei.com
Subject: Re: [RFC PATCH -next 12/16] mm/damon: add damon_ctx->min_region and damon_target->min_region
Date: Wed, 13 Aug 2025 09:49:07 -0700 [thread overview]
Message-ID: <20250813164907.5885-1-sj@kernel.org> (raw)
In-Reply-To: <20250813050706.1564229-13-yanquanmin1@huawei.com>
On Wed, 13 Aug 2025 13:07:02 +0800 Quanmin Yan <yanquanmin1@huawei.com> wrote:
> Adopting addr_unit would make DAMON_MINREGION 'addr_unit * 4096'
> bytes and cause data alignment issues[1].
>
> Add damon_ctx->min_region to change DAMON_MIN_REGION from a global
> macro value to per-context variable,
Nice!
> let target inherit the min_region
> from its associated ctx to avoid excessive passing of ctx.
To me, keeping the synchronization seems more complicated than just passing the
addr_unit value to relevant functions. I'd prefer passing the addr_unit to
relevant functions. It could require more changes and might make code uglier,
but I think that's easier to maintain, and we can cleanup/refactor the code
later.
Could you please do so in the next version?
Thanks,
SJ
[...]
next prev parent reply other threads:[~2025-08-13 16:49 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 5:06 [RFC PATCH -next 00/16] mm/damon: support ARM32 with LPAE Quanmin Yan
2025-08-13 5:06 ` [RFC PATCH -next 01/16] mm/damon/core: add damon_ctx->addr_unit Quanmin Yan
2025-08-13 5:06 ` [RFC PATCH -next 02/16] mm/damon/paddr: support addr_unit for access monitoring Quanmin Yan
2025-08-13 5:06 ` [RFC PATCH -next 03/16] mm/damon/paddr: support addr_unit for DAMOS_PAGEOUT Quanmin Yan
2025-08-19 6:18 ` SeongJae Park
2025-08-19 6:26 ` SeongJae Park
2025-08-19 14:18 ` Quanmin Yan
2025-08-19 15:53 ` SeongJae Park
2025-08-13 5:06 ` [RFC PATCH -next 04/16] mm/damon/paddr: support addr_unit for DAMOS_LRU_[DE]PRIO Quanmin Yan
2025-08-19 6:19 ` SeongJae Park
2025-08-19 6:26 ` SeongJae Park
2025-08-13 5:06 ` [RFC PATCH -next 05/16] mm/damon/paddr: support addr_unit for MIGRATE_{HOT,COLD} Quanmin Yan
2025-08-19 6:21 ` SeongJae Park
2025-08-19 6:27 ` SeongJae Park
2025-08-13 5:06 ` [RFC PATCH -next 06/16] mm/damon/paddr: support addr_unit for DAMOS_STAT Quanmin Yan
2025-08-19 6:22 ` SeongJae Park
2025-08-19 6:27 ` SeongJae Park
2025-08-13 5:06 ` [RFC PATCH -next 07/16] mm/damon/sysfs: implement addr_unit file under context dir Quanmin Yan
2025-08-19 6:24 ` SeongJae Park
2025-08-19 14:45 ` Quanmin Yan
2025-08-19 15:56 ` SeongJae Park
2025-08-13 5:06 ` [RFC PATCH -next 08/16] Docs/mm/damon/design: document 'address unit' parameter Quanmin Yan
2025-08-13 5:06 ` [RFC PATCH -next 09/16] Docs/admin-guide/mm/damon/usage: document addr_unit file Quanmin Yan
2025-08-13 5:07 ` [RFC PATCH -next 10/16] Docs/ABI/damon: " Quanmin Yan
2025-08-13 5:07 ` [RFC PATCH -next 11/16] mm/damon: add addr_unit for DAMON_RECLAIM and LRU_SORT Quanmin Yan
2025-08-13 16:36 ` SeongJae Park
2025-08-14 12:59 ` Quanmin Yan
2025-08-14 16:11 ` SeongJae Park
2025-08-19 14:59 ` Quanmin Yan
2025-08-13 5:07 ` [RFC PATCH -next 12/16] mm/damon: add damon_ctx->min_region and damon_target->min_region Quanmin Yan
2025-08-13 16:49 ` SeongJae Park [this message]
2025-08-19 14:52 ` Quanmin Yan
2025-08-13 5:07 ` [RFC PATCH -next 13/16] mm/damon/sysfs: ensure valid addr_unit setting in damon_sysfs_apply_inputs() Quanmin Yan
2025-08-13 17:02 ` SeongJae Park
2025-08-20 8:45 ` Quanmin Yan
2025-08-13 5:07 ` [RFC PATCH -next 14/16] mm/damon/core: convert sz to byte units when updating state Quanmin Yan
2025-08-13 17:08 ` SeongJae Park
2025-08-20 10:10 ` Quanmin Yan
2025-08-13 5:07 ` [RFC PATCH -next 15/16] mm/damon: the byte statistics data type in damos_stat uses unsigned long long Quanmin Yan
2025-08-13 17:10 ` SeongJae Park
2025-08-20 9:54 ` Quanmin Yan
2025-08-20 19:57 ` SeongJae Park
2025-08-13 5:07 ` [RFC PATCH -next 16/16] mm/damon/core: handle quota->esz overflow issues Quanmin Yan
2025-08-13 17:15 ` SeongJae Park
2025-08-20 10:06 ` Quanmin Yan
2025-08-13 17:25 ` [RFC PATCH -next 00/16] mm/damon: support ARM32 with LPAE SeongJae Park
2025-08-14 0:57 ` SeongJae Park
2025-08-14 14:07 ` Quanmin Yan
2025-08-14 16:04 ` SeongJae Park
2025-08-20 10:19 ` Quanmin Yan
2025-08-13 17:28 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250813164907.5885-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wangkefeng.wang@huawei.com \
--cc=yanquanmin1@huawei.com \
--cc=zuoze1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).