From: Andrew Morton <akpm@linux-foundation.org>
To: Alexandre Ghiti <alex@ghiti.fr>
Cc: Andrew Donnellan <ajd@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org,
x86@kernel.org, linux-riscv@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, pasha.tatashin@soleen.com,
sweettea-kernel@dorminy.me, nicholas@linux.ibm.com,
christophe.leroy@csgroup.eu, Rohan McLure <rmclure@linux.ibm.com>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH v16 06/13] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pud_clear()
Date: Thu, 14 Aug 2025 16:24:04 -0700 [thread overview]
Message-ID: <20250814162404.e3a0f12e2aa1a87de51322e7@linux-foundation.org> (raw)
In-Reply-To: <5aa057d0-dc76-4723-80d1-82065320a428@ghiti.fr>
On Thu, 14 Aug 2025 14:11:45 +0200 Alexandre Ghiti <alex@ghiti.fr> wrote:
> > for (i = 0; i < nr; i++)
> > - __page_table_check_pud_clear(mm, *(pudp + i));
> > + __page_table_check_pud_clear(mm, addr + PUD_SIZE * i, *(pudp + i));
> > if (pud_user_accessible_page(pud))
> > page_table_check_set(pud_pfn(pud), stride * nr, pud_write(pud));
> > }
>
>
> So this made me realize we (riscv) did not implement
> pudp_huge_get_and_clear(), which was a mistake since we support THP PUD.
> I have implemented this function in this patch
> https://lore.kernel.org/all/20250814-dev-alex-thp_pud_xchg-v1-1-b4704dfae206@rivosinc.com/T/#u
>
> That's a fix so I'll merge it in 6.17 (at least I'll try) so your
> patchset will break the build on riscv, I'll keep you posted when it
> gets merged!
Thanks, I'll temporarily grab a copy of your "riscv: use an atomic xchg
in pudp_huge_get_and_clear()" to keep mm.git compilable and testable.
next prev parent reply other threads:[~2025-08-14 23:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 6:26 [PATCH v16 00/13] Support page table check on PowerPC Andrew Donnellan
2025-08-13 6:26 ` [PATCH v16 01/13] arm64/mm: Add addr parameter to __set_ptes_anysz() Andrew Donnellan
2025-08-13 6:26 ` [PATCH v16 02/13] arm64/mm: Add addr parameter to __ptep_get_and_clear_anysz() Andrew Donnellan
2025-08-13 6:26 ` [PATCH v16 03/13] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pud[s]_set() Andrew Donnellan
2025-08-14 9:49 ` Alexandre Ghiti
2025-08-13 6:26 ` [PATCH v16 04/13] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pmd[s]_set() Andrew Donnellan
2025-08-14 9:50 ` Alexandre Ghiti
2025-08-13 6:26 ` [PATCH v16 05/13] mm/page_table_check: Provide addr parameter to page_table_check_ptes_set() Andrew Donnellan
2025-08-14 9:50 ` Alexandre Ghiti
2025-08-13 6:26 ` [PATCH v16 06/13] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pud_clear() Andrew Donnellan
2025-08-14 12:11 ` Alexandre Ghiti
2025-08-14 23:24 ` Andrew Morton [this message]
2025-08-13 6:26 ` [PATCH v16 07/13] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pmd_clear() Andrew Donnellan
2025-08-14 9:59 ` Alexandre Ghiti
2025-08-13 6:26 ` [PATCH v16 08/13] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pte_clear() Andrew Donnellan
2025-08-14 10:00 ` Alexandre Ghiti
2025-08-13 6:26 ` [PATCH v16 09/13] mm: Provide address parameter to p{te,md,ud}_user_accessible_page() Andrew Donnellan
2025-08-14 10:01 ` Alexandre Ghiti
2025-08-13 6:26 ` [PATCH v16 10/13] powerpc: mm: Add pud_pfn() stub Andrew Donnellan
2025-08-13 6:26 ` [PATCH v16 11/13] powerpc: mm: Implement *_user_accessible_page() for ptes Andrew Donnellan
2025-08-13 6:26 ` [PATCH v16 12/13] powerpc: mm: Use set_pte_at_unchecked() for internal usages Andrew Donnellan
2025-08-13 6:26 ` [PATCH v16 13/13] powerpc: mm: Support page table check Andrew Donnellan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250814162404.e3a0f12e2aa1a87de51322e7@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ajd@linux.ibm.com \
--cc=alex@ghiti.fr \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@kernel.org \
--cc=nicholas@linux.ibm.com \
--cc=pasha.tatashin@soleen.com \
--cc=rmclure@linux.ibm.com \
--cc=sweettea-kernel@dorminy.me \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).