From: Andrew Morton <akpm@linux-foundation.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: "Herton R. Krzesinski" <herton@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/debug_vm_pgtable: clear page table entries at destroy_args()
Date: Thu, 14 Aug 2025 16:28:01 -0700 [thread overview]
Message-ID: <20250814162801.08ece6844de66ac43af5224f@linux-foundation.org> (raw)
In-Reply-To: <5e5f45c1-e813-4900-8fad-2ed0dc067468@arm.com>
On Thu, 14 Aug 2025 16:16:03 +0530 Anshuman Khandual <anshuman.khandual@arm.com> wrote:
> On 01/08/25 3:10 AM, Herton R. Krzesinski wrote:
> > The mm/debug_vm_pagetable test allocates manually page table entries for the
> > tests it runs, using also its manually allocated mm_struct. That in itself is
> > ok, but when it exits, at destroy_args() it fails to clear those entries with
> > the *_clear functions.
> >
> > The problem is that leaves stale entries. If another process allocates
> > an mm_struct with a pgd at the same address, it may end up running into
> > the stale entry. This is happening in practice on a debug kernel with
> > CONFIG_DEBUG_VM_PGTABLE=y, for example this is the output with some
> > extra debugging I added (it prints a warning trace if pgtables_bytes goes
> > negative, in addition to the warning at check_mm() function):
>
> This has been on linux-next for almost last two weeks now and
> no problem has been reported. So I guess it's all good.
>
[top-posting repaired]
Thanks, I'll move this into the next batch for sending into mainline.
prev parent reply other threads:[~2025-08-14 23:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 21:40 [PATCH] mm/debug_vm_pgtable: clear page table entries at destroy_args() Herton R. Krzesinski
2025-08-01 2:40 ` Anshuman Khandual
2025-08-01 12:07 ` Herton Krzesinski
2025-08-01 20:50 ` Andrew Morton
2025-08-03 10:27 ` Anshuman Khandual
2025-08-14 10:46 ` Anshuman Khandual
2025-08-14 23:28 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250814162801.08ece6844de66ac43af5224f@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=herton@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).