From: Sang-Heon Jeon <ekffu200098@gmail.com>
To: sj@kernel.org, honggyu.kim@sk.com
Cc: damon@lists.linux.dev, linux-mm@kvack.org,
Sang-Heon Jeon <ekffu200098@gmail.com>
Subject: [PATCH] selftests/damon: change wrong json.dump usage to json.dumps
Date: Fri, 15 Aug 2025 18:40:29 +0900 [thread overview]
Message-ID: <20250815094029.133063-1-ekffu200098@gmail.com> (raw)
To print drgn status to stdout json.dumps should be used without
json.dump. Change incorrect function call by typo.
Fixes: 441f487d6ebf ("selftests/damon: test no-op commit broke DAMON status")
Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
---
First I'm sorry that make you guys work twice. This is fix of my last
patch [1]. I'll be more careful next time.
[1] https://lore.kernel.org/damon/20250810124354.16456-1-ekffu200098@gmail.com/
---
tools/testing/selftests/damon/sysfs_no_op_commit_break.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/damon/sysfs_no_op_commit_break.py b/tools/testing/selftests/damon/sysfs_no_op_commit_break.py
index f557587ebc81..2c65cffe6b54 100755
--- a/tools/testing/selftests/damon/sysfs_no_op_commit_break.py
+++ b/tools/testing/selftests/damon/sysfs_no_op_commit_break.py
@@ -62,8 +62,8 @@ def main():
exit(1)
if before_commit_status != after_commit_status:
- print(f'before: {json.dump(before_commit_status, indent=2)}')
- print(f'after: {json.dump(after_commit_status, indent=2)}')
+ print(f'before: {json.dumps(before_commit_status, indent=2)}')
+ print(f'after: {json.dumps(after_commit_status, indent=2)}')
exit(1)
kdamonds.stop()
--
2.43.0
next reply other threads:[~2025-08-15 9:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 9:40 Sang-Heon Jeon [this message]
2025-08-15 17:09 ` [PATCH] selftests/damon: change wrong json.dump usage to json.dumps SeongJae Park
2025-08-16 1:30 ` Sang-Heon Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250815094029.133063-1-ekffu200098@gmail.com \
--to=ekffu200098@gmail.com \
--cc=damon@lists.linux.dev \
--cc=honggyu.kim@sk.com \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).