[PATCH v2] mm/damon/Kconfig: make DAMON_STAT_ENABLED_DEFAULT depend on DAMON_STAT

[PATCH v2] mm/damon/Kconfig: make DAMON_STAT_ENABLED_DEFAULT depend on DAMON_STAT

[Enze Li]

The DAMON_STAT_ENABLED_DEFAULT option is strongly tied to DAMON_STAT
option -- enabling it alone is meaningless.  This patch makes
DAMON_STAT_ENABLED_DEFAULT depend on DAMON_STAT, ensuring functional
consistency.

Signed-off-by: Enze Li <lienze@kylinos.cn>
---
v2:
  - Change the subject as suggested by SJ.
  - Keep 'default DAMON_STAT' as before.
---
 mm/damon/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/damon/Kconfig b/mm/damon/Kconfig
index b3171f9406c1..8c868f7035fc 100644
--- a/mm/damon/Kconfig
+++ b/mm/damon/Kconfig
@@ -104,7 +104,7 @@ config DAMON_STAT
 
 config DAMON_STAT_ENABLED_DEFAULT
 	bool "Enable DAMON_STAT by default"
-	depends on DAMON_PADDR
+	depends on DAMON_STAT
 	default DAMON_STAT
 	help
 	  Whether to enable DAMON_STAT by default.  Users can disable it in

base-commit: d7ee5bdce7892643409dea7266c34977e651b479
-- 
2.43.0

Re: [PATCH v2] mm/damon/Kconfig: make DAMON_STAT_ENABLED_DEFAULT depend on DAMON_STAT

[SeongJae Park]

On Fri, 15 Aug 2025 17:21:10 +0800 Enze Li <lienze@kylinos.cn> wrote:

> The DAMON_STAT_ENABLED_DEFAULT option is strongly tied to DAMON_STAT
> option -- enabling it alone is meaningless.  This patch makes
> DAMON_STAT_ENABLED_DEFAULT depend on DAMON_STAT, ensuring functional

s/depend/depends/ ?

> consistency.
> 
> Signed-off-by: Enze Li <lienze@kylinos.cn>

Fixes: 369c415e6073 ("mm/damon: introduce DAMON_STAT module")
Reviewed-by: SeongJae Park <sj@kernel.org>

> ---
> v2:
>   - Change the subject as suggested by SJ.
>   - Keep 'default DAMON_STAT' as before.

Thank you for addressing my comments!


Thanks,
SJ

[...]

Re: [PATCH v2] mm/damon/Kconfig: make DAMON_STAT_ENABLED_DEFAULT depend on DAMON_STAT

[Enze Li]

Hi SJ,

On Fri, Aug 15 2025 at 09:59:03 AM -0700, SeongJae Park wrote:

> On Fri, 15 Aug 2025 17:21:10 +0800 Enze Li <lienze@kylinos.cn> wrote:
>
>> The DAMON_STAT_ENABLED_DEFAULT option is strongly tied to DAMON_STAT
>> option -- enabling it alone is meaningless.  This patch makes
>> DAMON_STAT_ENABLED_DEFAULT depend on DAMON_STAT, ensuring functional
>
> s/depend/depends/ ?

I'm not well-versed in grammar, but using 'depends on' here feels a bit
weird to me.  After consulting grammar references, it seems to me that
I've found the answer.

In *Collins COBUILD English Grammar 4th* (Section 3.210, titled
transitive verbs with an infinitive without _to_), it says:

> A few verbs are followed by an object and an infinitive without to,
> not an -ing participle or a to-infinitive.  They are let, make, and
> have in the sense of cause to happen or experience.

It's somewhat like what we often call 'make the machine *work*'.  This
is my understanding.  If I misunderstood or missed something, please let
me know, I would be happy to submit v3 of the patch to fix the typo.

Best Regards,
Enze

[...]

Re: [PATCH v2] mm/damon/Kconfig: make DAMON_STAT_ENABLED_DEFAULT depend on DAMON_STAT

[SeongJae Park]

On Sun, 17 Aug 2025 18:20:31 +0800 Enze Li <lienze@kylinos.cn> wrote:

> Hi SJ,
> 
> On Fri, Aug 15 2025 at 09:59:03 AM -0700, SeongJae Park wrote:
> 
> > On Fri, 15 Aug 2025 17:21:10 +0800 Enze Li <lienze@kylinos.cn> wrote:
> >
> >> The DAMON_STAT_ENABLED_DEFAULT option is strongly tied to DAMON_STAT
> >> option -- enabling it alone is meaningless.  This patch makes
> >> DAMON_STAT_ENABLED_DEFAULT depend on DAMON_STAT, ensuring functional
> >
> > s/depend/depends/ ?
> 
> I'm not well-versed in grammar, but using 'depends on' here feels a bit
> weird to me.  After consulting grammar references, it seems to me that
> I've found the answer.
> 
> In *Collins COBUILD English Grammar 4th* (Section 3.210, titled
> transitive verbs with an infinitive without _to_), it says:
> 
> > A few verbs are followed by an object and an infinitive without to,
> > not an -ing participle or a to-infinitive.  They are let, make, and
> > have in the sense of cause to happen or experience.
> 
> It's somewhat like what we often call 'make the machine *work*'.  This
> is my understanding.  If I misunderstood or missed something, please let
> me know, I would be happy to submit v3 of the patch to fix the typo.

My English is really poor, so I believe you're right.  Thank you for correcting
me! :)


Thanks,
SJ

[...]