* [PATCH v2 mm-unstable] selftests/damon: change wrong json.dump usage to json.dumps
@ 2025-08-16 1:40 Sang-Heon Jeon
2025-08-16 16:08 ` SeongJae Park
0 siblings, 1 reply; 2+ messages in thread
From: Sang-Heon Jeon @ 2025-08-16 1:40 UTC (permalink / raw)
To: sj, honggyu.kim; +Cc: damon, linux-mm, Sang-Heon Jeon
To print drgn status to stdout json.dumps should be used without
json.dump. Change incorrect function call by typo.
Fixes: 441f487d6ebf ("selftests/damon: test no-op commit broke DAMON status") # mm-unstable
Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
---
Changes from v1 [1]:
- Change patch subject with DAMON convention
- Add branch hint to fixes section
[1] https://lore.kernel.org/damon/20250815094029.133063-1-ekffu200098@gmail.com/
---
tools/testing/selftests/damon/sysfs_no_op_commit_break.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/damon/sysfs_no_op_commit_break.py b/tools/testing/selftests/damon/sysfs_no_op_commit_break.py
index f557587ebc81..2c65cffe6b54 100755
--- a/tools/testing/selftests/damon/sysfs_no_op_commit_break.py
+++ b/tools/testing/selftests/damon/sysfs_no_op_commit_break.py
@@ -62,8 +62,8 @@ def main():
exit(1)
if before_commit_status != after_commit_status:
- print(f'before: {json.dump(before_commit_status, indent=2)}')
- print(f'after: {json.dump(after_commit_status, indent=2)}')
+ print(f'before: {json.dumps(before_commit_status, indent=2)}')
+ print(f'after: {json.dumps(after_commit_status, indent=2)}')
exit(1)
kdamonds.stop()
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 mm-unstable] selftests/damon: change wrong json.dump usage to json.dumps
2025-08-16 1:40 [PATCH v2 mm-unstable] selftests/damon: change wrong json.dump usage to json.dumps Sang-Heon Jeon
@ 2025-08-16 16:08 ` SeongJae Park
0 siblings, 0 replies; 2+ messages in thread
From: SeongJae Park @ 2025-08-16 16:08 UTC (permalink / raw)
To: Sang-Heon Jeon; +Cc: SeongJae Park, honggyu.kim, damon, linux-mm, Andrew Morton
+ Andrew
On Sat, 16 Aug 2025 10:40:33 +0900 Sang-Heon Jeon <ekffu200098@gmail.com> wrote:
> To print drgn status to stdout json.dumps should be used without
> json.dump. Change incorrect function call by typo.
>
> Fixes: 441f487d6ebf ("selftests/damon: test no-op commit broke DAMON status") # mm-unstable
> Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
> ---
> Changes from v1 [1]:
> - Change patch subject with DAMON convention
> - Add branch hint to fixes section
>
> [1] https://lore.kernel.org/damon/20250815094029.133063-1-ekffu200098@gmail.com/
Thanks,
SJ
[...]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-16 16:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-16 1:40 [PATCH v2 mm-unstable] selftests/damon: change wrong json.dump usage to json.dumps Sang-Heon Jeon
2025-08-16 16:08 ` SeongJae Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).