From: SeongJae Park <sj@kernel.org>
To: Chris Li <chrisl@kernel.org>
Cc: SeongJae Park <sj@kernel.org>, Nhat Pham <nphamcs@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Chengming Zhou <chengming.zhou@linux.dev>,
David Hildenbrand <david@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Yosry Ahmed <yosry.ahmed@linux.dev>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Takero Funaki <flintglass@gmail.com>,
Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH v2] mm/zswap: store <PAGE_SIZE compression failed page as-is
Date: Mon, 18 Aug 2025 11:18:00 -0700 [thread overview]
Message-ID: <20250818181800.59827-1-sj@kernel.org> (raw)
In-Reply-To: <CAF8kJuPwfRVHpvNRr=1NT4z_3Pmr-1u4vfRYmkvh_Kh4uNGy9w@mail.gmail.com>
On Fri, 15 Aug 2025 19:23:10 -0700 Chris Li <chrisl@kernel.org> wrote:
> On Fri, Aug 15, 2025 at 5:14 PM SeongJae Park <sj@kernel.org> wrote:
> >
> > Sounds good. So in the next version (v4), I will drop compress_fail. Instead,
> > I will add two new counters, namely compress_engine_fail and the new atomic
> > counter, say, stored_uncompressed_pages. Please suggest better names or
> > correct me if I'm missing some of your points.
>
> Sounds great. As I suggest in my other email, if up to me,
>
> "crypto_compress_fail" and "stored_incompressible_pages"
Nice names, thank you! I'll send the next verison soon, following all your
suggestions[1] together.
[1] https://lore.kernel.org/CAF8kJuPCpnGAoz=1CBwe46ytpcR0ZUMAEWLFQce7eUWkb+0ERA@mail.gmail.com
Thanks,
SJ
[...]
next prev parent reply other threads:[~2025-08-18 18:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 17:00 [PATCH v2] mm/zswap: store <PAGE_SIZE compression failed page as-is SeongJae Park
2025-08-12 18:52 ` Nhat Pham
2025-08-13 17:07 ` Chris Li
2025-08-13 18:20 ` SeongJae Park
2025-08-15 22:28 ` Chris Li
2025-08-15 23:08 ` Nhat Pham
2025-08-16 0:14 ` SeongJae Park
2025-08-16 2:23 ` Chris Li
2025-08-18 18:18 ` SeongJae Park [this message]
2025-08-18 20:33 ` Chris Li
2025-08-16 0:30 ` Chris Li
2025-08-16 0:07 ` SeongJae Park
2025-08-16 2:20 ` Chris Li
2025-08-13 18:32 ` Nhat Pham
2025-08-15 22:34 ` Chris Li
2025-08-15 22:44 ` Nhat Pham
2025-08-13 18:58 ` Hugh Dickins
2025-08-15 22:38 ` Chris Li
2025-08-13 19:42 ` Shakeel Butt
2025-08-13 20:48 ` Johannes Weiner
2025-08-15 22:44 ` Chris Li
2025-08-15 22:42 ` Chris Li
2025-08-14 16:23 ` Johannes Weiner
2025-08-14 17:04 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250818181800.59827-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=chengming.zhou@linux.dev \
--cc=chrisl@kernel.org \
--cc=david@redhat.com \
--cc=flintglass@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=yosry.ahmed@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).