From: Julian Sun <sunjunchao@bytedance.com>
To: linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org,
linux-mm@kvack.org
Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz,
hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev,
shakeel.butt@linux.dev, muchun.song@linux.dev, axboe@kernel.dk,
tj@kernel.org
Subject: [PATCH 1/3] writeback: Rename wb_writeback_work->auto_free to free_work.
Date: Wed, 20 Aug 2025 19:19:38 +0800 [thread overview]
Message-ID: <20250820111940.4105766-2-sunjunchao@bytedance.com> (raw)
In-Reply-To: <20250820111940.4105766-1-sunjunchao@bytedance.com>
This patch is to prepare for subsequent patches. It only does
's/auto_free/free_work' with no functional changes.
Signed-off-by: Julian Sun <sunjunchao@bytedance.com>
---
fs/fs-writeback.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index cc57367fb641..4a6c22df5649 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -48,7 +48,7 @@ struct wb_writeback_work {
unsigned int range_cyclic:1;
unsigned int for_background:1;
unsigned int for_sync:1; /* sync(2) WB_SYNC_ALL writeback */
- unsigned int auto_free:1; /* free on completion */
+ unsigned int free_work:1; /* free work on completion */
enum wb_reason reason; /* why was writeback initiated? */
struct list_head list; /* pending work list */
@@ -170,7 +170,7 @@ static void finish_writeback_work(struct wb_writeback_work *work)
{
struct wb_completion *done = work->done;
- if (work->auto_free)
+ if (work->free_work)
kfree(work);
if (done) {
wait_queue_head_t *waitq = done->waitq;
@@ -1029,7 +1029,7 @@ static void bdi_split_work_to_wbs(struct backing_dev_info *bdi,
if (work) {
*work = *base_work;
work->nr_pages = nr_pages;
- work->auto_free = 1;
+ work->free_work = 1;
wb_queue_work(wb, work);
continue;
}
@@ -1048,7 +1048,7 @@ static void bdi_split_work_to_wbs(struct backing_dev_info *bdi,
work = &fallback_work;
*work = *base_work;
work->nr_pages = nr_pages;
- work->auto_free = 0;
+ work->free_work = 0;
work->done = &fallback_work_done;
wb_queue_work(wb, work);
@@ -1130,7 +1130,7 @@ int cgroup_writeback_by_id(u64 bdi_id, int memcg_id,
work->range_cyclic = 1;
work->reason = reason;
work->done = done;
- work->auto_free = 1;
+ work->free_work = 1;
wb_queue_work(wb, work);
ret = 0;
} else {
@@ -1237,7 +1237,7 @@ static void bdi_split_work_to_wbs(struct backing_dev_info *bdi,
might_sleep();
if (!skip_if_busy || !writeback_in_progress(&bdi->wb)) {
- base_work->auto_free = 0;
+ base_work->free_work = 0;
wb_queue_work(&bdi->wb, base_work);
}
}
--
2.20.1
next prev parent reply other threads:[~2025-08-20 11:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 11:19 [PATCH 0/3] memcg, writeback: Don't wait writeback completion Julian Sun
2025-08-20 11:19 ` Julian Sun [this message]
2025-08-20 11:19 ` [PATCH] writeback: Add wb_writeback_work->free_done Julian Sun
2025-08-20 11:19 ` [PATCH] memcg: Don't wait writeback completion when release memcg Julian Sun
2025-08-20 20:58 ` Tejun Heo
2025-08-21 2:30 ` [External] " Julian Sun
2025-08-21 16:59 ` Tejun Heo
2025-08-21 18:00 ` Julian Sun
2025-08-21 18:16 ` Julian Sun
2025-08-21 19:01 ` Tejun Heo
2025-08-22 8:22 ` Julian Sun
2025-08-22 17:56 ` Tejun Heo
2025-08-23 6:18 ` Julian Sun
2025-08-23 8:08 ` Giorgi Tchankvetadze
2025-08-23 8:22 ` Julian Sun
2025-08-23 14:08 ` Giorgi Tchankvetadze
2025-08-23 15:17 ` Julian Sun
2025-08-25 17:45 ` Julian Sun
2025-08-25 18:53 ` Tejun Heo
2025-08-25 19:06 ` Julian Sun
2025-08-25 10:13 ` Jan Kara
2025-08-25 12:08 ` Julian Sun
2025-08-25 18:57 ` [External] " Tejun Heo
2025-08-20 12:16 ` [PATCH 0/3] memcg, writeback: Don't wait writeback completion Giorgi Tchankvetadze
2025-08-21 2:37 ` [External] " Julian Sun
2025-08-22 9:29 ` Giorgi Tchankvetadze
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250820111940.4105766-2-sunjunchao@bytedance.com \
--to=sunjunchao@bytedance.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).