From: SeongJae Park <sj@kernel.org>
To: Sang-Heon Jeon <ekffu200098@gmail.com>
Cc: SeongJae Park <sj@kernel.org>,
honggyu.kim@sk.com, damon@lists.linux.dev, linux-mm@kvack.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2] mm/damon/core: set quota->charged_from to jiffies at first charge window
Date: Wed, 20 Aug 2025 22:41:48 -0700 [thread overview]
Message-ID: <20250821054148.53746-1-sj@kernel.org> (raw)
In-Reply-To: <CABFDxME5ZEAn+6=0GRWybTi-xBzbhhz7U38pMni3SdKjA+Aj-A@mail.gmail.com>
On Thu, 21 Aug 2025 13:29:04 +0900 Sang-Heon Jeon <ekffu200098@gmail.com> wrote:
> On Thu, Aug 21, 2025 at 11:54 AM SeongJae Park <sj@kernel.org> wrote:
> >
> > On Thu, 21 Aug 2025 10:08:03 +0900 Sang-Heon Jeon <ekffu200098@gmail.com> wrote:
> >
> > > On Thu, Aug 21, 2025 at 3:27 AM SeongJae Park <sj@kernel.org> wrote:
> > > >
> > > > On Wed, 20 Aug 2025 22:18:53 +0900 Sang-Heon Jeon <ekffu200098@gmail.com> wrote:
> > > >
> > > > > Hello, SeongJae
> > > > >
> > > > > On Wed, Aug 20, 2025 at 2:27 AM SeongJae Park <sj@kernel.org> wrote:
> > > > > >
> > > > > > On Wed, 20 Aug 2025 00:01:23 +0900 Sang-Heon Jeon <ekffu200098@gmail.com> wrote:
> > [...]
> > > I think that I checked about user impact already but it should be
> > > insufficient. As you said, I should discuss it first. Anyway, the
> > > whole thing is my mistake. I'm really so sorry.
> >
> > Everyone makes mistakes. You don't need to apologize.
> >
> > >
> > > So, Would it be better to send an RFC patch even now, instead of
> > > asking on this email thread? (I'll make next v3 patch with RFC tag,
> > > it's not question of v3 direction and just about remained question on
> > > this email thread)
> >
> > If you unsure something and there is no reason to send a patch without a
> > discussion for the point, please discuss first. To be honest I don't
> > understand the above question at all.
>
> Ah, I just mean that I need to make a new RFC patch instead of
> replying to this email thread.
Why?
> I'll just keep asking about previous
> comments on this email thread.
You said you will send a new patch instead of replying here, and then now you
are saying you will keep aking to this thread.
I'm confused.
[...]
Ok, I think this discussion is going unnecessarily deep and only wasting our
time at clarifying intention of past sentence. Meanwhile apparently you
understood my major points. To repeat, please clarify what is the problem and
user impacts, when and how it happens, and why the solution solves it.
Let's restart. Could you please rewrite the commit log for this patch and send
the draft as a reply to this?
We can further discuss on the new draft if it has more things to improve. And
once the discussion is finalized, you can post v4 of this patch with the
updated commit message.
Thanks,
SJ
next prev parent reply other threads:[~2025-08-21 5:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 15:01 [PATCH v2] mm/damon/core: set quota->charged_from to jiffies at first charge window Sang-Heon Jeon
2025-08-19 17:27 ` SeongJae Park
2025-08-19 18:03 ` SeongJae Park
2025-08-20 13:18 ` Sang-Heon Jeon
2025-08-20 18:27 ` SeongJae Park
2025-08-21 1:08 ` Sang-Heon Jeon
2025-08-21 2:54 ` SeongJae Park
2025-08-21 4:29 ` Sang-Heon Jeon
2025-08-21 4:43 ` Sang-Heon Jeon
2025-08-21 5:41 ` SeongJae Park [this message]
2025-08-21 5:43 ` SeongJae Park
2025-08-21 11:06 ` Sang-Heon Jeon
2025-08-21 15:58 ` SeongJae Park
2025-08-21 16:18 ` Sang-Heon Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250821054148.53746-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=damon@lists.linux.dev \
--cc=ekffu200098@gmail.com \
--cc=honggyu.kim@sk.com \
--cc=linux-mm@kvack.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).