From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4B03C8303F for ; Thu, 28 Aug 2025 11:57:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB6CC8E0003; Thu, 28 Aug 2025 07:57:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B3FBA8E0001; Thu, 28 Aug 2025 07:57:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E0FC8E0003; Thu, 28 Aug 2025 07:57:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 86E688E0001 for ; Thu, 28 Aug 2025 07:57:37 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1183816011C for ; Thu, 28 Aug 2025 11:57:37 +0000 (UTC) X-FDA: 83826016554.06.393530F Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf29.hostedemail.com (Postfix) with ESMTP id 7684A120006 for ; Thu, 28 Aug 2025 11:57:35 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OqLtXq0g; spf=pass (imf29.hostedemail.com: domain of leon@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1756382255; a=rsa-sha256; cv=none; b=8OhHNsQV9dY/vJkFyMWnNknBg6wU0DFnWvUD/2KwQ0qclJLZsFz8BtzarKOyph8WESp/To 27UhguHt7bISqeTYAGBDPNBdvxyYW3eokVHbwvFAvkcRrNaeS88bYr4tpdo3A8xMl/zD4j mblxZoyWTb7wx3GhytRePiw7ryKzHeg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OqLtXq0g; spf=pass (imf29.hostedemail.com: domain of leon@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1756382255; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jBKvGDDakYGcFCOIMrtxoT/Y5g/H8pKchV2rdUCvrxw=; b=vH3Uh9nK7seXduL6Mp4J+zviHzRNLMq6KsjF2JajNHRLTttdwvLa1z/zZ7tG4Imty47/UG 1S3HPrNlqI/ch4ZL8nhpoP7pfYlGyYD9mbleymkygFDHYHJwKK5nyhHt0B/dR6mvuhY2tG VxSkJaqTMvDFA7JkzkwtNoWsTG/5SoY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id EABC440888; Thu, 28 Aug 2025 11:57:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E94ADC4CEEB; Thu, 28 Aug 2025 11:57:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756382253; bh=n8QXY5YRm9nQQBYQQGaxgrl8XdTmVTKFna/oqVl/xhQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OqLtXq0gi9UBzAMP2wcXlT2cBb1dLghW49oEfniFZWmFDZ8XrTzjet3Se+cK+4Enz bUcas58K9zqJYJO8K1xC/lojuRYXP35XvwWJ9XYIMcJRmRtfzd1ENQlyeWdM0r06Gk 0iGSQIedtJXaN5EXHSKxCaObLHf9f2/iEhzMO/91YHWTXC+kQV5HZRzX+s7pvZgTMs /wX7b7wyAX9BAZbCT37OSLoaEdenWMo5h/NWko9aq0V1TzuE+BMc75vbwrCyO1DV2e WdS++dKThCK37gVl5uHk3NBx12J9+O+GbVUmIbjagbvOKAeDIwhduPUosVAdqLdX7n wfEu8DIXf5M5g== Date: Thu, 28 Aug 2025 14:57:29 +0300 From: Leon Romanovsky To: Marek Szyprowski Cc: Jason Gunthorpe , Abdiel Janulgue , Alexander Potapenko , Alex Gaynor , Andrew Morton , Christoph Hellwig , Danilo Krummrich , iommu@lists.linux.dev, Jason Wang , Jens Axboe , Joerg Roedel , Jonathan Corbet , Juergen Gross , kasan-dev@googlegroups.com, Keith Busch , linux-block@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-nvme@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-trace-kernel@vger.kernel.org, Madhavan Srinivasan , Masami Hiramatsu , Michael Ellerman , "Michael S. Tsirkin" , Miguel Ojeda , Robin Murphy , rust-for-linux@vger.kernel.org, Sagi Grimberg , Stefano Stabellini , Steven Rostedt , virtualization@lists.linux.dev, Will Deacon , xen-devel@lists.xenproject.org Subject: Re: [PATCH v4 00/16] dma-mapping: migrate to physical address-based API Message-ID: <20250828115729.GA10073@unreal> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7684A120006 X-Stat-Signature: w84eqo1936amimu6zpz8joyjp1dkx5me X-Rspam-User: X-HE-Tag: 1756382255-737328 X-HE-Meta: U2FsdGVkX19JySBXA82wt7JH7X28wV8Ret7nmgyh2XMkvCna0H16J0PqjpnDjCrsUvJHcNBcuBTMA0xBc+4KnhzTrcA8G+5SJkB3eAKH4L8/lqNlq+Jm9GgMxHlvQZ0xHbFGBgzC67n/6897occnPjC4//ZGFbnIpYEF+WE/5Fyc44jZBMGZPRYFRPRNwGSbCxGSoULypsja/day269dgUsuW+SRCV57CX7esCSPMpdrLqYUOsgE7A5j1jTB6m/bRJ/xDF2PKfA2+AUPoCx3PKCd6KeF/JJJYrdeQdtQZzapy0ioj1VUtBz3u7jukVDVUetjCD1eoZ3Suv0AVcKZ0opDehdvGxD9fXYqbOSC4T5/h2xa9AWazxnpGTGXwrtc5EVqiH4XuAJcDbWl2MjBjoqDqOHdLMAdi8aJLSgvkOxGqTSJb6kNY11SZv3rsIuPIlqiWGlHZdTk2lzGYbiZm91RBO6HnGdOVdGqZ5C+8tR4GcFsX6y7C4alj2NFiwG9urWvNSbxy5ryT1qHUZ2RCv2w+aUMa4cvGdjYhcPKdQWn/JfFS0cRanKZk0o9qSWNVwZqNSWUwDugIMY8DICiyyAZcGn0Vthr2FMm4SuM1VKmjud0O/UlqlVUvh7LLm7cat4zKyfmdnYTxyTQPOxEBki2Lm+YSryyL4uvlO3wAGEVSEv+H8ovyzivZBQ6AvbB9vQ+7w8wxORnOc4WZgqpwe+BUie4JPAk61ieETsa6RAEnjdC904sj1gzY0A0lLCdDSbr9iEanWUXipqNzUgGZ+1+8RR2wu0feGvngNcqhAKX0fQakfo8xWPX07uyKxu/+30lsANWrpScB1Ty3htA9H47ZTI5qzDrta2bcSmCUFm++ux4p6RZ+9Auv4BcCJCt4ck9mQXTmr4DD5QldmQZZa6sBqL2sZGKyq89rTsedTd9h6ij+ZxNVcI0OCqP2hHAoRyY6B8RGYqk1LcTf+3 XIygfUMd UMY81IRA18/IIehHR8EZfMo2IHA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Aug 19, 2025 at 08:36:44PM +0300, Leon Romanovsky wrote: > Changelog: > v4: > * Fixed kbuild error with mismatch in kmsan function declaration due to > rebase error. > v3: https://lore.kernel.org/all/cover.1755193625.git.leon@kernel.org > * Fixed typo in "cacheable" word > * Simplified kmsan patch a lot to be simple argument refactoring > v2: https://lore.kernel.org/all/cover.1755153054.git.leon@kernel.org > * Used commit messages and cover letter from Jason > * Moved setting IOMMU_MMIO flag to dma_info_to_prot function > * Micro-optimized the code > * Rebased code on v6.17-rc1 > v1: https://lore.kernel.org/all/cover.1754292567.git.leon@kernel.org > * Added new DMA_ATTR_MMIO attribute to indicate > PCI_P2PDMA_MAP_THRU_HOST_BRIDGE path. > * Rewrote dma_map_* functions to use thus new attribute > v0: https://lore.kernel.org/all/cover.1750854543.git.leon@kernel.org/ > ------------------------------------------------------------------------ > > This series refactors the DMA mapping to use physical addresses > as the primary interface instead of page+offset parameters. This > change aligns the DMA API with the underlying hardware reality where > DMA operations work with physical addresses, not page structures. > > The series maintains export symbol backward compatibility by keeping > the old page-based API as wrapper functions around the new physical > address-based implementations. > > This series refactors the DMA mapping API to provide a phys_addr_t > based, and struct-page free, external API that can handle all the > mapping cases we want in modern systems: > > - struct page based cachable DRAM > - struct page MEMORY_DEVICE_PCI_P2PDMA PCI peer to peer non-cachable > MMIO > - struct page-less PCI peer to peer non-cachable MMIO > - struct page-less "resource" MMIO > > Overall this gets much closer to Matthew's long term wish for > struct-pageless IO to cachable DRAM. The remaining primary work would > be in the mm side to allow kmap_local_pfn()/phys_to_virt() to work on > phys_addr_t without a struct page. > > The general design is to remove struct page usage entirely from the > DMA API inner layers. For flows that need to have a KVA for the > physical address they can use kmap_local_pfn() or phys_to_virt(). This > isolates the struct page requirements to MM code only. Long term all > removals of struct page usage are supporting Matthew's memdesc > project which seeks to substantially transform how struct page works. > > Instead make the DMA API internals work on phys_addr_t. Internally > there are still dedicated 'page' and 'resource' flows, except they are > now distinguished by a new DMA_ATTR_MMIO instead of by callchain. Both > flows use the same phys_addr_t. > > When DMA_ATTR_MMIO is specified things work similar to the existing > 'resource' flow. kmap_local_pfn(), phys_to_virt(), phys_to_page(), > pfn_valid(), etc are never called on the phys_addr_t. This requires > rejecting any configuration that would need swiotlb. CPU cache > flushing is not required, and avoided, as ATTR_MMIO also indicates the > address have no cachable mappings. This effectively removes any > DMA API side requirement to have struct page when DMA_ATTR_MMIO is > used. > > In the !DMA_ATTR_MMIO mode things work similarly to the 'page' flow, > except on the common path of no cache flush, no swiotlb it never > touches a struct page. When cache flushing or swiotlb copying > kmap_local_pfn()/phys_to_virt() are used to get a KVA for CPU > usage. This was already the case on the unmap side, now the map side > is symmetric. > > Callers are adjusted to set DMA_ATTR_MMIO. Existing 'resource' users > must set it. The existing struct page based MEMORY_DEVICE_PCI_P2PDMA > path must also set it. This corrects some existing bugs where iommu > mappings for P2P MMIO were improperly marked IOMMU_CACHE. > > Since ATTR_MMIO is made to work with all the existing DMA map entry > points, particularly dma_iova_link(), this finally allows a way to use > the new DMA API to map PCI P2P MMIO without creating struct page. The > VFIO DMABUF series demonstrates how this works. This is intended to > replace the incorrect driver use of dma_map_resource() on PCI BAR > addresses. > > This series does the core code and modern flows. A followup series > will give the same treatment to the legacy dma_ops implementation. > > Thanks > > Leon Romanovsky (16): > dma-mapping: introduce new DMA attribute to indicate MMIO memory > iommu/dma: implement DMA_ATTR_MMIO for dma_iova_link(). > dma-debug: refactor to use physical addresses for page mapping > dma-mapping: rename trace_dma_*map_page to trace_dma_*map_phys > iommu/dma: rename iommu_dma_*map_page to iommu_dma_*map_phys > iommu/dma: extend iommu_dma_*map_phys API to handle MMIO memory > dma-mapping: convert dma_direct_*map_page to be phys_addr_t based > kmsan: convert kmsan_handle_dma to use physical addresses > dma-mapping: handle MMIO flow in dma_map|unmap_page > xen: swiotlb: Open code map_resource callback > dma-mapping: export new dma_*map_phys() interface > mm/hmm: migrate to physical address-based DMA mapping API > mm/hmm: properly take MMIO path > block-dma: migrate to dma_map_phys instead of map_page > block-dma: properly take MMIO path > nvme-pci: unmap MMIO pages with appropriate interface > > Documentation/core-api/dma-api.rst | 4 +- > Documentation/core-api/dma-attributes.rst | 18 ++++ > arch/powerpc/kernel/dma-iommu.c | 4 +- > block/blk-mq-dma.c | 15 ++- > drivers/iommu/dma-iommu.c | 61 +++++------ > drivers/nvme/host/pci.c | 18 +++- > drivers/virtio/virtio_ring.c | 4 +- > drivers/xen/swiotlb-xen.c | 21 +++- > include/linux/blk-mq-dma.h | 6 +- > include/linux/blk_types.h | 2 + > include/linux/dma-direct.h | 2 - > include/linux/dma-map-ops.h | 8 +- > include/linux/dma-mapping.h | 33 ++++++ > include/linux/iommu-dma.h | 11 +- > include/linux/kmsan.h | 9 +- > include/trace/events/dma.h | 9 +- > kernel/dma/debug.c | 71 ++++--------- > kernel/dma/debug.h | 37 ++----- > kernel/dma/direct.c | 22 +--- > kernel/dma/direct.h | 52 ++++++---- > kernel/dma/mapping.c | 117 +++++++++++++--------- > kernel/dma/ops_helpers.c | 6 +- > mm/hmm.c | 19 ++-- > mm/kmsan/hooks.c | 5 +- > rust/kernel/dma.rs | 3 + > tools/virtio/linux/kmsan.h | 2 +- > 26 files changed, 305 insertions(+), 254 deletions(-) Marek, So what are the next steps here? This series is pre-requirement for the VFIO MMIO patches. Thanks > > -- > 2.50.1 > >