From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AEB4DCA0FFF for ; Mon, 1 Sep 2025 15:30:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF8028E008D; Mon, 1 Sep 2025 11:12:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B96D98E0084; Mon, 1 Sep 2025 11:12:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A86018E008D; Mon, 1 Sep 2025 11:12:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8DD7C8E0084 for ; Mon, 1 Sep 2025 11:12:35 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5C2271DE936 for ; Mon, 1 Sep 2025 15:12:35 +0000 (UTC) X-FDA: 83841023070.19.A32CB5C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id A4D35160018 for ; Mon, 1 Sep 2025 15:12:33 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SxLze3GO; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1756739553; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xdu9xaWJPy4xxrd5+T58pW5GTA8RumIRC51tNRceaXw=; b=h1PWklpPSK6v5SUnF9WpjABzaJWDtx0deM1dcOqWwfRkafvkURwR39xXHMc+8GRSHExxA6 G+nRj+XMMpZjlCBUhQdFJBaDKU98OIsmTxfTMMggYpZ6CQ2VYeU9VojTxth0llsPR01/Vi l/TiAnSZgYYG2DihWEG6nB9up8LuSbo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1756739553; a=rsa-sha256; cv=none; b=ItAEVi6ud9+RCAoecFAy3G9+YDDbbrWMHQgm+TsvD1HwG6WEo6SxHk89Yk9jLYePBIEaBo n6h0mbhUEMQJwZZAqvFdTzj8S4Vf6PwHZhGo4jBLYEDeZLmH5S3qREU6G3O9IDGPD36VOX q3UtFQAoEeyj1B6evyynXy9pcQob4xI= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SxLze3GO; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756739553; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xdu9xaWJPy4xxrd5+T58pW5GTA8RumIRC51tNRceaXw=; b=SxLze3GOQlwMoRK4phBkXXNy3c5mOrWYCj2gbEieddbwGvk+yjrFJysIndBClHUILJlRzM MTul6922bdcMorgdeBUcst2bXcRlZMwPAOH6+s5ED3bOsoQJ4TrJwfIC5vZZ4lX+KS0Nvq D08Bfd8CyGsOpWzcIlxLr2Yc74VdGOU= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-631-7XKs2uOQNGSb4vphMHuW0w-1; Mon, 01 Sep 2025 11:12:29 -0400 X-MC-Unique: 7XKs2uOQNGSb4vphMHuW0w-1 X-Mimecast-MFC-AGG-ID: 7XKs2uOQNGSb4vphMHuW0w_1756739544 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 49ACB19560A2; Mon, 1 Sep 2025 15:12:24 +0000 (UTC) Received: from t14s.fritz.box (unknown [10.22.88.45]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4FFED1800447; Mon, 1 Sep 2025 15:12:05 +0000 (UTC) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: David Hildenbrand , Bart Van Assche , Lorenzo Stoakes , "Martin K. Petersen" , "James E.J. Bottomley" , Alexander Potapenko , Andrew Morton , Brendan Jackman , Christoph Lameter , Dennis Zhou , Dmitry Vyukov , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, iommu@lists.linux.dev, io-uring@vger.kernel.org, Jason Gunthorpe , Jens Axboe , Johannes Weiner , John Hubbard , kasan-dev@googlegroups.com, kvm@vger.kernel.org, "Liam R. Howlett" , Linus Torvalds , linux-arm-kernel@axis.com, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-ide@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, Marco Elver , Marek Szyprowski , Michal Hocko , Mike Rapoport , Muchun Song , netdev@vger.kernel.org, Oscar Salvador , Peter Xu , Robin Murphy , Suren Baghdasaryan , Tejun Heo , virtualization@lists.linux.dev, Vlastimil Babka , wireguard@lists.zx2c4.com, x86@kernel.org, Zi Yan Subject: [PATCH v2 30/37] scsi: scsi_lib: drop nth_page() usage within SG entry Date: Mon, 1 Sep 2025 17:03:51 +0200 Message-ID: <20250901150359.867252-31-david@redhat.com> In-Reply-To: <20250901150359.867252-1-david@redhat.com> References: <20250901150359.867252-1-david@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: A4D35160018 X-Stat-Signature: 336nywrmfd3uqcy93mps8ouh4xfgcyqq X-HE-Tag: 1756739553-84758 X-HE-Meta: U2FsdGVkX19X8G4EI9LvBJ60QMrtTBbMMbJGMeegf6riE9U1AC7h/94IKmh94RoBW7vMNh7PxyZHXgtBm5o6MQ/X1wCattr0YKwY3lxdCIepzyOAlddZZN0xV0YmjZar0pA/UCk+nqR47ORkr0aONsj+l+6AZnhxnlFnQjdWwFXZTt8tu0y6hew0F2+qE7IZkgNQ3wu75vvIG5mMkxmCNWwcR+LX5TC6AAc4jXhuO5o/hGmyqt94FD7hHslkeZr0oBRNn0V/AxTVuTZtTwvL2vMyr6J+d8jo9jcCwJ4fI8RHeoK6EFeubpJ4dtb02pbDsyjHSk07VuBF2Z5FYQC151TFiIi6xw8xJl0XXzV7ZAMR+MCKu5nSxkEp6n6BgEU57pbdBvjRPTVsAs3gonkSAiDaPTdBCoD7JBw7e1Z3b+whpPOKQ8KoHjvHCBSvIIOPVlRz2PlwbdpH5eOro8UXK/ocGaicsPKOTfVHyNVRf3MXTGl+M5CrUARmBUiAVu8mUmINAwn5zUlHIs9sRCPgUFCT0tRY6aBTGEpcmpol2SBe8bLC1X0rtCE7JwkWqL+LmLGrk45hS0gJJWU06LfT4ZUATejlK9Iep631WThTEaLBftz5ZSzFFkFGi/1LWZ7uUysiB+nhAXDhZU5Bjn22KSzj4nn2tvxa/pcon/dDR5WKuA/ybDfhX8p14y/32VCJtsrYDanTVfXBMjKwzOOc4syDuwlXfNIYqNX1RZJPPy1n3PlsQ1bllmptLEoxsQRm3o2HuAcwFaZTiBpF8EIfe6nbtlOPHT6rGOX8n6hpqDvVmhAx+Uvpmpcyp4gw89l1gtZRmYDR5ENZ3P14icBzuGI9tBnxxS51p5d6cllf2jqTUqvbmUGe4G4K+KNsWjnFAEEyO0MbA7HDqmJN5LGw181iASlDClepks0Kcfe9KzmFpa20JyEMjSPzfu6TK0sbPPf7YkXVvsWIJIRFgtD f63pNK9a 7p+NKo/aL3Ewo2DKiEYVJfHTyZZUdTMzOGQvOdMCUdeD0wT5/EUyDHZ33xZVqvZfIrX/j9dz9oYHmunvAEw+ET2I1uQPh/rxd9RSQPBFTWwZ0wbW+aWduxcswAYrX/ajqdW9BkSGxPswhDOnoL9QR6ml0TiEHzZCsQT0Rgf3hHzv+sy+wmsK+pViP6VwA9eZZAZ1tvyxa+fhuPsjmB0qCQs72cMm9SRqG0lSRUE11OGftTEUbrzkqPlDW9ZzT7Y9+DMvFjfcRc6NFQz4T2R1wuTy3+TSgXL9L9yLclLfEmIeFVOBA/k5+s4DSC50jk/YV0ScTz/xngaJxvn5n1y7trPsDlpabAtoxyZygXYVEAl0s8J4v6fu6AESuQ1+uSymGETzzYqDiw8Ks9yEX8emldOyrMbv8mFjLTFi2WpSZ6UZFV97E1ZLUyOv8aHueC3o+kTJL2wG6z8zbIAhG2ukp4bLeUIN9BuI1GT3hC+5lZbbF3cQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: It's no longer required to use nth_page() when iterating pages within a single SG entry, so let's drop the nth_page() usage. Reviewed-by: Bart Van Assche Reviewed-by: Lorenzo Stoakes Reviewed-by: Martin K. Petersen Cc: "James E.J. Bottomley" Signed-off-by: David Hildenbrand --- drivers/scsi/scsi_lib.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index 0c65ecfedfbd6..d7e42293b8645 100644 --- a/drivers/scsi/scsi_lib.c +++ b/drivers/scsi/scsi_lib.c @@ -3148,8 +3148,7 @@ void *scsi_kmap_atomic_sg(struct scatterlist *sgl, int sg_count, /* Offset starting from the beginning of first page in this sg-entry */ *offset = *offset - len_complete + sg->offset; - /* Assumption: contiguous pages can be accessed as "page + i" */ - page = nth_page(sg_page(sg), (*offset >> PAGE_SHIFT)); + page = sg_page(sg) + (*offset >> PAGE_SHIFT); *offset &= ~PAGE_MASK; /* Bytes in this sg-entry from *offset to the end of the page */ -- 2.50.1