linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-block@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
	linux-efi@vger.kernel.org, virtualization@lists.linux.dev,
	"Vishal Moola (Oracle)" <vishal.moola@gmail.com>,
	"Matthew Wilcox (Oracle)" <willy@infradead.org>,
	SeongJae Park <sj@kernel.org>
Subject: [PATCH v3 1/7] mm/page_alloc: Add kernel-docs for free_pages()
Date: Wed,  3 Sep 2025 11:59:15 -0700	[thread overview]
Message-ID: <20250903185921.1785167-2-vishal.moola@gmail.com> (raw)
In-Reply-To: <20250903185921.1785167-1-vishal.moola@gmail.com>

Add kernel-docs to free_pages(). This will help callers understand when
to use it instead of __free_pages().

Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Acked-by: SeongJae Park <sj@kernel.org>
---
 mm/page_alloc.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index c2a254d877f8..0277b86b62ac 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5269,6 +5269,15 @@ void free_pages_nolock(struct page *page, unsigned int order)
 	___free_pages(page, order, FPI_TRYLOCK);
 }
 
+/**
+ * free_pages - Free pages allocated with __get_free_pages().
+ * @addr: The virtual address tied to a page returned from __get_free_pages().
+ * @order: The order of the allocation.
+ *
+ * This function behaves the same as __free_pages(). Use this function
+ * to free pages when you only have a valid virtual address. If you have
+ * the page, call __free_pages() instead.
+ */
 void free_pages(unsigned long addr, unsigned int order)
 {
 	if (addr != 0) {
-- 
2.51.0



  reply	other threads:[~2025-09-03 18:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-03 18:59 [PATCH v3 0/7] Cleanup free_pages() misuse Vishal Moola (Oracle)
2025-09-03 18:59 ` Vishal Moola (Oracle) [this message]
2025-09-03 18:59 ` [PATCH v3 2/7] aoe: Stop calling page_address() in free_page() Vishal Moola (Oracle)
2025-09-03 18:59 ` [PATCH v3 3/7] x86: Stop calling page_address() in free_pages() Vishal Moola (Oracle)
2025-09-04 11:51   ` Mike Rapoport
2025-09-04 11:54     ` Mike Rapoport
2025-09-05 18:02       ` Vishal Moola (Oracle)
2025-09-03 18:59 ` [PATCH v3 4/7] riscv: " Vishal Moola (Oracle)
2025-09-04 12:27   ` Alexandre Ghiti
2025-09-03 18:59 ` [PATCH v3 5/7] powerpc: " Vishal Moola (Oracle)
2025-09-04  7:10   ` Christophe Leroy
2025-09-03 18:59 ` [PATCH v3 6/7] arm64: " Vishal Moola (Oracle)
2025-09-03 18:59 ` [PATCH v3 7/7] virtio_balloon: " Vishal Moola (Oracle)
2025-09-03 19:13   ` David Hildenbrand
2025-09-04 21:38   ` Michael S. Tsirkin
2025-09-04 11:55 ` [PATCH v3 0/7] Cleanup free_pages() misuse Mike Rapoport

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250903185921.1785167-2-vishal.moola@gmail.com \
    --to=vishal.moola@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=sj@kernel.org \
    --cc=virtualization@lists.linux.dev \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).