linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Suren Baghdasaryan <surenb@google.com>
To: akpm@linux-foundation.org
Cc: kent.overstreet@linux.dev, vbabka@suse.cz, mhocko@suse.com,
	 jackmanb@google.com, hannes@cmpxchg.org, ziy@nvidia.com,
	 usamaarif642@gmail.com, shakeel.butt@linux.dev,
	00107082@163.com,  pasha.tatashin@soleen.com,
	souravpanda@google.com, surenb@google.com,  linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] alloc_tag: prevent enabling memory profiling if it was shut down
Date: Tue,  9 Sep 2025 16:34:08 -0700	[thread overview]
Message-ID: <20250909233409.1013367-3-surenb@google.com> (raw)
In-Reply-To: <20250909233409.1013367-1-surenb@google.com>

Memory profiling can be shut down due to reasons like a failure during
initialization. When this happens, the user should not be able to
re-enable it. Current sysctrl interface does not handle this properly
and will allow re-enabling memory profiling. Fix this by checking for
this condition during sysctrl write operation.

Signed-off-by: Suren Baghdasaryan <surenb@google.com>
---
 lib/alloc_tag.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c
index 95688c4cba7a..79891528e7b6 100644
--- a/lib/alloc_tag.c
+++ b/lib/alloc_tag.c
@@ -767,6 +767,16 @@ struct page_ext_operations page_alloc_tagging_ops = {
 EXPORT_SYMBOL(page_alloc_tagging_ops);
 
 #ifdef CONFIG_SYSCTL
+static int proc_mem_profiling_handler(const struct ctl_table *table, int write,
+				      void *buffer, size_t *lenp, loff_t *ppos)
+{
+	if (!mem_profiling_support && write)
+		return -EINVAL;
+
+	return proc_do_static_key(table, write, buffer, lenp, ppos);
+}
+
+
 static struct ctl_table memory_allocation_profiling_sysctls[] = {
 	{
 		.procname	= "mem_profiling",
@@ -776,7 +786,7 @@ static struct ctl_table memory_allocation_profiling_sysctls[] = {
 #else
 		.mode		= 0644,
 #endif
-		.proc_handler	= proc_do_static_key,
+		.proc_handler	= proc_mem_profiling_handler,
 	},
 };
 
-- 
2.51.0.384.g4c02a37b29-goog



  parent reply	other threads:[~2025-09-09 23:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-09 23:34 [PATCH 0/3] Minor fixes for memory allocation profiling Suren Baghdasaryan
2025-09-09 23:34 ` [PATCH 1/3] alloc_tag: use release_pages() in the cleanup path Suren Baghdasaryan
2025-09-10  5:31   ` Shakeel Butt
2025-09-10 20:49   ` Usama Arif
2025-09-12 21:05     ` Suren Baghdasaryan
2025-09-09 23:34 ` Suren Baghdasaryan [this message]
2025-09-10  5:32   ` [PATCH 2/3] alloc_tag: prevent enabling memory profiling if it was shut down Shakeel Butt
2025-09-10 20:51   ` Usama Arif
2025-09-11 17:01     ` Suren Baghdasaryan
2025-09-09 23:34 ` [PATCH 3/3] alloc_tag: avoid warnings when freeing non-compound "tail" pages Suren Baghdasaryan
2025-09-11 20:01   ` Shakeel Butt
2025-09-11 20:12     ` Suren Baghdasaryan
2025-09-11 21:44       ` Shakeel Butt
2025-09-11 21:51         ` Suren Baghdasaryan
2025-09-11 22:58   ` Shakeel Butt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250909233409.1013367-3-surenb@google.com \
    --to=surenb@google.com \
    --cc=00107082@163.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=jackmanb@google.com \
    --cc=kent.overstreet@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=pasha.tatashin@soleen.com \
    --cc=shakeel.butt@linux.dev \
    --cc=souravpanda@google.com \
    --cc=usamaarif642@gmail.com \
    --cc=vbabka@suse.cz \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).