linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Suren Baghdasaryan <surenb@google.com>
To: akpm@linux-foundation.org
Cc: kent.overstreet@linux.dev, vbabka@suse.cz, mhocko@suse.com,
	 jackmanb@google.com, hannes@cmpxchg.org, ziy@nvidia.com,
	 usamaarif642@gmail.com, shakeel.butt@linux.dev,
	00107082@163.com,  pasha.tatashin@soleen.com,
	souravpanda@google.com, surenb@google.com,  linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] alloc_tag: avoid warnings when freeing non-compound "tail" pages
Date: Tue,  9 Sep 2025 16:34:09 -0700	[thread overview]
Message-ID: <20250909233409.1013367-4-surenb@google.com> (raw)
In-Reply-To: <20250909233409.1013367-1-surenb@google.com>

When freeing "tail" pages of a non-compount high-order page, we properly
subtract the allocation tag counters, however later when these pages are
released, alloc_tag_sub() will issue warnings because tags for these pages
are NULL.
This issue was originally anticipated by Vlastimil in his review [1] and
then recently reported by David.
Prevent warnings by marking the tags empty.

[1] https://lore.kernel.org/all/6db0f0c8-81cb-4d04-9560-ba73d63db4b8@suse.cz/

Suggested-by: David Wang <00107082@163.com>
Signed-off-by: Suren Baghdasaryan <surenb@google.com>
---
 mm/page_alloc.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 1760346bbd24..d21a411e807e 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5240,9 +5240,16 @@ static void ___free_pages(struct page *page, unsigned int order,
 		__free_frozen_pages(page, order, fpi_flags);
 	else if (!head) {
 		pgalloc_tag_sub_pages(tag, (1 << order) - 1);
-		while (order-- > 0)
+		while (order-- > 0) {
+			/*
+			 * The "tail" pages of this non-compound high-order
+			 * page will have no code tags, so to avoid warnings
+			 * mark them as empty.
+			 */
+			clear_page_tag_ref(page + (1 << order));
 			__free_frozen_pages(page + (1 << order), order,
 					    fpi_flags);
+		}
 	}
 }
 
-- 
2.51.0.384.g4c02a37b29-goog



  parent reply	other threads:[~2025-09-09 23:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-09 23:34 [PATCH 0/3] Minor fixes for memory allocation profiling Suren Baghdasaryan
2025-09-09 23:34 ` [PATCH 1/3] alloc_tag: use release_pages() in the cleanup path Suren Baghdasaryan
2025-09-10  5:31   ` Shakeel Butt
2025-09-10 20:49   ` Usama Arif
2025-09-12 21:05     ` Suren Baghdasaryan
2025-09-09 23:34 ` [PATCH 2/3] alloc_tag: prevent enabling memory profiling if it was shut down Suren Baghdasaryan
2025-09-10  5:32   ` Shakeel Butt
2025-09-10 20:51   ` Usama Arif
2025-09-11 17:01     ` Suren Baghdasaryan
2025-09-09 23:34 ` Suren Baghdasaryan [this message]
2025-09-11 20:01   ` [PATCH 3/3] alloc_tag: avoid warnings when freeing non-compound "tail" pages Shakeel Butt
2025-09-11 20:12     ` Suren Baghdasaryan
2025-09-11 21:44       ` Shakeel Butt
2025-09-11 21:51         ` Suren Baghdasaryan
2025-09-11 22:58   ` Shakeel Butt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250909233409.1013367-4-surenb@google.com \
    --to=surenb@google.com \
    --cc=00107082@163.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=jackmanb@google.com \
    --cc=kent.overstreet@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=pasha.tatashin@soleen.com \
    --cc=shakeel.butt@linux.dev \
    --cc=souravpanda@google.com \
    --cc=usamaarif642@gmail.com \
    --cc=vbabka@suse.cz \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).