From: SeongJae Park <sj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: SeongJae Park <sj@kernel.org>,
damon@lists.linux.dev, kernel-team@meta.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: [PATCH 3/6] mm/damon/lru_sort: use param_ctx correctly
Date: Sun, 14 Sep 2025 18:58:04 -0700 [thread overview]
Message-ID: <20250915015807.101505-4-sj@kernel.org> (raw)
In-Reply-To: <20250915015807.101505-1-sj@kernel.org>
damon_lru_sort_apply_parameters() allocates a new DAMON context, stages
user-specified DAMON parameters on it, and commits to running DAMON
context at once, using damon_commit_ctx(). The code is, however,
directly updating the monitoring attributes of the running context. This
doesn't cause a real user problem but apparently this is an
unintentional mistake that can cause code review confusions and future
real problems. Fix the wrong use of the parameter context.
Fixes: a30969436428 ("mm/damon/lru_sort: use damon_commit_ctx()")
Signed-off-by: SeongJae Park <sj@kernel.org>
---
mm/damon/lru_sort.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/damon/lru_sort.c b/mm/damon/lru_sort.c
index 14d31009c09e..ab6173a646bd 100644
--- a/mm/damon/lru_sort.c
+++ b/mm/damon/lru_sort.c
@@ -219,7 +219,7 @@ static int damon_lru_sort_apply_parameters(void)
goto out;
}
- err = damon_set_attrs(ctx, &damon_lru_sort_mon_attrs);
+ err = damon_set_attrs(param_ctx, &damon_lru_sort_mon_attrs);
if (err)
goto out;
--
2.39.5
next prev parent reply other threads:[~2025-09-15 1:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 1:58 [PATCH 0/6] mm/damon: misc fixups and improvements for 6.18 SeongJae Park
2025-09-15 1:58 ` [PATCH 1/6] mm/damon/core: reset age if nr_accesses changes between non-zero and zero SeongJae Park
2025-09-15 14:51 ` Joshua Hahn
2025-09-15 18:26 ` SeongJae Park
2025-09-16 3:52 ` Andrew Morton
2025-09-15 1:58 ` [PATCH 2/6] mm/damon/core: set effective quota on first charge window SeongJae Park
2025-09-15 1:58 ` SeongJae Park [this message]
2025-09-15 15:05 ` [PATCH 3/6] mm/damon/lru_sort: use param_ctx correctly Joshua Hahn
2025-09-15 18:43 ` SeongJae Park
2025-09-16 3:04 ` SeongJae Park
2025-09-15 1:58 ` [PATCH 4/6] Docs/mm/damon/maintainer-profile: update community meetup for reservation requirements SeongJae Park
2025-09-15 15:07 ` Joshua Hahn
2025-09-15 18:44 ` SeongJae Park
2025-09-15 1:58 ` [PATCH 5/6] Docs/admin-guide/mm/damon/start: add --target_pid to DAMOS example command SeongJae Park
2025-09-15 15:08 ` [PATCH 0/6] mm/damon: misc fixups and improvements for 6.18 Joshua Hahn
2025-09-15 15:25 ` Joanne Koong
2025-09-15 15:28 ` Joshua Hahn
2025-09-15 18:06 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250915015807.101505-4-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).