Re: [PATCH v6 2/2] rust: zpool: add abstraction for zpool drivers

Benno Lossin
2025-09-24T17:32:25Z

On Wed Sep 24, 2025 at 11:23 AM CEST, Vitaly Wool wrote:
> On 9/23/25 23:49, Benno Lossin wrote:
>> On Tue Sep 23, 2025 at 12:27 PM CEST, Vitaly Wool wrote:
>>> diff --git a/rust/kernel/zpool.rs b/rust/kernel/zpool.rs
>>> new file mode 100644
>>> index 000000000000..53a0dc0607e6
>>> --- /dev/null
>>> +++ b/rust/kernel/zpool.rs
>>> @@ -0,0 +1,366 @@
>>> +// SPDX-License-Identifier: GPL-2.0
>>> +
>>> +//! Implementation of Rust interface towards zpool API.
>>> +
>>> +use crate::{error::Result, kernel::alloc::Flags, str::CString, types::ForeignOwnable};
>>> +use core::ptr::NonNull;
>>> +use kernel::alloc::NumaNode;
>>> +
>>> +/// The Rust representation of zpool handle.
>>
>> Would be great to explain what this means, what's the handle used for?
>
> Sorry, do you mean explaining it here or in the code?

Yeah give a short summary what this means. So something like:

/// Zpool handle
///
/// Used to represent an allocation on a [`ZPool`].

Doesn't need to be detailed.

>>> +pub struct ZpoolHandle(usize);
>>> +
>>> +impl ZpoolHandle {
>>> + /// Create `ZpoolHandle` from the raw representation.
>>> + pub fn from_raw(h: usize) -> Self {
>>> + Self(h)
>>> + }
>>> +
>>> + /// Get the raw representation of the handle.
>>> + pub fn as_raw(self) -> usize {
>>> + self.0
>>> + }
>>
>> Hmm this seems a bit weird, because now users of Zpools can manufacture
>> their own handles? Not sure as to how we could still allow Zpool
>> implementers to create these while preventing other users from doing
>> creating them though...
>
> This is a good question indeed. The thing is, an allocation backend
> (these implementing zpool api) is to provide an opaque handle which is
> usize, and since it has the best knowledge how to compose it, we need to
> let it do that. OTOH I am not too happy with this straightforward
> approach (from_raw()/as_raw()) either.
>
> Would making ZpoolHandle opaque here and defining a trait that a backend
> must implement for ZpoolHandle work better? The example backend would
> then do something like
>
> struct MyZpoolHandle {
> ptr: *mut u8,
> pow: usize,
> }
> type ZpoolHandle = MyZpoolHandle;
>
> trait AsRawHandle {
> fn as_raw_handle(&self) -> usize;
> }
>
> impl AsRawHandle for ZpoolHandle {
> fn as_raw_handle(&self) -> usize {
> (self.ptr as usize) | self.pow
> }
> }
>
> Would that make sense?

You don't need the trait. You can just add an associated type to
`ZpoolDriver` called `Handle` and then use that instead of this concrete
type.

Implementers of `ZpoolDriver` need to then provide their own handle &
they can ensure nobody except they are able to construct one.

Or do some other functions need access to the raw usize representation?

>>> +
>>> +/// Zpool API.
>>> +///
>>> +/// The [`ZpoolDriver`] trait serves as an interface for Zpool drivers implemented in Rust.
>>> +/// Such drivers implement memory storage pools in accordance with the zpool API.
>>> +///
>>> +/// # Example
>>> +///
>>> +/// A zpool driver implementation which uses KVec of 2**n sizes, n = 6, 7, ..., PAGE_SHIFT.
>>> +/// Every zpool object is packed into a KVec that is sufficiently large, and n (the
>>> +/// denominator) is saved in the least significant bits of the handle, which is guaranteed
>>> +/// to be at least 2**6 aligned by kmalloc.
>>> +///
>>> +/// ```
>>> +/// use core::ptr::{NonNull, copy_nonoverlapping};
>>> +/// use core::sync::atomic::{AtomicU64, Ordering};
>>> +/// use kernel::alloc::{Flags, flags, KBox, KVec, NumaNode};
>>> +/// use kernel::page::PAGE_SHIFT;
>>> +/// use kernel::prelude::EINVAL;
>>> +/// use kernel::str::CString;
>>> +/// use kernel::zpool::*;
>>> +///
>>> +/// struct MyZpool {
>>> +/// name: CString,
>>> +/// bytes_used: AtomicU64,
>>> +/// }
>>> +///
>>> +/// struct MyZpoolDriver;
>>> +///
>>> +/// impl ZpoolDriver for MyZpoolDriver {
>>> +/// type Pool = KBox<MyZpool>;
>>> +///
>>> +/// fn create(name: CString, gfp: Flags) -> Result<KBox<MyZpool>> {
>>> +/// let my_pool = MyZpool { name, bytes_used: AtomicU64::new(0) };
>>> +/// let pool = KBox::new(my_pool, gfp)?;
>>> +///
>>> +/// pr_debug!("Pool {:?} created\n", pool.name);
>>> +/// Ok(pool)
>>> +/// }
>>> +///
>>> +/// fn malloc(pool: &MyZpool, size: usize, _gfp: Flags, _nid: NumaNode) -> Result<ZpoolHandle> {
>>> +/// let pow = size.next_power_of_two().trailing_zeros().max(6);
>>> +/// match pow {
>>> +/// 0 => Err(EINVAL),
>>> +/// m if m > PAGE_SHIFT as u32 => Err(ENOSPC),
>>> +/// _ => {
>>> +/// let vec = KVec::<u8>::with_capacity(1 << pow, GFP_KERNEL)?;
>>> +/// let (ptr, _len, _cap) = vec.into_raw_parts();
>>> +///
>>> +/// // We assume that kmalloc-64, kmalloc-128 etc. kmem caches will be used for
>>> +/// // our allocations, so it's actually `1 << pow` bytes that we have consumed.
>>> +/// pool.bytes_used.fetch_add(1 << pow, Ordering::Relaxed);
>>> +///
>>> +/// // `kmalloc` guarantees that an allocation of size x*2^n is 2^n aligned.
>>> +/// // Therefore the 6 lower bits are zeros and we can use these to store `pow`.
>>> +/// Ok(ZpoolHandle::from_raw(ptr as usize | (pow as usize - 6)))
>>> +/// }
>>> +/// }
>>> +/// }
>>> +///
>>> +/// unsafe fn free(pool: &MyZpool, handle: ZpoolHandle) {
>>> +/// let h = handle.as_raw();
>>> +/// let n = (h & 0x3F) + 6;
>>> +/// let uptr = h & !0x3F;
>>> +///
>>> +/// // SAFETY:
>>> +/// // - we derive `uptr` from handle by zeroing 6 lower bits where we store the power
>>> +/// // denominator for the vector capacity. As noted above, the result will be exactly the
>>> +/// // pointer to the area allocated by `KVec`. Thus, uptr is a valid pointer pointing to
>>> +/// // the vector allocated by `alloc` function above.
>>> +/// // - 1 << n == capacity and is coming from the first 6 bits of handle.
>>> +/// let vec = unsafe { KVec::<u8>::from_raw_parts(uptr as *mut u8, 0, 1 << n) };
>>> +/// drop(vec);
>>> +/// pool.bytes_used.fetch_sub(1 << n, Ordering::Relaxed);
>>> +/// }
>>> +///
>>> +/// unsafe fn read_begin(_pool: &MyZpool, handle: ZpoolHandle) -> NonNull<u8> {
>>> +/// let uptr = handle.as_raw() & !0x3F;
>>> +/// // SAFETY:
>>> +/// // - we derive `uptr` from handle by zeroing 6 lower bits where we store the power
>>> +/// // denominator for the vector capacity. As noted above, the result will be exactly the
>>> +/// // pointer to the area allocated by `KVec`. Thus, uptr is a valid pointer pointing to
>>> +/// // the vector allocated by `alloc` function above.
>>> +/// unsafe { NonNull::new_unchecked(uptr as *mut u8) }
>>> +/// }
>>> +///
>>> +/// unsafe fn read_end(_pool: &MyZpool, _handle: ZpoolHandle, _handle_mem: NonNull<u8>) {}
>>> +///
>>> +/// unsafe fn write(_p: &MyZpool, handle: ZpoolHandle, h_mem: NonNull<u8>, mem_len: usize) {
>>> +/// let uptr = handle.as_raw() & !0x3F;
>>> +/// // SAFETY:
>>> +/// // - `h_mem` is a valid non-null pointer provided by zswap.
>>> +/// // - `uptr` is derived from handle by zeroing 6 lower bits where we store the power
>>> +/// // denominator for the vector capacity. As noted above, the result will be exactly the
>>> +/// // pointer to the area allocated by `KVec`. Thus, uptr is a valid pointer pointing to
>>> +/// // the vector allocated by `alloc` function above.
>>> +/// unsafe {
>>> +/// copy_nonoverlapping(h_mem.as_ptr().cast(), uptr as *mut c_void, mem_len)
>>> +/// };
>>> +/// }
>>> +///
>>> +/// fn total_pages(pool: &MyZpool) -> u64 {
>>> +/// pool.bytes_used.load(Ordering::Relaxed) >> PAGE_SHIFT
>>> +/// }
>>> +/// }
>>> +///
>>> +/// // Uncomment this for compile time registration (disabled to avoid build error when KUNIT
>>> +/// // tests and zsmalloc are enabled):
>>> +/// // kernel::DECLARE_ZPOOL!(MyZpoolDriver);
>>> +/// ```
>>> +///
>>> +pub trait ZpoolDriver {
>>> + /// Opaque Rust representation of `struct zpool`.
>>> + type Pool: ForeignOwnable;
>>
>> Also what happened to my comment on v4 of this patchset?
>>
>> https://lore.kernel.org/all/DCLK1YG1L5TZ.1VMGX131LII9V@kernel.org:
>>
>>>> It can indeed but then the ZpoolDriver trait will have to be extended
>>>> with functions like into_raw() and from_raw(), because zpool expects
>>>> *mut c_void, so on the Adapter side it will look like
>>>>
>>>> extern "C" fn create_(name: *const c_uchar, gfp: u32) -> *mut c_void {
>>>> // SAFETY: the memory pointed to by name is guaranteed by zpool
>>>> to be a valid string
>>>> let pool = unsafe { T::create(CStr::from_char_ptr(name),
>>>> Flags::from_raw(gfp)) };
>>>> match pool {
>>>> Err(_) => null_mut(),
>>>> Ok(p) => T::into_raw(p).cast(),
>>>> }
>>>> }
>>>>
>>>> The question is, why does this make it better?
>>>
>>> No, thanks for sharing that function. Then the question becomes, do you
>>> really need `ForeignOwnable`? Or is `KBox` enough? Do you really want
>>> people to use `Arc<MyZPool>`? Because `BorrowedMut` of `Arc` is the same
>>> as it's `Borrowed` variant (it's read-only after all).
>>>
>>> If you can get away with just `Box` (you might want people to choose
>>> their allocator, which is fine IMO), then I'd do so.
>>
>> I still think that if you can use `Box<Self>` the trait is going to be
>> much easier to understand.
>
> Okay, thanks, I'll work on that.

If you do need `Arc` support, then I'd keep it this way, but I don't
know if you do need it.

>>> +
>>> + /// Create a pool.
>>> + fn create(name: CString, gfp: Flags) -> Result<Self::Pool>;
>>> +
>>> + /// Allocate an object of `size` bytes from `pool`, with the allocation flags `gfp` and
>>> + /// preferred NUMA node `nid`. If the allocation is successful, an opaque handle is returned.
>>> + fn malloc(
>>> + pool: <Self::Pool as ForeignOwnable>::Borrowed<'_>,
>>> + size: usize,
>>> + gfp: Flags,
>>> + nid: NumaNode,
>>> + ) -> Result<ZpoolHandle>;
>>> +
>>> + /// Free an object previously allocated from the `pool`, represented by `handle`.
>>> + ///
>>> + /// # Safety
>>> + ///
>>> + /// - `handle` must be a valid handle previously returned by `malloc`.
>>> + /// - `handle` must not be used any more after the call to `free`.
>>> + unsafe fn free(pool: <Self::Pool as ForeignOwnable>::Borrowed<'_>, handle: ZpoolHandle);
>>> +
>>> + /// Make all the necessary preparations for the caller to be able to read from the object
>>> + /// represented by `handle` and return a valid pointer to that object's memory to be read.
>>> + ///
>>> + /// # Safety
>>> + ///
>>> + /// - `handle` must be a valid handle previously returned by `malloc`.
>>> + /// - `read_end` with the same `handle` must be called for each `read_begin`.
>>> + unsafe fn read_begin(
>>> + pool: <Self::Pool as ForeignOwnable>::Borrowed<'_>,
>>> + handle: ZpoolHandle,
>>> + ) -> NonNull<u8>;
>>> +
>>> + /// Finish reading from a previously allocated `handle`. `handle_mem` must be the pointer
>>> + /// previously returned by `read_begin`.
>>> + ///
>>> + /// # Safety
>>> + ///
>>> + /// - `handle` must be a valid handle previously returned by `malloc`.
>>> + /// - `handle_mem` must be the pointer previously returned by `read_begin`.
>>> + unsafe fn read_end(
>>> + pool: <Self::Pool as ForeignOwnable>::Borrowed<'_>,
>>> + handle: ZpoolHandle,
>>> + handle_mem: NonNull<u8>,
>>> + );
>>> +
>>> + /// Write to the object represented by a previously allocated `handle`. `handle_mem` points
>>> + /// to the memory to copy data from, and `mem_len` defines the length of the data block to
>>> + /// be copied.
>>> + ///
>>> + /// # Safety
>>> + ///
>>> + /// - `handle` must be a valid handle previously returned by `malloc`.
>>> + /// - `handle_mem` must be a valid pointer into the allocated memory aread represented by
>>> + /// `handle`.
>>> + /// - `handle_mem + mem_len - 1` must not point outside the allocated memory area.
>>> + unsafe fn write(
>>> + pool: <Self::Pool as ForeignOwnable>::Borrowed<'_>,
>>> + handle: ZpoolHandle,
>>> + handle_mem: NonNull<u8>,
>>> + mem_len: usize,
>>> + );
>>> +
>>> + /// Get the number of pages used by the `pool`.
>>> + fn total_pages(pool: <Self::Pool as ForeignOwnable>::Borrowed<'_>) -> u64;
>>> +}
>>> +
>>> +/// Provide a zpool allocator to zswap
>>> +#[macro_export]
>>> +macro_rules! DECLARE_ZPOOL {
>>
>> Why all caps and not snake case?
>
> C style, sorry :) Will fix.
>
>>> + ($t: ident) => {
>>> + use core::ptr::null_mut;
>>> + use kernel::error::from_result;
>>> + use kernel::types::ForeignOwnable;
>>
>> Macros shouldn't have `use` statements in a non-local area (so inside
>> `const` bodies and modules is fine).
>>
>>> +
>>> + const __LOG_PREFIX: &[u8] = b"zpool_rust\0";
>>
>> This seems wrong. Why do you need to generate this? Shouldn't the user
>> still invoke `module!` or a similar macro?
>
> Unfortunately not. As we have discussed at Kangrejos, the zpool
> implementation as a driver is on its way out [1] and there has to be
> more voices against that for it to be stopped. If we now are dealing
> with the build time API (i. e. a wrapper over zsmalloc functions) then
> we have to define a build time macro, be that DECLARE_ZPOOL or
> DeclareZpool :)

But this macro shouldn't declare the `__LOG_PREFIX` const? What if I
want to have a zpool driver in addition to having a module? Or is that
impossible to begin with?

>>> +
>>> + fn handle_from_result<T, F>(f: F) -> T
>>> + where
>>> + T: From<usize>,
>>> + F: FnOnce() -> Result<T>,
>>> + {
>>> + match f() {
>>> + Ok(v) => v,
>>> + Err(e) => T::from(0),
>>> + }
>>> + }
>>
>> Why is this function inside the macro?
>
> Doesn't seem to be needed elsewhere. I could put it in a separate patch
> for error.rs as a complement to from_result() but I thought no one was
> interested in this case.

Now that I look more closely at this function, why does it even exist?
You only have a single usage here and since this is a macro, you could
just perform the match there...

>>> +
>>> + /// Create a pool.
>>> + #[no_mangle]
>>> + pub unsafe extern "C" fn zpool_create_pool(name: *const c_uchar) -> *mut c_void {
>>
>> Missing safety docs.
>>
>>> + match (|| -> Result<<$t as ZpoolDriver>::Pool> {
>>> + // SAFETY: the memory pointed to by name is guaranteed by `zpool` to be a valid
>>> + // string.
>>> + let name_r = unsafe { CStr::from_char_ptr(name).to_cstring() }?;
>>> + $t::create(name_r, flags::GFP_KERNEL)
>>> + })() {
>>> + Err(_) => null_mut(),
>>> + Ok(pool) => <$t as ZpoolDriver>::Pool::into_foreign(pool),
>>> + }
>>> + }
>>> +
>>> + /// Destroy the pool.
>>> + #[no_mangle]
>>> + pub unsafe extern "C" fn zpool_destroy_pool(pool: *mut c_void) {
>>> + // SAFETY: The pointer originates from an `into_foreign` call.
>>> + drop(unsafe { <$t as ZpoolDriver>::Pool::from_foreign(pool) })
>>> + }
>>
>> Have you tried to use the same pattern that we use for the many
>> different `Registration` types in the kernel? For example take a look at
>> `Adapter<T>` from `rust/kernel/net/phy.rs`. That way you don't need a
>> macro and can make the registration a function that takes a generic `T:
>> ZpoolDriver`.
>
> That's what was in the previous version. Unfortunately it won't work any
> more for the reason described above, see also [1].

I see. But this API design is a bit weird IMO, since now you can't have
two Zpool drivers at the same time (even if only one of them is used at
runtime)? Or is that something that you wouldn't do in the first place?

I also dislike that we have to generate these `no_mangle` functions from
within a macro...

---
Cheers,
Benno

> [1]
> https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/mm?h=mm-stable&id=2ccd9fecd9163f168761d4398564c81554f636ef