From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2890CCA471 for ; Tue, 30 Sep 2025 10:46:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 59D748E0028; Tue, 30 Sep 2025 06:46:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 54E858E0002; Tue, 30 Sep 2025 06:46:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48B408E0028; Tue, 30 Sep 2025 06:46:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 387B28E0002 for ; Tue, 30 Sep 2025 06:46:18 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D15E4BAC7E for ; Tue, 30 Sep 2025 10:46:17 +0000 (UTC) X-FDA: 83945587194.05.93D853E Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) by imf04.hostedemail.com (Postfix) with ESMTP id 0865040003 for ; Tue, 30 Sep 2025 10:46:15 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=QTjlXH2q; spf=pass (imf04.hostedemail.com: domain of boris.brezillon@collabora.com designates 148.251.105.195 as permitted sender) smtp.mailfrom=boris.brezillon@collabora.com; dmarc=pass (policy=none) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1759229176; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S4KYOVAfG2EDjCiQPVHu2HNjEnQ4vyOLnqlxFq3af60=; b=iKe0t3AY5RFzS1QddMNxcDQtI5G0cEvi0zA4dXMTy++kBCHYEHNojyNMQzSW3pB7FY4QwB UgA+f45Z2QkWNmuFUUAhY7udkM8ULyW9z93a3XVYUTamq4pcHDK1DgfkXH/tviz3YlZWOW w5Te0eSUdf8f6pZFDRa+gVXS4mNxJ4c= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=QTjlXH2q; spf=pass (imf04.hostedemail.com: domain of boris.brezillon@collabora.com designates 148.251.105.195 as permitted sender) smtp.mailfrom=boris.brezillon@collabora.com; dmarc=pass (policy=none) header.from=collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1759229176; a=rsa-sha256; cv=none; b=U2/BLJDkeqO45xh9kpLjqxpv73wMJwpd1g0WdljvYP0s/Duxh/+AOo2HFfyBfe5+ldN+qy qHClNzEDdX4SGwFQfyH6hSUGmqFou0kI46ZJngO4yzdV4rEiVFah60JPzGwddfdcl2c6j1 uhyJh/QpCs5Zj2LjwYXsGvLUoxsdEVI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1759229173; bh=D7FPMpVUID4VWIVsRLfS5OjhCnjT47sZGTl0id6lZQU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QTjlXH2qlSMLT94RF69MdmWM6gnsmuNpbnGAeDVk1OFSCE7ihPVo6rNvTIG/Tpe8w vNGepnhvL010tfDYKJQl6E05PrKb8kutNjqacgZjs/Kq5Hss/drZ9NpqvKNbm4J2pC 8HxDIJ7eFltlQetIVqrN6rrC3ye9kzs/tS+mOE/1FOm2Q4+S/Ef7Ouj35S5BMygvHH 5xxg9pkWPGbseOA6vdpLQwJmreCPctFohglY6D0BHYsgGQVNUUXyoJeKZpiFa9qXs6 PpSBuODe7zdLCk3IdG3klbaab4KPtqvbO+ITsVd+nISzyN9TkGdbvJOT5rJNB1kOhk SW9R625asBKbQ== Received: from fedora (unknown [IPv6:2a01:e0a:2c:6930:d919:a6e:5ea1:8a9f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id B361117E0CF8; Tue, 30 Sep 2025 12:46:12 +0200 (CEST) Date: Tue, 30 Sep 2025 12:45:54 +0200 From: Boris Brezillon To: =?UTF-8?B?TG/Dr2M=?= Molinari Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Rob Herring , Steven Price , Liviu Dudau , Melissa Wen , =?UTF-8?B?TWHDrXJh?= Canal , Hugh Dickins , Baolin Wang , Andrew Morton , Al Viro , =?UTF-8?B?TWlrb8WCYWo=?= Wasiak , Christian Brauner , Nitin Gote , Andi Shyti , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-mm@kvack.org, kernel@collabora.com Subject: Re: [PATCH 2/8] drm/gem: Introduce drm_gem_get_unmapped_area() fop Message-ID: <20250930124554.5459194c@fedora> In-Reply-To: <20250930123003.75370854@fedora> References: <20250929200316.18417-1-loic.molinari@collabora.com> <20250929200316.18417-3-loic.molinari@collabora.com> <20250930123003.75370854@fedora> Organization: Collabora X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 0865040003 X-Stat-Signature: 76b5jumqufn5stgnwo7u3a3gha9odnxk X-HE-Tag: 1759229175-19626 X-HE-Meta: U2FsdGVkX194oJ+kQip0DmiqCjjVcnEK2HGEOYBPmr+s4G+/uBO6HUa0hyeniihlivpQbb3n0dRhfxzxP5mOlWelFEvRSycTujNWKu5hR4dzQD0J56CFH0mq4jBQFHX+hJE/wI8xzBM1vCqUGEZq3hmNnHIHdpANb77R0tXMTAoF9KZaq3N50XKQjCNbh4O6P8r3+qSd8ez7Pij81BH8JWTCljZdLDCpdbhapsxTr5dPxYaH626+aWNiGiISHAtRij2vTI38YdNIUl92EpqxTwVo3z4glXQ1rx2CtgVERgUTGp3GB1RI4o6IDC5LwWt59XrZlhzer+wiFEq2PXqdPiqvX3rTN6uEU6KRJ1jQeEmShn7/n3XOUwyE73mIUQGGXgU2uinMyHEHzD1Km7YvaDzq3YniGKyOP5mNFYKv5/Edzlnj5251SAs+m5sjGYJj0wmvzsTO4C371KrGolsh8kZgEFuwBNz2UdpM9nW6SyaUgGbEavfOiVoOxAyHzzgUz0UMA+857xdsXYVNmkYSHp/AkhAtEGGbdd28WCjceV0rv00hkUAQWvYFtkIwPRthSrqqwLZtaSQ48m7ri4J3g93NxJIgqz0Sh3S8wS86mO9zSfkr15N97c3BYN8SIafuzXDKEOZY7kPexWyKWbGroL9p+02J2L8y0NJrvfpuw6edu1o7b6JMExB90Jk8Oo3jCIGXnMiAakJlkdHZL/eug8Fzr2wlSaNZdRTZlTsVJfMgricnKSSILOU/9gB+EjJAtfq7sYY6EiALRzqgOz7LEtf0hkRTGV8MmOcm47bXo8V8lrcrLi68E1DYYHOCnra+FAAoTgEwcniTqUHowJCclhGSlA2L1woU736VQViYRCMRAIgSXA5ko7BEUsFaDau1mETcdk7Jxe7OIQDLQjiReZktvhmjDOq4/Sr+LGXI3JGeJM/ZVkbeB66vzMDozQBTTBlkIIqQLfe2yTqwHIu FG68VtbS RbEHgfR1+eFunczr3FtSrKhwOl+ginlIXOT+tuzf3Jyh2rRrJHaUE9PtcgqzjELdSYmLJi6M8WP3Qy7wYF94itfqLcPL7J09QuISa0KMJTQNbFMwWYNcglKfRbGyOtxp/u1ZiPP/k9kpnJAvZaE97MiW7m15vcmCNh7jlaBtiE3CIfLXpgLBfXgLDFML0W0wbdHb8ww6lcWXJrzpfTCm/z/Cxyj+3QI3zYnXNIe7euP/pYV8d3EyR9y0SkcKkERLFztYIr98BnDZ8lHaZ3WhGJjTIpNwyJbONWpkPBzPFq3LeYCcIOOgcznkKDuBxFxGUtwvEoU55+ukhY/kL3vVyC2unQtfyDBajxSwGC+5DY9OkpZhRjP/4Tn+TRJ1OrsVNxegI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 30 Sep 2025 12:30:03 +0200 Boris Brezillon wrote: > > +unsigned long drm_gem_get_unmapped_area(struct file *filp, unsigned long uaddr, > > + unsigned long len, unsigned long pgoff, > > + unsigned long flags) > > +{ > > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > > + struct drm_gem_object *obj; > > + unsigned long ret; > > + > > + obj = drm_gem_object_lookup_from_offset(filp, pgoff, len >> PAGE_SHIFT); > > + if (IS_ERR(obj)) > > Is this supposed to happen? If not, I'd be tempted to add a > WARN_ON_ONCE(). Taking that back. I think you need it for non-GEM backed mappings, like userland IOMEM mappings. > > > + return mm_get_unmapped_area(current->mm, filp, uaddr, len, 0, > > + flags); > > +