From: Wei Yang <richard.weiyang@gmail.com>
To: akpm@linux-foundation.org, david@redhat.com,
lorenzo.stoakes@oracle.com, ziy@nvidia.com,
baolin.wang@linux.alibaba.com, Liam.Howlett@oracle.com,
npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com,
baohua@kernel.org, lance.yang@linux.dev
Cc: linux-mm@kvack.org, Wei Yang <richard.weiyang@gmail.com>
Subject: [Patch v2 1/2] mm/huge_memory: cache folio attribute in __split_unmapped_folio()
Date: Thu, 16 Oct 2025 00:46:12 +0000 [thread overview]
Message-ID: <20251016004613.514-2-richard.weiyang@gmail.com> (raw)
In-Reply-To: <20251016004613.514-1-richard.weiyang@gmail.com>
During the execution of __split_unmapped_folio(), the folio's anon/!anon
attribute is invariant (not expected to change).
Therefore, it is safe and more efficient to retrieve this attribute once
at the start and reuse it throughout the function.
Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
Cc: Zi Yan <ziy@nvidia.com>
Reviewed-by: Zi Yan <ziy@nvidia.com>
Reviewed-by: wang lian <lianux.mm@gmail.com>
---
mm/huge_memory.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 3c74227cc847..4b2d5a7e5c8e 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -3527,6 +3527,7 @@ static int __split_unmapped_folio(struct folio *folio, int new_order,
struct page *split_at, struct xa_state *xas,
struct address_space *mapping, bool uniform_split)
{
+ bool is_anon = folio_test_anon(folio);
int order = folio_order(folio);
int start_order = uniform_split ? new_order : order - 1;
bool stop_split = false;
@@ -3534,7 +3535,7 @@ static int __split_unmapped_folio(struct folio *folio, int new_order,
int split_order;
int ret = 0;
- if (folio_test_anon(folio))
+ if (is_anon)
mod_mthp_stat(order, MTHP_STAT_NR_ANON, -1);
folio_clear_has_hwpoisoned(folio);
@@ -3551,7 +3552,7 @@ static int __split_unmapped_folio(struct folio *folio, int new_order,
struct folio *new_folio;
/* order-1 anonymous folio is not supported */
- if (folio_test_anon(folio) && split_order == 1)
+ if (is_anon && split_order == 1)
continue;
if (uniform_split && split_order != new_order)
continue;
@@ -3603,7 +3604,7 @@ static int __split_unmapped_folio(struct folio *folio, int new_order,
if (split_order != new_order && !stop_split)
continue;
}
- if (folio_test_anon(new_folio))
+ if (is_anon)
mod_mthp_stat(folio_order(new_folio),
MTHP_STAT_NR_ANON, 1);
}
--
2.34.1
next prev parent reply other threads:[~2025-10-16 0:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 0:46 [Patch v2 0/2] mm/huge_memory: cleanup __split_unmapped_folio() Wei Yang
2025-10-16 0:46 ` Wei Yang [this message]
2025-10-16 1:34 ` [Patch v2 1/2] mm/huge_memory: cache folio attribute in __split_unmapped_folio() Barry Song
2025-10-16 20:01 ` David Hildenbrand
2025-10-17 9:46 ` Lorenzo Stoakes
2025-10-19 7:51 ` Wei Yang
2025-10-16 0:46 ` [Patch v2 2/2] mm/huge_memory: Optimize and simplify __split_unmapped_folio() logic Wei Yang
2025-10-16 1:25 ` wang lian
2025-10-16 20:10 ` David Hildenbrand
2025-10-16 20:22 ` Zi Yan
2025-10-16 20:55 ` David Hildenbrand
2025-10-16 20:56 ` Zi Yan
2025-10-17 0:55 ` Wei Yang
2025-10-17 9:44 ` Lorenzo Stoakes
2025-10-17 14:26 ` Zi Yan
2025-10-17 14:29 ` Zi Yan
2025-10-17 14:44 ` Lorenzo Stoakes
2025-10-17 14:45 ` David Hildenbrand
2025-10-17 14:55 ` Lorenzo Stoakes
2025-10-17 17:24 ` Zi Yan
2025-10-20 14:03 ` Lorenzo Stoakes
2025-10-20 14:28 ` Zi Yan
2025-10-21 0:30 ` Wei Yang
2025-10-21 9:17 ` Lorenzo Stoakes
2025-10-19 8:00 ` Wei Yang
2025-10-20 11:55 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251016004613.514-2-richard.weiyang@gmail.com \
--to=richard.weiyang@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=dev.jain@arm.com \
--cc=lance.yang@linux.dev \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=npache@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).