From: wang lian <lianux.mm@gmail.com>
To: richard.weiyang@gmail.com
Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org,
baohua@kernel.org, baolin.wang@linux.alibaba.com,
david@redhat.com, dev.jain@arm.com, lance.yang@linux.dev,
lianux.mm@gmail.com, linux-mm@kvack.org,
lorenzo.stoakes@oracle.com, npache@redhat.com,
ryan.roberts@arm.com, ziy@nvidia.com
Subject: Re: [Patch v3 2/4] mm/huge_memory: update folio stat after successful split
Date: Thu, 23 Oct 2025 09:26:02 +0800 [thread overview]
Message-ID: <20251023012602.14780-1-lianux.mm@gmail.com> (raw)
In-Reply-To: <20251021212142.25766-3-richard.weiyang@gmail.com>
> The current implementation complicates this process:
> * It iterates over the resulting new folios.
> * It uses a flag (@stop_split) to conditionally skip updating the stat
> for the folio at @split_at during the loop.
> * It then attempts to update the skipped stat on a subsequent failure
> path.
> This logic is unnecessarily hard to follow.
> This commit refactors the code to update the folio statistics only after
> a successful split. This makes the logic much cleaner and sets the stage
> for further simplification of the stat-handling code.
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> Cc: Zi Yan <ziy@nvidia.com>
> Cc: wang lian <lianux.mm@gmail.com>
---
LGTM.
Reviewed-by: wang lian <lianux.mm@gmail.com>
--
Best Regards,
wang lian
next prev parent reply other threads:[~2025-10-23 1:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 21:21 [Patch v3 0/4] mm/huge_memory: cleanup __split_unmapped_folio() Wei Yang
2025-10-21 21:21 ` [Patch v3 1/4] mm/huge_memory: avoid reinvoking folio_test_anon() Wei Yang
2025-10-24 14:08 ` Lorenzo Stoakes
2025-10-21 21:21 ` [Patch v3 2/4] mm/huge_memory: update folio stat after successful split Wei Yang
2025-10-22 20:26 ` David Hildenbrand
2025-10-22 20:31 ` Zi Yan
2025-10-23 1:26 ` wang lian [this message]
2025-10-24 14:32 ` Lorenzo Stoakes
2025-10-31 0:46 ` Wei Yang
2025-10-21 21:21 ` [Patch v3 3/4] mm/huge_memory: optimize and simplify folio stat update after split Wei Yang
2025-10-22 20:28 ` David Hildenbrand
2025-10-22 20:32 ` Zi Yan
2025-10-23 1:29 ` wang lian
2025-10-24 14:35 ` Lorenzo Stoakes
2025-10-21 21:21 ` [Patch v3 4/4] mm/huge_memory: optimize old_order derivation during folio splitting Wei Yang
2025-10-22 20:29 ` David Hildenbrand
2025-10-22 20:33 ` Zi Yan
2025-10-23 1:32 ` wang lian
2025-10-24 14:46 ` Lorenzo Stoakes
2025-10-24 15:29 ` Zi Yan
2025-10-24 15:33 ` Lorenzo Stoakes
2025-10-31 1:50 ` Wei Yang
2025-10-31 1:55 ` Zi Yan
2025-10-31 2:00 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251023012602.14780-1-lianux.mm@gmail.com \
--to=lianux.mm@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=dev.jain@arm.com \
--cc=lance.yang@linux.dev \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=npache@redhat.com \
--cc=richard.weiyang@gmail.com \
--cc=ryan.roberts@arm.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).