From: Jason Gunthorpe <jgg@ziepe.ca>
To: Pasha Tatashin <pasha.tatashin@soleen.com>
Cc: David Matlack <dmatlack@google.com>,
akpm@linux-foundation.org, brauner@kernel.org, corbet@lwn.net,
graf@amazon.com, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-mm@kvack.org,
masahiroy@kernel.org, ojeda@kernel.org, pratyush@kernel.org,
rdunlap@infradead.org, rppt@kernel.org, tj@kernel.org,
jasonmiu@google.com, skhawaja@google.com
Subject: Re: [PATCH v3 1/3] liveupdate: kho: warn and fail on metadata or preserved memory in scratch area
Date: Wed, 29 Oct 2025 13:09:21 -0300 [thread overview]
Message-ID: <20251029160921.GP760669@ziepe.ca> (raw)
In-Reply-To: <CA+CK2bAibAPzTq+edRTXS9g7Cs0w-zCiSSrXUkoFAHe7=3C0QA@mail.gmail.com>
On Mon, Oct 27, 2025 at 08:01:59PM -0400, Pasha Tatashin wrote:
> > > static void *xa_load_or_alloc(struct xarray *xa, unsigned long index, size_t sz)
> > > {
> > > - void *elm, *res;
> > > + void *res = xa_load(xa, index);
> > >
> > > - elm = xa_load(xa, index);
> > > - if (elm)
> > > - return elm;
> > > + if (res)
> > > + return res;
> > > +
> > > + void *elm __free(kfree) = kzalloc(sz, GFP_KERNEL);
> >
> > nit: This breaks the local style of always declaring variables at the
> > beginning of blocks.
>
> I think this suggestion came from Mike, to me it looks alright, as it
> is only part of the clean-up path.
It is the recommended style for using cleanup.h stuff, declare and
assign in one statement.
Jason
next prev parent reply other threads:[~2025-10-29 16:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 0:08 [PATCH v3 0/3] KHO: kfence + KHO memory corruption fix Pasha Tatashin
2025-10-21 0:08 ` [PATCH v3 1/3] liveupdate: kho: warn and fail on metadata or preserved memory in scratch area Pasha Tatashin
2025-10-22 10:22 ` Pratyush Yadav
2025-10-27 22:29 ` David Matlack
2025-10-28 0:01 ` Pasha Tatashin
2025-10-29 16:09 ` Jason Gunthorpe [this message]
2025-10-29 8:48 ` Mike Rapoport
2025-10-29 22:22 ` Pasha Tatashin
2025-10-29 22:35 ` Andrew Morton
2025-10-21 0:08 ` [PATCH v3 2/3] liveupdate: kho: Increase metadata bitmap size to PAGE_SIZE Pasha Tatashin
2025-10-22 10:25 ` Pratyush Yadav
2025-10-27 22:44 ` David Matlack
2025-10-27 22:56 ` David Matlack
2025-10-27 23:01 ` David Matlack
2025-10-28 0:03 ` Pasha Tatashin
2025-10-21 0:08 ` [PATCH v3 3/3] liveupdate: kho: allocate metadata directly from the buddy allocator Pasha Tatashin
2025-10-27 23:04 ` David Matlack
2025-10-28 0:03 ` Pasha Tatashin
2025-10-21 6:00 ` [PATCH v3 0/3] KHO: kfence + KHO memory corruption fix Mike Rapoport
2025-10-21 16:04 ` Pasha Tatashin
2025-10-21 20:53 ` Andrew Morton
2025-10-22 0:15 ` Pasha Tatashin
2025-10-22 5:48 ` Mike Rapoport
2025-10-22 18:24 ` Andrew Morton
2025-10-23 2:45 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251029160921.GP760669@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=corbet@lwn.net \
--cc=dmatlack@google.com \
--cc=graf@amazon.com \
--cc=jasonmiu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=masahiroy@kernel.org \
--cc=ojeda@kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=pratyush@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rppt@kernel.org \
--cc=skhawaja@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).