linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: YoungJun Park <youngjun.park@lge.com>
Cc: linux-mm@kvack.org, Kemeng Shi <shikemeng@huaweicloud.com>,
	Kairui Song <kasong@tencent.com>, Nhat Pham <nphamcs@gmail.com>,
	Baoquan He <bhe@redhat.com>, Barry Song <baohua@kernel.org>,
	Chris Li <chrisl@kernel.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH v2 1/1] mm: swap: remove duplicate nr_swap_pages decrement in get_swap_page_of_type()
Date: Tue, 4 Nov 2025 14:24:45 -0800	[thread overview]
Message-ID: <20251104142445.47e68d38b36c81aa304b55cc@linux-foundation.org> (raw)
In-Reply-To: <aQoR0MxfITbuj9sF@yjaykim-PowerEdge-T330>

On Tue, 4 Nov 2025 23:46:40 +0900 YoungJun Park <youngjun.park@lge.com> wrote:

> > Can we please have a description of the userspace-visible runtime
> > effects of the bug?
> > > Fixes: 4f78252da887 ("mm: swap: move nr_swap_pages counter decrement from folio_alloc_swap() to swap_range_alloc()")
> > > Cc: stable@vger.kernel.org # v6.17-rc1
> > 
> > Especially when proposing a backport.
> > 
> > Thanks.
> 
> Hi Andrew,
> 
> Thank you for picking up the patch. Since it's already in mm-hotfixes-unstable,
> I'm providing the elaboration here rather than sending v3.
> 
> As a representative userspace-visible runtime example of the impact,
> /proc/meminfo reports increasingly inaccurate SwapFree values. The
> discrepancy grows with each swap allocation, and during hibernation when
> large amounts of memory are written to swap, the reported value can deviate
> significantly from actual available swap space, misleading users and
> monitoring tools. 

Great, thanks, very helpful.  I pasted that into the mm.git copy of
this patch.



  reply	other threads:[~2025-11-04 22:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-02  8:24 [PATCH v2 1/1] mm: swap: remove duplicate nr_swap_pages decrement in get_swap_page_of_type() Youngjun Park
2025-11-02 16:58 ` Kairui Song
2025-11-04  2:56 ` Andrew Morton
2025-11-04 14:46   ` YoungJun Park
2025-11-04 22:24     ` Andrew Morton [this message]
2025-11-04 16:20 ` Nhat Pham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251104142445.47e68d38b36c81aa304b55cc@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=bhe@redhat.com \
    --cc=chrisl@kernel.org \
    --cc=kasong@tencent.com \
    --cc=linux-mm@kvack.org \
    --cc=nphamcs@gmail.com \
    --cc=shikemeng@huaweicloud.com \
    --cc=stable@vger.kernel.org \
    --cc=youngjun.park@lge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).