linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: Qi Zheng <qi.zheng@linux.dev>,
	hannes@cmpxchg.org, hughd@google.com, mhocko@suse.com,
	roman.gushchin@linux.dev, shakeel.butt@linux.dev,
	muchun.song@linux.dev, david@redhat.com,
	lorenzo.stoakes@oracle.com, ziy@nvidia.com, harry.yoo@oracle.com,
	baolin.wang@linux.alibaba.com, Liam.Howlett@oracle.com,
	npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com,
	baohua@kernel.org, lance.yang@linux.dev, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
	Muchun Song <songmuchun@bytedance.com>,
	Qi Zheng <zhengqi.arch@bytedance.com>
Subject: Re: [PATCH v5 3/4] mm: thp: use folio_batch to handle THP splitting in deferred_split_scan()
Date: Thu, 6 Nov 2025 18:29:49 -0800	[thread overview]
Message-ID: <20251106182949.1ffd6f5529aa18139f2ba9f3@linux-foundation.org> (raw)
In-Reply-To: <20251106145213.jblfgslgjzfr3z7h@master>

On Thu, 6 Nov 2025 14:52:13 +0000 Wei Yang <richard.weiyang@gmail.com> wrote:

> >+		if (folio_order(folio) > 1) {
> >+			if (!list_empty(&folio->_deferred_list)) {
> >+				ds_queue->split_queue_len--;
> >+				/*
> >+				 * Reinitialize page_deferred_list after removing the
> >+				 * page from the split_queue, otherwise a subsequent
> >+				 * split will see list corruption when checking the
> >+				 * page_deferred_list.
> >+				 */
> >+				list_del_init(&folio->_deferred_list);
> >+			}
> > 			if (folio_test_partially_mapped(folio)) {
> > 				folio_clear_partially_mapped(folio);
> > 				mod_mthp_stat(folio_order(folio),
> > 					      MTHP_STAT_NR_ANON_PARTIALLY_MAPPED, -1);
> > 			}
> >-			/*
> >-			 * Reinitialize page_deferred_list after removing the
> >-			 * page from the split_queue, otherwise a subsequent
> >-			 * split will see list corruption when checking the
> >-			 * page_deferred_list.
> >-			 */
> >-			list_del_init(&folio->_deferred_list);
> 
> @Andrew
> 
> Current mm-new looks not merge the code correctly?
> 

It happens.  We presently have 29 patches which alter mm/huge_memory.c.

Thanks for checking.  I'll drop version 5 of "reparent the THP split queue".

Please check what remains, and send a v6 against tomorrow's
mm-new/mm-unstable.


  reply	other threads:[~2025-11-07  2:29 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-15  6:35 [PATCH v5 0/4] reparent the THP split queue Qi Zheng
2025-10-15  6:35 ` [PATCH v5 1/4] mm: thp: replace folio_memcg() with folio_memcg_charged() Qi Zheng
2025-10-15  6:35 ` [PATCH v5 2/4] mm: thp: introduce folio_split_queue_lock and its variants Qi Zheng
2025-10-15  6:35 ` [PATCH v5 3/4] mm: thp: use folio_batch to handle THP splitting in deferred_split_scan() Qi Zheng
2025-10-17  0:46   ` Wei Yang
2025-10-17  2:33     ` Qi Zheng
2025-10-17  5:38   ` Harry Yoo
2025-11-06 14:52   ` Wei Yang
2025-11-07  2:29     ` Andrew Morton [this message]
2025-11-07  2:52       ` Qi Zheng
2025-11-07  2:51     ` Qi Zheng
2025-11-07  2:59       ` Wei Yang
2025-10-15  6:35 ` [PATCH v5 4/4] mm: thp: reparent the split queue during memcg offline Qi Zheng
2025-10-21  6:09   ` Harry Yoo
2025-10-21  6:21     ` Qi Zheng
2025-10-21  9:29       ` Harry Yoo
2025-10-21  9:43         ` Qi Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251106182949.1ffd6f5529aa18139f2ba9f3@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=cgroups@vger.kernel.org \
    --cc=david@redhat.com \
    --cc=dev.jain@arm.com \
    --cc=hannes@cmpxchg.org \
    --cc=harry.yoo@oracle.com \
    --cc=hughd@google.com \
    --cc=lance.yang@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mhocko@suse.com \
    --cc=muchun.song@linux.dev \
    --cc=npache@redhat.com \
    --cc=qi.zheng@linux.dev \
    --cc=richard.weiyang@gmail.com \
    --cc=roman.gushchin@linux.dev \
    --cc=ryan.roberts@arm.com \
    --cc=shakeel.butt@linux.dev \
    --cc=songmuchun@bytedance.com \
    --cc=zhengqi.arch@bytedance.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).