* [PATCH] mm/vmalloc: fix build error
@ 2025-11-18 15:50 Peng Li
2025-11-21 0:16 ` John Hubbard
0 siblings, 1 reply; 2+ messages in thread
From: Peng Li @ 2025-11-18 15:50 UTC (permalink / raw)
To: linux-mm, akpm
Cc: david, osalvador, jgg, jhubbard, peterx, linux-kernel,
dan.j.williams, Peng Li
From: Peng Li <peng8420.li@gmail.com>
commit 056b93566a35 ("mm/vmalloc: warn only once when vmalloc
detect invalid gfp flags") modify the function call from WARN to WARN_ONCE.
WARN_ONCE input parameter format error, missing ',' tag.
Resulting in the following compilation errors:
mm/vmalloc.c:3940:19: error: expected ‘)’ before ‘invalid_mask’
3940 | invalid_mask, &invalid_mask, flags, &flags);
After adding the "," tag, the compilation passed.
Signed-off-by: Peng Li <peng8420.li@gmail.com>
---
mm/vmalloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index d78c4d09d6ea..0469ba2c230e 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -3936,7 +3936,7 @@ static gfp_t vmalloc_fix_flags(gfp_t flags)
gfp_t invalid_mask = flags & ~GFP_VMALLOC_SUPPORTED;
flags &= GFP_VMALLOC_SUPPORTED;
- WARN_ONCE(1, "Unexpected gfp: %#x (%pGg). Fixing up to gfp: %#x (%pGg). Fix your code!\n"
+ WARN_ONCE(1, "Unexpected gfp: %#x (%pGg). Fixing up to gfp: %#x (%pGg). Fix your code!\n",
invalid_mask, &invalid_mask, flags, &flags);
return flags;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm/vmalloc: fix build error
2025-11-18 15:50 [PATCH] mm/vmalloc: fix build error Peng Li
@ 2025-11-21 0:16 ` John Hubbard
0 siblings, 0 replies; 2+ messages in thread
From: John Hubbard @ 2025-11-21 0:16 UTC (permalink / raw)
To: Peng Li, linux-mm, akpm
Cc: david, osalvador, jgg, peterx, linux-kernel, dan.j.williams
On 11/18/25 7:50 AM, Peng Li wrote:
> From: Peng Li <peng8420.li@gmail.com>
>
> commit 056b93566a35 ("mm/vmalloc: warn only once when vmalloc
> detect invalid gfp flags") modify the function call from WARN to WARN_ONCE.
>
> WARN_ONCE input parameter format error, missing ',' tag.
> Resulting in the following compilation errors:
>
> mm/vmalloc.c:3940:19: error: expected ‘)’ before ‘invalid_mask’
> 3940 | invalid_mask, &invalid_mask, flags, &flags);
>
> After adding the "," tag, the compilation passed.
>
> Signed-off-by: Peng Li <peng8420.li@gmail.com>
> ---
> mm/vmalloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: John Hubbard <jhubbard@nvidia.com>
thanks,
--
John Hubbard
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index d78c4d09d6ea..0469ba2c230e 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -3936,7 +3936,7 @@ static gfp_t vmalloc_fix_flags(gfp_t flags)
> gfp_t invalid_mask = flags & ~GFP_VMALLOC_SUPPORTED;
>
> flags &= GFP_VMALLOC_SUPPORTED;
> - WARN_ONCE(1, "Unexpected gfp: %#x (%pGg). Fixing up to gfp: %#x (%pGg). Fix your code!\n"
> + WARN_ONCE(1, "Unexpected gfp: %#x (%pGg). Fixing up to gfp: %#x (%pGg). Fix your code!\n",
> invalid_mask, &invalid_mask, flags, &flags);
> return flags;
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-21 0:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-18 15:50 [PATCH] mm/vmalloc: fix build error Peng Li
2025-11-21 0:16 ` John Hubbard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).