[PATCH v2] tools/mm/slabinfo: Fix --partial long option mapping

[PATCH v2] tools/mm/slabinfo: Fix --partial long option mapping

[Kaushlendra Kumar]

The long option "--partial" was incorrectly mapped to lowercase 'p' in
the opts[] array, but the getopt string and switch case handle uppercase
'P'. This mismatch caused --partial to be rejected.

Fix the long_options mapping to use 'P' so --partial works correctly
alongside the existing -P short option.

Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
---
v2: Keep existing -P behavior instead of changing to -p per review
feedback

 tools/mm/slabinfo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/mm/slabinfo.c b/tools/mm/slabinfo.c
index 7c51d283504d..39f7eae7eecd 100644
--- a/tools/mm/slabinfo.c
+++ b/tools/mm/slabinfo.c
@@ -1405,7 +1405,7 @@ struct option opts[] = {
 	{ "numa", no_argument, NULL, 'n' },
 	{ "lines", required_argument, NULL, 'N'},
 	{ "ops", no_argument, NULL, 'o' },
-	{ "partial", no_argument, NULL, 'p'},
+	{ "partial", no_argument, NULL, 'P'},
 	{ "report", no_argument, NULL, 'r' },
 	{ "shrink", no_argument, NULL, 's' },
 	{ "Size", no_argument, NULL, 'S'},
-- 
2.34.1

Re: [PATCH v2] tools/mm/slabinfo: Fix --partial long option mapping

[SeongJae Park]

On Mon,  8 Dec 2025 16:22:40 +0530 Kaushlendra Kumar <kaushlendra.kumar@intel.com> wrote:

> The long option "--partial" was incorrectly mapped to lowercase 'p' in
> the opts[] array, but the getopt string and switch case handle uppercase
> 'P'. This mismatch caused --partial to be rejected.
> 
> Fix the long_options mapping to use 'P' so --partial works correctly
> alongside the existing -P short option.

Looks nice finding and fix to me!  I also confirmed the issue exists, and this
patch fixes it.

> 
> Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>

Reviewed-by: SeongJae Park <sj@kernel.org>
Tested-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

[...]