public inbox for linux-mm@kvack.org
 help / color / mirror / Atom feed
From: Chunyu Hu <chuhu@redhat.com>
To: akpm@linux-foundation.org, david@kernel.org, shuah@kernel.org,
	linux-mm@kvack.org, ljs@kernel.org
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com,
	vbabka@suse.cz, rppt@kernel.org, surenb@google.com,
	mhocko@suse.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com,
	npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com,
	baohua@kernel.org, lance.yang@linux.dev, chuhu@redhat.com,
	Li Wang <liwang@redhat.com>
Subject: [RESEND PATCH 1/4] selftests/mm/guard-regions: skip collapse test when thp not enabled
Date: Thu, 12 Mar 2026 19:40:24 +0800	[thread overview]
Message-ID: <20260312114027.634559-2-chuhu@redhat.com> (raw)
In-Reply-To: <20260312114027.634559-1-chuhu@redhat.com>

When thp is not available, just skip the collape tests to avoid the false
positive.

Without the change, run with a thp disabled kernel:
  ./run_vmtests.sh -t madv_guard
  <snip/>
  # #  RUN           guard_regions.file.multi_vma ...
  # #            OK  guard_regions.file.multi_vma
  # ok 89 guard_regions.file.multi_vma
  # #  RUN           guard_regions.file.basic ...
  # #            OK  guard_regions.file.basic
  # ok 90 guard_regions.file.basic
  # # FAILED: 87 / 90 tests passed.
  # # 17 skipped test(s) detected. Consider enabling relevant config options to improve coverage.
  # # Totals: pass:70 fail:3 xfail:0 xpass:0 skip:17 error:0
  # [FAIL]
  not ok 1 guard-regions # exit=1
  hwpoison_inject
  # SUMMARY: PASS=0 SKIP=0 FAIL=1

With this change, run with thp disabled kernel:
  ./run_vmtests.sh -t madv_guard
  <snip/>
  # ok 90 guard_regions.file.basic
  # # PASSED: 90 / 90 tests passed.
  # # 20 skipped test(s) detected. Consider enabling relevant config options to improve coverage.
  # # Totals: pass:70 fail:0 xfail:0 xpass:0 skip:20 error:0
  # [PASS]
  ok 1 guard-regions
  hwpoison_inject
  # SUMMARY: PASS=1 SKIP=0 FAIL=0
  1..1
CC: Li Wang <liwang@redhat.com>
Signed-off-by: Chunyu Hu <chuhu@redhat.com>
---
 tools/testing/selftests/mm/guard-regions.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/testing/selftests/mm/guard-regions.c b/tools/testing/selftests/mm/guard-regions.c
index dbd21d66d383..897af9c512f9 100644
--- a/tools/testing/selftests/mm/guard-regions.c
+++ b/tools/testing/selftests/mm/guard-regions.c
@@ -21,6 +21,7 @@
 #include <sys/uio.h>
 #include <unistd.h>
 #include "vm_util.h"
+#include "thp_settings.h"
 
 #include "../pidfd/pidfd.h"
 
@@ -2195,6 +2196,9 @@ TEST_F(guard_regions, collapse)
 	char *ptr;
 	int i;
 
+	if (!thp_is_enabled())
+		SKIP(return, "Transparent Hugepages not available\n");
+
 	/* Need file to be correct size for tests for non-anon. */
 	if (variant->backing != ANON_BACKED)
 		ASSERT_EQ(ftruncate(self->fd, size), 0);
-- 
2.53.0



  reply	other threads:[~2026-03-12 11:41 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-12 11:40 [PATCH 0/4] selftests/mm: skip several tests when thp is not available Chunyu Hu
2026-03-12 11:40 ` Chunyu Hu [this message]
2026-03-12 13:58   ` [RESEND PATCH 1/4] selftests/mm/guard-regions: skip collapse test when thp not enabled Zi Yan
2026-03-12 19:48   ` David Hildenbrand (Arm)
2026-03-13 15:35   ` Lorenzo Stoakes (Oracle)
2026-03-12 11:40 ` [RESEND PATCH 2/4] selftests/mm: soft-dirty: skip two tests when thp is not available Chunyu Hu
2026-03-12 14:00   ` Zi Yan
2026-03-12 19:43   ` David Hildenbrand (Arm)
2026-03-13 17:37   ` Lorenzo Stoakes (Oracle)
2026-03-12 11:40 ` [RESEND PATCH 3/4] selftests/mm: split_huge_page_test: skip the test " Chunyu Hu
2026-03-12 14:11   ` Zi Yan
2026-03-13  2:29     ` Chunyu Hu
2026-03-13 15:15     ` Mike Rapoport
2026-03-13 15:27       ` Zi Yan
2026-03-13 18:00         ` Lorenzo Stoakes (Oracle)
2026-03-16  3:51         ` Chunyu Hu
2026-03-16  3:46       ` Chunyu Hu
2026-03-12 19:44   ` David Hildenbrand (Arm)
2026-03-13  2:25     ` Chunyu Hu
2026-03-12 11:40 ` [RESEND PATCH 4/4] selftests/mm: transhuge_stress: skip the test when thp " Chunyu Hu
2026-03-12 14:11   ` Zi Yan
2026-03-12 19:46   ` David Hildenbrand (Arm)
2026-03-13  2:43     ` Chunyu Hu
2026-03-13 18:01       ` Lorenzo Stoakes (Oracle)
2026-03-12 14:03 ` [PATCH 0/4] selftests/mm: skip several tests when thp is " Mike Rapoport
2026-03-13  0:26   ` Chunyu Hu
2026-03-13 15:19     ` Mike Rapoport
2026-03-13 15:40       ` Lorenzo Stoakes (Oracle)
2026-03-14  0:22         ` Chunyu Hu
2026-03-14  0:27       ` Chunyu Hu
2026-03-12 19:39 ` David Hildenbrand (Arm)
2026-03-13  2:21   ` Chunyu Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260312114027.634559-2-chuhu@redhat.com \
    --to=chuhu@redhat.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=david@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=lance.yang@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liwang@redhat.com \
    --cc=ljs@kernel.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mhocko@suse.com \
    --cc=npache@redhat.com \
    --cc=rppt@kernel.org \
    --cc=ryan.roberts@arm.com \
    --cc=shuah@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox