public inbox for linux-mm@kvack.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alice Ryhl <aliceryhl@google.com>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
	Nathan Chancellor <nathan@kernel.org>,
	Mike Rapoport <rppt@kernel.org>,
	kernel test robot <lkp@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
	Linux Memory Management List <linux-mm@kvack.org>,
	Mark Brown <broonie@kernel.org>,
	rust-for-linux@vger.kernel.org, Miguel Ojeda <ojeda@kernel.org>,
	Danilo Krummrich <dakr@kernel.org>, Jann Horn <jannh@google.com>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>
Subject: Re: [linux-next:master 5585/5731] error[E0277]: `*const kernel::bindings::vm_uffd_ops` cannot be shared between threads safely
Date: Sat, 14 Mar 2026 12:53:21 +0100	[thread overview]
Message-ID: <2026031444-wriggle-tradition-245f@gregkh> (raw)
In-Reply-To: <abVG0JypVhDxx1Tt@google.com>

On Sat, Mar 14, 2026 at 11:30:24AM +0000, Alice Ryhl wrote:
> On Sat, Mar 14, 2026 at 12:15:30PM +0100, Alice Ryhl wrote:
> > On Sat, Mar 14, 2026 at 12:13 PM Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > >
> > > On Fri, Mar 13, 2026 at 11:39:14PM +0100, Miguel Ojeda wrote:
> > > > On Fri, Mar 13, 2026 at 10:36 PM Nathan Chancellor <nathan@kernel.org> wrote:
> > > > >
> > > > > It looks like this is a conflict between Alice's "rust_binder: check ownership
> > > > > before using vma" [1] (currently in char-misc-linus [2]) and Mike's
> > > > > "userfaultfd: introduce vm_uffd_ops" [3] (currently in mm-unstable [4]),
> > > > > hence why it was bisected to the -next merge commit.
> > > >
> > > > Thanks Nathan, yeah, adding a raw pointer (not function pointer) to
> > > > the struct makes the type `!Sync` in Rust.
> > > >
> > > > I assume this is best handled with a patch on top of char-misc-linus.
> > > > Perhaps creating a wrapper to assert it is `Sync`, since the
> > > > `BINDER_VM_OPS` contents are unused (so far).
> > > >
> > > > Cc'ing more folks related to the commit.
> > >
> > > char-misc-linus should get merged into Linus's tree "soon" and then we
> > > can fix up the mm-unstable change for this.
> > 
> > I'm working on the fix as we speak. It would be ideal if it went into
> > char-misc-linus, because the commit that is wrong is mine, not the one
> > in mm.
> 
> To clarify, to avoid breaking bisection, the commit needs to land
> somewhere that is on top of commit 8ef2c15aeae0 ("rust_binder: check
> ownership before using vma"), and before the mm commit. But I guess
> there are several options for how to do that other than landing it
> through char-misc-linus right now.

I've sent off a pull request for the char-misc-linus branch now, and
after -rc4 is out I'll queue this up on top of that to get merged for
-rc5 to make this all work out ok.

thanks,

greg k-h


  reply	other threads:[~2026-03-14 11:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-12  4:21 [linux-next:master 5585/5731] error[E0277]: `*const kernel::bindings::vm_uffd_ops` cannot be shared between threads safely kernel test robot
2026-03-13 21:36 ` Nathan Chancellor
2026-03-13 22:39   ` Miguel Ojeda
2026-03-14 11:12     ` Greg Kroah-Hartman
2026-03-14 11:15       ` Alice Ryhl
2026-03-14 11:19         ` [PATCH] rust_binder: use AssertSync for BINDER_VM_OPS Alice Ryhl
2026-03-14 13:37           ` Gary Guo
2026-03-14 11:30         ` [linux-next:master 5585/5731] error[E0277]: `*const kernel::bindings::vm_uffd_ops` cannot be shared between threads safely Alice Ryhl
2026-03-14 11:53           ` Greg Kroah-Hartman [this message]
2026-03-14 11:58             ` Alice Ryhl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026031444-wriggle-tradition-245f@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=aliceryhl@google.com \
    --cc=broonie@kernel.org \
    --cc=dakr@kernel.org \
    --cc=jannh@google.com \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=llvm@lists.linux.dev \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=nathan@kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=ojeda@kernel.org \
    --cc=rppt@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox