From: SeongJae Park <sj@kernel.org>
Cc: SeongJae Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: [RFC PATCH 01/10] mm/damon/core: introduce damon_ctx->paused
Date: Sun, 15 Mar 2026 14:00:00 -0700 [thread overview]
Message-ID: <20260315210012.94846-2-sj@kernel.org> (raw)
In-Reply-To: <20260315210012.94846-1-sj@kernel.org>
DAMON supports only start and stop of the execution. When it is
stopped, its internal data that it self-trained goes away. It will be
useful if the execution can be paused and resumed with the previous
self-trained data.
Introduce per-context API parameter, 'paused', for the purpose. The
parameter can be set and unset while DAMON is running and paused, using
the online parameters commit helper functions (damon_commit_ctx() and
damon_call()). Once 'paused' is set, the kdamond_fn() main loop does
only limited works with sampling interval sleep during the works. The
limited works include the handling of the online parameters update, so
that users can unset the 'pause' and resume the execution when they
want. It also keep checking DAMON stop conditions and handling of it,
so that DAMON can be stopped while paused if needed.
Signed-off-by: SeongJae Park <sj@kernel.org>
---
include/linux/damon.h | 2 ++
mm/damon/core.c | 8 ++++++++
2 files changed, 10 insertions(+)
diff --git a/include/linux/damon.h b/include/linux/damon.h
index 3a441fbca170d..421e51eff3bd2 100644
--- a/include/linux/damon.h
+++ b/include/linux/damon.h
@@ -811,6 +811,8 @@ struct damon_ctx {
* intervals tuning
*/
unsigned long next_intervals_tune_sis;
+ /* pause kdamond main loop */
+ bool pause;
/* for waiting until the execution of the kdamond_fn is started */
struct completion kdamond_started;
/* for scheme quotas prioritization */
diff --git a/mm/damon/core.c b/mm/damon/core.c
index f9854aedc42d1..1e9f6aa569fd2 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -1331,6 +1331,7 @@ int damon_commit_ctx(struct damon_ctx *dst, struct damon_ctx *src)
if (err)
return err;
}
+ dst->pause = src->pause;
dst->ops = src->ops;
dst->addr_unit = src->addr_unit;
dst->min_region_sz = src->min_region_sz;
@@ -2978,6 +2979,13 @@ static int kdamond_fn(void *data)
* kdamond_merge_regions() if possible, to reduce overhead
*/
kdamond_call(ctx, false);
+ while (ctx->pause) {
+ if (kdamond_need_stop(ctx))
+ goto done;
+ kdamond_usleep(ctx->attrs.sample_interval);
+ /* allow caller unset pause via damon_call() */
+ kdamond_call(ctx, false);
+ }
if (!list_empty(&ctx->schemes))
kdamond_apply_schemes(ctx);
else
--
2.47.3
next prev parent reply other threads:[~2026-03-15 21:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-15 20:59 [RFC PATCH 00/10] mm/damon: let DAMON be paused and resumed SeongJae Park
2026-03-15 21:00 ` SeongJae Park [this message]
2026-03-17 4:20 ` [RFC PATCH 01/10] mm/damon/core: introduce damon_ctx->paused SeongJae Park
2026-03-15 21:00 ` [RFC PATCH 02/10] mm/damon/sysfs: add pause file under context dir SeongJae Park
2026-03-17 4:26 ` SeongJae Park
2026-03-15 21:00 ` [RFC PATCH 03/10] Docs/mm/damon/design: update for context pause/resume feature SeongJae Park
2026-03-15 21:00 ` [RFC PATCH 04/10] Docs/admin-guide/mm/damon/usage: update for pause file SeongJae Park
2026-03-15 21:00 ` [RFC PATCH 05/10] Docs/ABI/damon: update for pause sysfs file SeongJae Park
2026-03-15 21:00 ` [RFC PATCH 06/10] mm/damon/tests/core-kunit: test pause commitment SeongJae Park
2026-03-15 21:00 ` [RFC PATCH 07/10] selftests/damon/_damon_sysfs: support pause file staging SeongJae Park
2026-03-15 21:00 ` [RFC PATCH 08/10] selftests/damon/drgn_dump_damon_status: dump pause SeongJae Park
2026-03-15 21:00 ` [RFC PATCH 09/10] selftests/damon/sysfs.py: check pause on assert_ctx_committed() SeongJae Park
2026-03-15 21:00 ` [RFC PATCH 10/10] selftets/damon/sysfs.py: pause DAMON before dumping status SeongJae Park
2026-03-17 4:34 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260315210012.94846-2-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox