public inbox for linux-mm@kvack.org
 help / color / mirror / Atom feed
* [PATCH v1 1/1] Docs/mm/damon: Document DAMON actions when TRANSPARENT_HUGEPAGE is off
@ 2026-03-16 14:08 gutierrez.asier
  2026-03-16 14:48 ` SeongJae Park
  0 siblings, 1 reply; 4+ messages in thread
From: gutierrez.asier @ 2026-03-16 14:08 UTC (permalink / raw)
  To: gutierrez.asier, artem.kuzin, stepanov.anatoly, wangkefeng.wang,
	yanquanmin1, zuoze1, damon, sj, akpm, ljs, Liam.Howlett, vbabka,
	rppt, surenb, mhocko, corbet, skhan, linux-doc, linux-mm,
	linux-kernel

From: Asier Gutierrez <gutierrez.asier@huawei-partners.com>

MADV_HUGEPAGE and MADV_NOHUGEPAGE are guarded and they
are not available when compiling the kernel without TRANSPARENT_HUGEPAGE
option. The DAMON behaviour is to silently fail[1] in when DAMOS_HUGEPAGE or
DAMOS_NOHUGEPAGE are used, but TRANSPARENT_HUGEPAGE is disabled. Update the
DAMON documentation to reflect this behaviour.

[1]: https://lore.kernel.org/damon/66131775-180b-4b9f-b7ce-61a3e077b6e6@huawei-partners.com/T/#m278d3c9bbedcceaf2efa51e3dc7b40a40654e51c

Signed-off-by: Asier Gutierrez <gutierrez.asier@huawei-partners.com>
---
 Documentation/mm/damon/design.rst | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst
index 29fff20b3c2a..478eab4a186a 100644
--- a/Documentation/mm/damon/design.rst
+++ b/Documentation/mm/damon/design.rst
@@ -460,9 +460,13 @@ that supports each action are as below.
  - ``pageout``: Reclaim the region.
    Supported by ``vaddr``, ``fvaddr`` and ``paddr`` operations set.
  - ``hugepage``: Call ``madvise()`` for the region with ``MADV_HUGEPAGE``.
-   Supported by ``vaddr`` and ``fvaddr`` operations set.
+   Supported by ``vaddr`` and ``fvaddr`` operations set. When
+   TRANSPARENT_HUGEPAGE is disabled, the application of the action will just
+   fail.
  - ``nohugepage``: Call ``madvise()`` for the region with ``MADV_NOHUGEPAGE``.
-   Supported by ``vaddr`` and ``fvaddr`` operations set.
+   Supported by ``vaddr`` and ``fvaddr`` operations set. When
+   TRANSPARENT_HUGEPAGE is disabled, the application of the action will just
+   fail.
  - ``lru_prio``: Prioritize the region on its LRU lists.
    Supported by ``paddr`` operations set.
  - ``lru_deprio``: Deprioritize the region on its LRU lists.
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v1 1/1] Docs/mm/damon: Document DAMON actions when TRANSPARENT_HUGEPAGE is off
  2026-03-16 14:08 [PATCH v1 1/1] Docs/mm/damon: Document DAMON actions when TRANSPARENT_HUGEPAGE is off gutierrez.asier
@ 2026-03-16 14:48 ` SeongJae Park
  2026-03-16 14:56   ` Gutierrez Asier
  0 siblings, 1 reply; 4+ messages in thread
From: SeongJae Park @ 2026-03-16 14:48 UTC (permalink / raw)
  To: gutierrez.asier
  Cc: SeongJae Park, artem.kuzin, stepanov.anatoly, wangkefeng.wang,
	yanquanmin1, zuoze1, damon, akpm, ljs, Liam.Howlett, vbabka, rppt,
	surenb, mhocko, corbet, skhan, linux-doc, linux-mm, linux-kernel

Hello Asier,


Thank you for sending this patch. :)

On Mon, 16 Mar 2026 14:08:21 +0000 <gutierrez.asier@huawei-partners.com> wrote:

> From: Asier Gutierrez <gutierrez.asier@huawei-partners.com>
> 
> MADV_HUGEPAGE and MADV_NOHUGEPAGE are guarded and they
> are not available when compiling the kernel without TRANSPARENT_HUGEPAGE
> option. The DAMON behaviour is to silently fail[1] in when DAMOS_HUGEPAGE or

checkpatch.pl shows a warning for the above line:

    WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
    #12:
    option. The DAMON behaviour is to silently fail[1] in when DAMOS_HUGEPAGE or

> DAMOS_NOHUGEPAGE are used, but TRANSPARENT_HUGEPAGE is disabled. Update the
> DAMON documentation to reflect this behaviour.
> 
> [1]: https://lore.kernel.org/damon/66131775-180b-4b9f-b7ce-61a3e077b6e6@huawei-partners.com/T/#m278d3c9bbedcceaf2efa51e3dc7b40a40654e51c
> 
> Signed-off-by: Asier Gutierrez <gutierrez.asier@huawei-partners.com>

Reviewed-by: SeongJae Park <sj@kernel.org>

Andrew might add this to mm.git while fixing the checkpatch warning on his own.
Let's give time for Andrew today.

I also added this to damon/next tree after fixing the warning.  If Andrew
doesn't pick this with the fix today, I will post mine as v2 of this patch
tomorrow.  If you prefer to do the v2 posting on your own, just let me know :)


Thanks,
SJ

[...]


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1 1/1] Docs/mm/damon: Document DAMON actions when TRANSPARENT_HUGEPAGE is off
  2026-03-16 14:48 ` SeongJae Park
@ 2026-03-16 14:56   ` Gutierrez Asier
  2026-03-16 15:13     ` SeongJae Park
  0 siblings, 1 reply; 4+ messages in thread
From: Gutierrez Asier @ 2026-03-16 14:56 UTC (permalink / raw)
  To: SeongJae Park
  Cc: artem.kuzin, stepanov.anatoly, wangkefeng.wang, yanquanmin1,
	zuoze1, damon, akpm, ljs, Liam.Howlett, vbabka, rppt, surenb,
	mhocko, corbet, skhan, linux-doc, linux-mm, linux-kernel

Hi SJ,

On 3/16/2026 5:48 PM, SeongJae Park wrote:
> Hello Asier,
> 
> 
> Thank you for sending this patch. :)
> 
> On Mon, 16 Mar 2026 14:08:21 +0000 <gutierrez.asier@huawei-partners.com> wrote:
> 
>> From: Asier Gutierrez <gutierrez.asier@huawei-partners.com>
>>
>> MADV_HUGEPAGE and MADV_NOHUGEPAGE are guarded and they
>> are not available when compiling the kernel without TRANSPARENT_HUGEPAGE
>> option. The DAMON behaviour is to silently fail[1] in when DAMOS_HUGEPAGE or
> 
> checkpatch.pl shows a warning for the above line:
> 
>     WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
>     #12:
>     option. The DAMON behaviour is to silently fail[1] in when DAMOS_HUGEPAGE or

Yes, this is due to the link. I tried to keep this patch compact, without a
cover letter. I will submit a new version without the link.

>> DAMOS_NOHUGEPAGE are used, but TRANSPARENT_HUGEPAGE is disabled. Update the
>> DAMON documentation to reflect this behaviour.
>>
>> [1]: https://lore.kernel.org/damon/66131775-180b-4b9f-b7ce-61a3e077b6e6@huawei-partners.com/T/#m278d3c9bbedcceaf2efa51e3dc7b40a40654e51c
>>
>> Signed-off-by: Asier Gutierrez <gutierrez.asier@huawei-partners.com>
> 
> Reviewed-by: SeongJae Park <sj@kernel.org>
> 
> Andrew might add this to mm.git while fixing the checkpatch warning on his own.
> Let's give time for Andrew today.
> 
> I also added this to damon/next tree after fixing the warning.  If Andrew
> doesn't pick this with the fix today, I will post mine as v2 of this patch
> tomorrow.  If you prefer to do the v2 posting on your own, just let me know :)
> 
> 
> Thanks,
> SJ
> 
> [...]
> 

-- 
Asier Gutierrez
Huawei



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1 1/1] Docs/mm/damon: Document DAMON actions when TRANSPARENT_HUGEPAGE is off
  2026-03-16 14:56   ` Gutierrez Asier
@ 2026-03-16 15:13     ` SeongJae Park
  0 siblings, 0 replies; 4+ messages in thread
From: SeongJae Park @ 2026-03-16 15:13 UTC (permalink / raw)
  To: Gutierrez Asier
  Cc: SeongJae Park, artem.kuzin, stepanov.anatoly, wangkefeng.wang,
	yanquanmin1, zuoze1, damon, akpm, ljs, Liam.Howlett, vbabka, rppt,
	surenb, mhocko, corbet, skhan, linux-doc, linux-mm, linux-kernel

On Mon, 16 Mar 2026 17:56:55 +0300 Gutierrez Asier <gutierrez.asier@huawei-partners.com> wrote:

> Hi SJ,
> 
> On 3/16/2026 5:48 PM, SeongJae Park wrote:
> > Hello Asier,
> > 
> > 
> > Thank you for sending this patch. :)
> > 
> > On Mon, 16 Mar 2026 14:08:21 +0000 <gutierrez.asier@huawei-partners.com> wrote:
> > 
> >> From: Asier Gutierrez <gutierrez.asier@huawei-partners.com>
> >>
> >> MADV_HUGEPAGE and MADV_NOHUGEPAGE are guarded and they
> >> are not available when compiling the kernel without TRANSPARENT_HUGEPAGE
> >> option. The DAMON behaviour is to silently fail[1] in when DAMOS_HUGEPAGE or
> > 
> > checkpatch.pl shows a warning for the above line:
> > 
> >     WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
> >     #12:
> >     option. The DAMON behaviour is to silently fail[1] in when DAMOS_HUGEPAGE or
> 
> Yes, this is due to the link. I tried to keep this patch compact, without a
> cover letter. I will submit a new version without the link.

The above warning is not for the link.  After wrapping the line, however,
checkpatch does warn the link line like below.

    WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
    #13:
    [1]: https://lore.kernel.org/damon/66131775-180b-4b9f-b7ce-61a3e077b6e6@huawei-partners.com/T/#m278d3c9bbedcceaf2efa51e3dc7b40a40654e51c

But, it should be ok to just ignore the warning for the link line.  So, please
wrap the line, but keep the link.


Thanks,
SJ

[...]


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-03-16 15:14 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-16 14:08 [PATCH v1 1/1] Docs/mm/damon: Document DAMON actions when TRANSPARENT_HUGEPAGE is off gutierrez.asier
2026-03-16 14:48 ` SeongJae Park
2026-03-16 14:56   ` Gutierrez Asier
2026-03-16 15:13     ` SeongJae Park

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox