[PATCH] zram: change scan_slots to return void

[PATCH] zram: change scan_slots to return void

[Sergey Senozhatsky]

scan_slots_for_writeback() and scan_slots_for_recompress()
work in a "best effort" fashion, if they cannot allocate
memory for a new pp-slot candidate they just return and
post-processing selects slots that were successfully
scanned thus far.  scan_slots functions never return
errors and their callers never check the return status,
so convert them to return void.

Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
---
 drivers/block/zram/zram_drv.c | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index 7e45b8c8c33d..1b0e1c02ece7 100644
--- a/drivers/block/zram/zram_drv.c
+++ b/drivers/block/zram/zram_drv.c
@@ -1212,9 +1212,9 @@ static int parse_mode(char *val, u32 *mode)
 	return 0;
 }
 
-static int scan_slots_for_writeback(struct zram *zram, u32 mode,
-				    unsigned long lo, unsigned long hi,
-				    struct zram_pp_ctl *ctl)
+static void scan_slots_for_writeback(struct zram *zram, u32 mode,
+				     unsigned long lo, unsigned long hi,
+				     struct zram_pp_ctl *ctl)
 {
 	u32 index = lo;
 
@@ -1246,8 +1246,6 @@ static int scan_slots_for_writeback(struct zram *zram, u32 mode,
 			break;
 		index++;
 	}
-
-	return 0;
 }
 
 static ssize_t writeback_store(struct device *dev,
@@ -2379,8 +2377,8 @@ static bool highest_priority_algorithm(struct zram *zram, u32 prio)
 	return true;
 }
 
-static int scan_slots_for_recompress(struct zram *zram, u32 mode, u32 prio,
-				     struct zram_pp_ctl *ctl)
+static void scan_slots_for_recompress(struct zram *zram, u32 mode, u32 prio,
+				      struct zram_pp_ctl *ctl)
 {
 	unsigned long nr_pages = zram->disksize >> PAGE_SHIFT;
 	unsigned long index;
@@ -2415,8 +2413,6 @@ static int scan_slots_for_recompress(struct zram *zram, u32 mode, u32 prio,
 		if (!ok)
 			break;
 	}
-
-	return 0;
 }
 
 /*
-- 
2.53.0.851.ga537e3e6e9-goog

Re: [PATCH] zram: change scan_slots to return void

[SeongJae Park]

On Tue, 17 Mar 2026 12:23:19 +0900 Sergey Senozhatsky <senozhatsky@chromium.org> wrote:

> scan_slots_for_writeback() and scan_slots_for_recompress()
> work in a "best effort" fashion, if they cannot allocate
> memory for a new pp-slot candidate they just return and
> post-processing selects slots that were successfully
> scanned thus far.  scan_slots functions never return
> errors and their callers never check the return status,
> so convert them to return void.

Makes sense.

> 
> Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>

Reviewed-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

[...]