Re: [PATCH] mm/swapfile: remove duplicate include of swap_table.h

[SeongJae Park <sj@kernel.org>]

On Wed, 18 Mar 2026 12:38:49 +0800 Chen Ni <nichen@iscas.ac.cn> wrote:

> Remove duplicate inclusion of swap_table.h in swapfile.c to clean up
> redundant code.
> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>

Reviewed-by: SeongJae Park <sj@kernel.org>

> ---
>  mm/swapfile.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/swapfile.c b/mm/swapfile.c
> index 35f1b58d0bb1..9174f1eeffb0 100644
> --- a/mm/swapfile.c
> +++ b/mm/swapfile.c
> @@ -48,7 +48,6 @@
>  #include <linux/swap_cgroup.h>
>  #include "swap_table.h"
>  #include "internal.h"
> -#include "swap_table.h"
>  #include "swap.h"

FWIW, I once thought it might better to remove the upper duplicate, because it
will make the files look alphabetically sorted and therefore easier to read.
But I realized "swap.h" should come before "swap_table.h" to really
alphabetically sorted.  Anyway that's trivial and I don't really care that, so
decided to just give my Reviewed-by: as above.


Thanks,
SJ

[...]