* [PATCH] mm/swapfile: remove duplicate include of swap_table.h
@ 2026-03-18 4:38 Chen Ni
2026-03-19 5:10 ` SeongJae Park
0 siblings, 1 reply; 2+ messages in thread
From: Chen Ni @ 2026-03-18 4:38 UTC (permalink / raw)
To: linux-mm
Cc: akpm, chrisl, kasong, shikemeng, nphamcs, bhe, baohua,
youngjun.park, Chen Ni
Remove duplicate inclusion of swap_table.h in swapfile.c to clean up
redundant code.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
mm/swapfile.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/swapfile.c b/mm/swapfile.c
index 35f1b58d0bb1..9174f1eeffb0 100644
--- a/mm/swapfile.c
+++ b/mm/swapfile.c
@@ -48,7 +48,6 @@
#include <linux/swap_cgroup.h>
#include "swap_table.h"
#include "internal.h"
-#include "swap_table.h"
#include "swap.h"
static void swap_range_alloc(struct swap_info_struct *si,
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm/swapfile: remove duplicate include of swap_table.h
2026-03-18 4:38 [PATCH] mm/swapfile: remove duplicate include of swap_table.h Chen Ni
@ 2026-03-19 5:10 ` SeongJae Park
0 siblings, 0 replies; 2+ messages in thread
From: SeongJae Park @ 2026-03-19 5:10 UTC (permalink / raw)
To: Chen Ni
Cc: SeongJae Park, linux-mm, akpm, chrisl, kasong, shikemeng, nphamcs,
bhe, baohua, youngjun.park
On Wed, 18 Mar 2026 12:38:49 +0800 Chen Ni <nichen@iscas.ac.cn> wrote:
> Remove duplicate inclusion of swap_table.h in swapfile.c to clean up
> redundant code.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: SeongJae Park <sj@kernel.org>
> ---
> mm/swapfile.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/swapfile.c b/mm/swapfile.c
> index 35f1b58d0bb1..9174f1eeffb0 100644
> --- a/mm/swapfile.c
> +++ b/mm/swapfile.c
> @@ -48,7 +48,6 @@
> #include <linux/swap_cgroup.h>
> #include "swap_table.h"
> #include "internal.h"
> -#include "swap_table.h"
> #include "swap.h"
FWIW, I once thought it might better to remove the upper duplicate, because it
will make the files look alphabetically sorted and therefore easier to read.
But I realized "swap.h" should come before "swap_table.h" to really
alphabetically sorted. Anyway that's trivial and I don't really care that, so
decided to just give my Reviewed-by: as above.
Thanks,
SJ
[...]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-19 5:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-18 4:38 [PATCH] mm/swapfile: remove duplicate include of swap_table.h Chen Ni
2026-03-19 5:10 ` SeongJae Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox