From: Andrew Morton <akpm@linux-foundation.org>
To: David Carlier <devnexen@gmail.com>
Cc: Kairui Song <kasong@tencent.com>, Chris Li <chrisl@kernel.org>,
Kemeng Shi <shikemeng@huaweicloud.com>,
linux-mm@kvack.org
Subject: Re: [PATCH] mm/page_io: use folios in sio_write_complete()
Date: Mon, 23 Mar 2026 15:54:23 -0700 [thread overview]
Message-ID: <20260323155423.96bf426cfe9b3b8e080a2106@linux-foundation.org> (raw)
In-Reply-To: <20260323170449.26333-1-devnexen@gmail.com>
On Mon, 23 Mar 2026 17:04:49 +0000 David Carlier <devnexen@gmail.com> wrote:
> Convert sio_write_complete() from legacy page APIs to folio equivalents,
> matching the conversion already done for sio_read_complete() in commit
> 6a8c068774ad ("mm/page_io: use a folio in sio_read_complete()").
>
> Replace set_page_dirty(), ClearPageReclaim() and end_page_writeback()
> with folio_mark_dirty(), folio_clear_reclaim() and folio_end_writeback()
> respectively, saving implicit calls to compound_head().
>
> Also replace page_swap_entry() with a direct folio->swap access since
> bvec entries are always set via bvec_set_folio(), meaning bv_page is
> always the head page.
>
This prompted AI review to look at sio_read_complete() and it didn't
like what it saw. Can you please check
https://sashiko.dev/#/patchset/20260323170449.26333-1-devnexen@gmail.com?
Also, mm.git is (over)full. Can we please park the nice-to-have
cleanups until after next -rc1?
next prev parent reply other threads:[~2026-03-23 22:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 17:04 [PATCH] mm/page_io: use folios in sio_write_complete() David Carlier
2026-03-23 22:54 ` Andrew Morton [this message]
2026-03-23 23:07 ` David CARLIER
2026-03-23 23:13 ` [PATCH] mm/page_io: fix PSWPIN undercount for large folios in sio_read_complete() David Carlier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260323155423.96bf426cfe9b3b8e080a2106@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=chrisl@kernel.org \
--cc=devnexen@gmail.com \
--cc=kasong@tencent.com \
--cc=linux-mm@kvack.org \
--cc=shikemeng@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox