From: Jason Gunthorpe <jgg@nvidia.com>
To: Leon Romanovsky <leonro@nvidia.com>
Cc: "Mika Penttilä" <mpenttil@redhat.com>,
"David Hildenbrand (Arm)" <david@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
"Alistair Popple" <apopple@nvidia.com>,
"Balbir Singh" <balbirs@nvidia.com>, "Zi Yan" <ziy@nvidia.com>,
"Matthew Brost" <matthew.brost@intel.com>
Subject: Re: [PATCH v5 2/6] mm: Add helper to convert HMM pfn to migrate pfn
Date: Mon, 23 Mar 2026 14:58:54 -0300 [thread overview]
Message-ID: <20260323175854.GO7340@nvidia.com> (raw)
In-Reply-To: <20260317134509.GZ61385@unreal>
On Tue, Mar 17, 2026 at 03:45:09PM +0200, Leon Romanovsky wrote:
> On Tue, Mar 17, 2026 at 03:01:09PM +0200, Mika Penttilä wrote:
> > Hi,
> >
> > On 3/17/26 11:05, David Hildenbrand (Arm) wrote:
> >
> > > On 2/11/26 09:12, mpenttil@redhat.com wrote:
> > >> From: Mika Penttilä <mpenttil@redhat.com>
> > >>
>
> <...>
>
> > >> enum hmm_pfn_flags {
> > >> /* Output fields and flags */
> > >> @@ -48,15 +50,25 @@ enum hmm_pfn_flags {
> > >> HMM_PFN_P2PDMA = 1UL << (BITS_PER_LONG - 5),
> > >> HMM_PFN_P2PDMA_BUS = 1UL << (BITS_PER_LONG - 6),
> > >>
> > >> - HMM_PFN_ORDER_SHIFT = (BITS_PER_LONG - 11),
> > >> + /* Migrate request */
> > >> + HMM_PFN_MIGRATE = 1UL << (BITS_PER_LONG - 7),
> > >> + HMM_PFN_COMPOUND = 1UL << (BITS_PER_LONG - 8),
> > >> + HMM_PFN_ORDER_SHIFT = (BITS_PER_LONG - 13),
>
> Please don't add fields which are not flags to enum hmm_pfn_flags.
If you are adding a multi-bit field then use GENMASK not shift
Jason
next prev parent reply other threads:[~2026-03-23 17:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 8:12 [PATCH v5 0/6] Migrate on fault for device pages mpenttil
2026-02-11 8:12 ` [PATCH v5 1/6] mm:/Kconfig changes for migrate " mpenttil
2026-03-17 8:31 ` David Hildenbrand (Arm)
2026-02-11 8:12 ` [PATCH v5 2/6] mm: Add helper to convert HMM pfn to migrate pfn mpenttil
2026-03-17 9:05 ` David Hildenbrand (Arm)
2026-03-17 13:01 ` Mika Penttilä
2026-03-17 13:45 ` Leon Romanovsky
2026-03-23 17:58 ` Jason Gunthorpe [this message]
2026-02-11 8:12 ` [PATCH v5 3/6] mm/hmm: do the plumbing for HMM to participate in migration mpenttil
2026-02-11 8:12 ` [PATCH 4/6] mm: setup device page migration in HMM pagewalk mpenttil
2026-02-11 8:13 ` [PATCH v5 5/6] mm: add new testcase for the migrate on fault case mpenttil
2026-02-11 8:13 ` [PATCH v5 6/6] mm:/migrate_device.c: remove migrate_vma_collect_*() mpenttil
2026-03-12 19:58 ` [PATCH v5 0/6] Migrate on fault for device pages David Hildenbrand (Arm)
2026-03-13 0:27 ` Alistair Popple
2026-03-17 10:06 ` Balbir Singh
2026-03-17 10:28 ` Mika Penttilä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260323175854.GO7340@nvidia.com \
--to=jgg@nvidia.com \
--cc=apopple@nvidia.com \
--cc=balbirs@nvidia.com \
--cc=david@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.brost@intel.com \
--cc=mpenttil@redhat.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox