From: Andrew Morton <akpm@linux-foundation.org>
To: Rob Herring <robh@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-mm@kvack.org, iommu@lists.linux.dev,
Krzysztof Kozlowski <krzk@kernel.org>,
Oreoluwa Babatunde <oreoluwa.babatunde@oss.qualcomm.com>,
Saravana Kannan <saravanak@kernel.org>,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH v2 0/7] Refactor reserved memory regions handling code
Date: Tue, 24 Mar 2026 20:00:51 -0700 [thread overview]
Message-ID: <20260324200051.65f45cbb445c6ec3f8f6399b@linux-foundation.org> (raw)
In-Reply-To: <CAL_JsqKbfFfWOzDL_KJLg7Gu-wCqE1Ch+yZ6-g-cNJD-rMzxXQ@mail.gmail.com>
On Tue, 24 Mar 2026 20:49:14 -0500 Rob Herring <robh@kernel.org> wrote:
> On Mon, Mar 23, 2026 at 3:18 PM Andrew Morton <akpm@linux-foundation.org> wrote:
> >
> > On Mon, 23 Mar 2026 11:08:54 +0100 Marek Szyprowski <m.szyprowski@samsung.com> wrote:
> >
> > > The reserved memory regions handling code was reworked to handle
> > > unlimited so called "static" memory nodes in commit 00c9a452a235 ("of:
> > > reserved_mem: Add code to dynamically allocate reserved_mem array").
> > >
> > > The side effect of this rework was a set of bugs fixed later by commits
> > > 0fd17e598333 ("of: reserved_mem: Allow reserved_mem framework detect
> > > "cma=" kernel param") and 2c223f7239f3 ("of: reserved_mem: Restructure
> > > call site for dma_contiguous_early_fixup()"). As a result, the code in
> > > drivers/of/of_reserved_mem.c became a mix of generic code and CMA
> > > specific fixups.
> > >
> > > In this patchset I try to untangle this spaghetti and perform some code
> > > cleanup. I hope nothing breaks this time.
> >
> > AI review wasn't able to get all the patches to apply, but it asked a
> > few questions:
> >
> > https://sashiko.dev/#/patchset/20260323100901.4079171-1-m.szyprowski@samsung.com
>
> Now I get these in several reviews. Just posting links here really
> doesn't flow with the review process. How are we supposed to answer
> when AI is wrong? Manually quote everything? No thanks.
yeah, I know, it's quite dorkward at present.
> To answer this one, I think 1 comment is wrong, 1 is right, and 1 I'm
> not sure about.
Well that's good. Really good.
I view Sashiko as a tool mainly for authors - view it as checkpatch on
steroids. Reviewers will probably choose to take a pass if it appears
that the AI activity will result in a new version.
> Don't get me wrong, I think this all looks promising. I know email
> support is planned, but please get that in place before sending
> reports. Really, I'd rather just get the emails or mbox to review
> first and then decide what to send for things I maintain. At least
> initially.
"at least initially" is what we've got! Be chill, it'll happen.
prev parent reply other threads:[~2026-03-25 3:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20260323100908eucas1p2f471760fe1b26181c9b0cb90dd0739a6@eucas1p2.samsung.com>
2026-03-23 10:08 ` [PATCH v2 0/7] Refactor reserved memory regions handling code Marek Szyprowski
2026-03-23 10:08 ` [PATCH v2 1/7] of: reserved_mem: remove fdt node from the structure Marek Szyprowski
2026-03-23 10:08 ` [PATCH v2 2/7] of: reserved_mem: use -ENODEV instead of -ENOENT Marek Szyprowski
2026-03-23 10:08 ` [PATCH v2 3/7] of: reserved_mem: switch to ops based OF_DECLARE() Marek Szyprowski
2026-03-23 10:08 ` [PATCH v2 4/7] of: reserved_mem: replace CMA quirks by generic methods Marek Szyprowski
2026-03-23 10:08 ` [PATCH v2 5/7] of: reserved_mem: rearrange code a bit Marek Szyprowski
2026-03-23 10:09 ` [PATCH v2 6/7] of: reserved_mem: clarify fdt_scan_reserved_mem*() functions Marek Szyprowski
2026-03-23 10:09 ` [PATCH v2 7/7] of: reserved_mem: rework fdt_init_reserved_mem_node() Marek Szyprowski
2026-03-23 20:18 ` [PATCH v2 0/7] Refactor reserved memory regions handling code Andrew Morton
2026-03-25 1:49 ` Rob Herring
2026-03-25 3:00 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260324200051.65f45cbb445c6ec3f8f6399b@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux.dev \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.szyprowski@samsung.com \
--cc=oreoluwa.babatunde@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=saravanak@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox