From: Andrew Morton <akpm@linux-foundation.org>
To: "Ard Biesheuvel" <ardb@kernel.org>
Cc: "Andy Shevchenko" <andriy.shevchenko@intel.com>,
"kernel test robot" <lkp@intel.com>,
"Kees Cook" <kees@kernel.org>, "Paul Walmsley" <pjw@kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Dmitry Antipov" <dmantipov@yandex.ru>,
oe-kbuild-all@lists.linux.dev,
"David Hildenbrand" <david@kernel.org>,
"Linux Memory Management List" <linux-mm@kvack.org>
Subject: Re: [akpm-mm:mm-nonmm-unstable 49/110] __efistub_cmdline.c:undefined reference to `__efistub___lshrdi3'
Date: Tue, 24 Mar 2026 21:02:40 -0700 [thread overview]
Message-ID: <20260324210240.ec7ebca1b16a8fe6ed610f62@linux-foundation.org> (raw)
In-Reply-To: <529d4fa6-e163-4b4b-9c51-f9f880492b76@app.fastmail.com>
On Wed, 04 Mar 2026 16:35:01 +0100 "Ard Biesheuvel" <ardb@kernel.org> wrote:
> Hi Andy,
>
> On Wed, 4 Mar 2026, at 15:24, Andy Shevchenko wrote:
> > And since it's riscv, adding people from there.
> >
> > It might be that they simply need to include the corresponding library to their
> > architecture builds (we have lib/lshrdi3.c)
> >
>
> I didn't manage to reproduce this, but if EFI boot on 32-bit RISC-V is really a thing, then doing the below should be sufficient. Alternatively, we might just disable EFI boot on 32-bit RISC-V, as I don't think it is likely to be used by anyone in practice.
>
> --- a/arch/riscv/kernel/image-vars.h
> +++ b/arch/riscv/kernel/image-vars.h
> @@ -31,6 +31,7 @@ __efistub___init_text_end = __init_text_end;
> #if defined(CONFIG_EFI_EARLYCON) || defined(CONFIG_SYSFB)
> __efistub_sysfb_primary_display = sysfb_primary_display;
> #endif
> +PROVIDE(__efistub___lshrdi3 = __lshrdi3);
>
I haven't incorporated this, so the series will still break the build.
Dmitry, can you please test, review and ack this? Or should I drop the
series and we revisit for the next cycle?
prev parent reply other threads:[~2026-03-25 4:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 11:29 [akpm-mm:mm-nonmm-unstable 49/110] __efistub_cmdline.c:undefined reference to `__efistub___lshrdi3' kernel test robot
2026-03-04 14:12 ` Andy Shevchenko
2026-03-04 14:24 ` Andy Shevchenko
2026-03-04 15:35 ` Ard Biesheuvel
2026-03-25 4:02 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260324210240.ec7ebca1b16a8fe6ed610f62@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andriy.shevchenko@intel.com \
--cc=aou@eecs.berkeley.edu \
--cc=ardb@kernel.org \
--cc=david@kernel.org \
--cc=dmantipov@yandex.ru \
--cc=geert+renesas@glider.be \
--cc=kees@kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox