From: Josh Law <objecting@objecting.org>
To: SeongJae Park <sj@kernel.org>, Andrew Morton <akpm@linux-foundation.org>
Cc: damon@lists.linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Josh Law <objecting@objecting.org>
Subject: [PATCH 2/3] mm/damon/core: use damon_nr_regions() in damon_commit_target_regions()
Date: Wed, 25 Mar 2026 07:37:59 +0000 [thread overview]
Message-ID: <20260325073800.141756-3-objecting@objecting.org> (raw)
In-Reply-To: <20260325073800.141756-1-objecting@objecting.org>
damon_commit_target_regions() walks the source region list twice: once
to count regions and again to copy their address ranges. Use the
already-maintained damon_nr_regions() instead of the counting traversal.
Signed-off-by: Josh Law <objecting@objecting.org>
---
mm/damon/core.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/mm/damon/core.c b/mm/damon/core.c
index 56372e577931..6c1f738e265c 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -1217,17 +1217,15 @@ static int damon_commit_target_regions(struct damon_target *dst,
{
struct damon_region *src_region;
struct damon_addr_range *ranges;
+ unsigned int nr = damon_nr_regions(src);
int i = 0, err;
- damon_for_each_region(src_region, src)
- i++;
- if (!i)
+ if (!nr)
return 0;
- ranges = kmalloc_objs(*ranges, i, GFP_KERNEL | __GFP_NOWARN);
+ ranges = kmalloc_objs(*ranges, nr, GFP_KERNEL | __GFP_NOWARN);
if (!ranges)
return -ENOMEM;
- i = 0;
damon_for_each_region(src_region, src)
ranges[i++] = src_region->ar;
err = damon_set_regions(dst, ranges, i, src_min_region_sz);
--
2.34.1
next prev parent reply other threads:[~2026-03-25 7:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 7:37 [PATCH 0/3] mm/damon/core: small cleanups Josh Law
2026-03-25 7:37 ` [PATCH 1/3] mm/damon/core: deduplicate scheme index lookup into helper Josh Law
2026-03-25 7:37 ` Josh Law [this message]
2026-03-25 7:38 ` [PATCH 3/3] mm/damon/core: move last_nr_regions from static local to damon_ctx Josh Law
2026-03-25 14:58 ` (sashiko status) [PATCH 0/3] mm/damon/core: small cleanups SeongJae Park
2026-03-25 15:44 ` Josh Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260325073800.141756-3-objecting@objecting.org \
--to=objecting@objecting.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox