Re: [PATCH] mm/damon: validate addr_unit to be power of 2

[Liew Rui Yan <aethernet65535@gmail.com>]

> Liew, I suggeted two options before.  But you are skipping providing your
> opinion to those, and adding yet more options.  That makes me difficult to
> follow the conversation.  Could you please answer to my suggestions and make a
> consensus about those, first?

Apologize if my previous email was unclear. Let me directly address your
two suggestion.

1. DAMON_SYSFS Type [1]:
   I fully agree with this. Centralizing the validation in
   damon_commit_ctx() is the right approach to avoid "whack-a-mole"
   problem. This is exactly what I am proposing.

2. Adding a simple check on existing validation logic (in callers?) [2]:
   While this is simpler to implement, I prefer avoiding it for the
   "whack-a-mole".

So, to clarify, I choose your first option (centralized check), and I
believe my "Option 2" is the simple way to implement it.

Does ths align with your expectation? If so, I will proceed with this
approach.

[1] https://lore.kernel.org/20260328132937.9580-1-sj@kernel.org
[2] https://lore.kernel.org/20260328141323.10540-1-sj@kernel.org
[3] https://lore.kernel.org/20260328174409.6786-1-aethernet65535@gmail.com

Best regards,
Rui Yan