From: SeongJae Park <sj@kernel.org>
To: Liew Rui Yan <aethernet65535@gmail.com>
Cc: SeongJae Park <sj@kernel.org>, damon@lists.linux.dev, linux-mm@kvack.org
Subject: Re: [PATCH] mm/damon: validate addr_unit to be power of 2
Date: Mon, 30 Mar 2026 16:34:33 -0700 [thread overview]
Message-ID: <20260330233433.4208-1-sj@kernel.org> (raw)
In-Reply-To: <20260330071736.17143-1-aethernet65535@gmail.com>
On Mon, 30 Mar 2026 15:17:36 +0800 Liew Rui Yan <aethernet65535@gmail.com> wrote:
> On Mon, 30 Mar 2026 14:08:51 +0800 Liew Rui Yan <aethernet65535@gmail.com> wrote:
> > [...]
> >
> > min_region_sz = max(PAGE_SIZE / input_addr_unit, 1);
> > if (!is_power_of_2(min_region_sz))
> > return -EINVAL;
>
> Apologies, I just realized I made a silly typo in the code above.
No worry.
>
> I used PAGE_SIZE where I should have used DAMON_MIN_REGION_SZ. While
> they happen to share the same value in many cases, DAMON_MIN_REGION_SZ
> is the correct semantic constant for this context.
>
> The code should be:
> min_region_sz = max(DAMON_MIN_REGION_SZ / addr_unit, 1);
Yes, I agree.
>
> Sorry for the confusion.
Again, no worry!
Thanks,
SJ
[...]
next prev parent reply other threads:[~2026-03-30 23:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 6:26 [PATCH] mm/damon: validate addr_unit to be power of 2 Liew Rui Yan
2026-03-27 6:45 ` Liew Rui Yan
2026-03-27 12:10 ` Liew Rui Yan
2026-03-27 8:11 ` (sashiko review) " Liew Rui Yan
2026-03-27 8:27 ` Liew Rui Yan
2026-03-27 14:14 ` SeongJae Park
2026-03-27 14:56 ` Liew Rui Yan
2026-03-28 0:14 ` SeongJae Park
2026-03-28 2:26 ` Liew Rui Yan
2026-03-28 13:29 ` SeongJae Park
2026-03-28 14:13 ` SeongJae Park
2026-03-28 17:44 ` Liew Rui Yan
2026-03-28 18:06 ` SeongJae Park
2026-03-28 18:43 ` Liew Rui Yan
2026-03-29 3:20 ` SeongJae Park
2026-03-29 7:51 ` Liew Rui Yan
2026-03-29 15:15 ` SeongJae Park
2026-03-30 6:08 ` Liew Rui Yan
2026-03-30 7:17 ` Liew Rui Yan
2026-03-30 23:34 ` SeongJae Park [this message]
2026-03-30 23:33 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260330233433.4208-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=aethernet65535@gmail.com \
--cc=damon@lists.linux.dev \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox