From: Andrew Morton <akpm@linux-foundation.org>
To: Chunyu Hu <chuhu@redhat.com>
Cc: david@kernel.org, shuah@kernel.org, linux-mm@kvack.org,
ljs@kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, lorenzo.stoakes@oracle.com,
Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org,
surenb@google.com, mhocko@suse.com, ziy@nvidia.com,
baolin.wang@linux.alibaba.com, npache@redhat.com,
ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org,
lance.yang@linux.dev
Subject: Re: [PATCH v7 4/7] selftests: ksft_exit_fail_perror: support printf style arguments
Date: Tue, 31 Mar 2026 12:09:02 -0700 [thread overview]
Message-ID: <20260331120902.4612d93efb89f71a0d79bb5b@linux-foundation.org> (raw)
In-Reply-To: <acuijiUs81Z7qYSL@gmail.com>
On Tue, 31 Mar 2026 18:31:42 +0800 Chunyu Hu <chuhu@redhat.com> wrote:
> > - ksft_exit_fail_msg("%s: %s (%d)\n", msg, strerror(errno), errno);
> > + va_list args;
> > + char *buf = NULL;
> > + int saved_errno = errno;
> > +
> > + va_start(args, msg);
> > + if (vasprintf(&buf, msg, args) == -1) {
>
> kernel test robot reported compile error on this, as the vasprintf
> required _GNU_SOURCE. Looks like it's not appropriate to be used
> in the common header. Looks like it can be replaced with a buf and
> vsnprintf instead.
I like vasprintf()!
"#define _GNU_SOURCE" occurs 402 times in selftests/, so perhaps we can
find a way to keep it?
(err, *why* 402 times? Can't it be just once?)
next prev parent reply other threads:[~2026-03-31 19:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 15:14 [PATCH v7 0/7] selftests/mm: skip several tests when thp is not available Chunyu Hu
2026-03-30 15:14 ` [PATCH v7 1/7] selftests/mm/guard-regions: skip collapse test when thp not enabled Chunyu Hu
2026-03-30 15:14 ` [PATCH v7 2/7] selftests/mm: soft-dirty: skip two tests when thp is not available Chunyu Hu
2026-03-30 15:14 ` [PATCH v7 3/7] selftests/mm: move write_file helper to vm_util Chunyu Hu
2026-03-30 15:15 ` [PATCH v7 4/7] selftests: ksft_exit_fail_perror: support printf style arguments Chunyu Hu
2026-03-31 10:31 ` Chunyu Hu
2026-03-31 19:09 ` Andrew Morton [this message]
2026-04-01 13:32 ` Chunyu Hu
2026-04-01 11:03 ` Mark Brown
2026-04-01 12:08 ` Thomas Weißschuh
2026-04-02 1:16 ` Chunyu Hu
2026-04-01 13:46 ` Chunyu Hu
[not found] ` <20260401143831.31f40405758f78d7955ff6db@linux-foundation.org>
2026-04-02 1:13 ` Chunyu Hu
2026-03-30 15:15 ` [PATCH v7 5/7] selftests/mm/vm_util: robust write_file() Chunyu Hu
2026-03-30 15:15 ` [PATCH v7 6/7] selftests/mm: split_huge_page_test: skip the test when thp is not available Chunyu Hu
2026-03-30 15:15 ` [PATCH v7 7/7] selftests/mm: transhuge_stress: skip the test when thp " Chunyu Hu
2026-03-30 19:25 ` [PATCH v7 0/7] selftests/mm: skip several tests when thp is " Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260331120902.4612d93efb89f71a0d79bb5b@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Liam.Howlett@oracle.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=chuhu@redhat.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=lance.yang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=npache@redhat.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox