public inbox for linux-mm@kvack.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: "Lorenzo Stoakes (Oracle)" <ljs@kernel.org>
Cc: Julian Braha <julianbraha@gmail.com>,
	vbabka@kernel.org, hannes@cmpxchg.org, mhocko@suse.com,
	surenb@google.com, rppt@kernel.org, Liam.Howlett@oracle.com,
	david@kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/thp: dead code cleanup in Kconfig
Date: Tue, 31 Mar 2026 17:37:44 -0700	[thread overview]
Message-ID: <20260331173744.925a6ee6fac299f86a07a7eb@linux-foundation.org> (raw)
In-Reply-To: <bfdfdb05-77e2-455d-b68d-9da3fd9d1c0d@lucifer.local>

On Tue, 31 Mar 2026 08:22:32 +0100 "Lorenzo Stoakes (Oracle)" <ljs@kernel.org> wrote:

> On Tue, Mar 31, 2026 at 08:07:30AM +0100, Julian Braha wrote:
> > There is already an 'if TRANSPARENT_HUGEPAGE' condition wrapping several
> > config options e.g. 'READ_ONLY_THP_FOR_FS', making
> > the 'depends on' statement for each of these a duplicate dependency
> > (dead code).
> >
> > I propose leaving the outer 'if TRANSPARENT_HUGEPAGE...endif' and removing
> > the individual 'depends on TRANSPARENT_HUGEPAGE' statement from each
> > option.
> >
> > This dead code was found by kconfirm, a static analysis tool for Kconfig.
> 
> Thanks for acking tooling used :) much appreciated.

OK, I give up.  Where do I learn about kconfirm?


> >
> > Signed-off-by: Julian Braha <julianbraha@gmail.com>
> 
> Unless there's some weird semantics I'm not aware of, this LGTM, so:
> 
> Reviewed-by: Lorenzo Stoakes (Oracle) <ljs@kernel.org>

Thanks.  I'll add this to my (small!) post-rc1 pile.


  reply	other threads:[~2026-04-01  0:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31  7:07 [PATCH] mm/thp: dead code cleanup in Kconfig Julian Braha
2026-03-31  7:22 ` Lorenzo Stoakes (Oracle)
2026-04-01  0:37   ` Andrew Morton [this message]
2026-04-05 17:18     ` Julian Braha
2026-04-05 19:27       ` Andrew Morton
2026-04-06 21:14         ` Julian Braha
2026-04-01 13:38 ` David Hildenbrand (Arm)
2026-04-02  2:49 ` Anshuman Khandual

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260331173744.925a6ee6fac299f86a07a7eb@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=david@kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=julianbraha@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=rppt@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox