From: SeongJae Park <sj@kernel.org>
To: Liew Rui Yan <aethernet65535@gmail.com>
Cc: SeongJae Park <sj@kernel.org>, damon@lists.linux.dev, linux-mm@kvack.org
Subject: Re: [PATCH] mm/damon: validate min_region_size to be power of 2
Date: Tue, 31 Mar 2026 18:01:56 -0700 [thread overview]
Message-ID: <20260401010157.86136-1-sj@kernel.org> (raw)
In-Reply-To: <20260331073231.30060-1-aethernet65535@gmail.com>
On Tue, 31 Mar 2026 15:32:31 +0800 Liew Rui Yan <aethernet65535@gmail.com> wrote:
> Problem
> =======
> damon_commit_ctx() checks if 'min_region_sz' is a power of 2. But if it
> is not, kdamond will terminate unexpectedly due to the user's invalid
> input.
>
> Solution
> ========
> Add the same check to damon_{lru_sort, reclaim}_apply_parameters(), but
> return -EINVAL immediately. This is to prevent user's invalid input
> causing kdamond to terminate unexpectedly.
Seems sashiko found an issue, and you are preparing the next revision, right?
Assuming so, I will skip code review of this version.
>
> Signed-off-by: Liew Rui Yan <aethernet65535@gmail.com>
> ---
Weren't there previous versions of this patch? Could you please add changelog
here, from the next version?
Thanks,
SJ
[...]
next prev parent reply other threads:[~2026-04-01 1:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 7:32 [PATCH] mm/damon: validate min_region_size to be power of 2 Liew Rui Yan
2026-03-31 15:00 ` (sashiko review) " Liew Rui Yan
2026-03-31 15:13 ` Liew Rui Yan
2026-04-01 1:01 ` SeongJae Park [this message]
2026-04-01 8:40 ` Liew Rui Yan
2026-04-01 15:31 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260401010157.86136-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=aethernet65535@gmail.com \
--cc=damon@lists.linux.dev \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox