From: Liew Rui Yan <aethernet65535@gmail.com>
To: sj@kernel.org
Cc: damon@lists.linux.dev, linux-mm@kvack.org,
Liew Rui Yan <aethernet65535@gmail.com>
Subject: [PATCH v2] mm/damon: validate min_region_size to be power of 2
Date: Thu, 2 Apr 2026 13:37:56 +0800 [thread overview]
Message-ID: <20260402053756.26606-1-aethernet65535@gmail.com> (raw)
Problem
=======
damon_commit_ctx() checks if 'min_region_sz' is a power of 2. But if it
is not, kdamond will terminate unexpectedly due to the user's invalid
input.
Solution
========
Add the same check to damon_{lru_sort, reclaim}_apply_parameters(), but
return -EINVAL immediately. This is to prevent user's invalid input
causing kdamond to terminate unexpectedly.
This patch is a follow-up to the discussion in [1], where we agreed that
the validation should be done on min_region_sz rather than addr_unit.
[1] https://lore.kernel.org/20260330233343.4083-1-sj@kernel.org
Signed-off-by: Liew Rui Yan <aethernet65535@gmail.com>
---
Changes from v1:
- Fix memory leak issue.
- Link to v1: https://lore.kernel.org/20260331073231.30060-1-aethernet65535@gmail.com
mm/damon/lru_sort.c | 5 +++++
mm/damon/reclaim.c | 5 +++++
2 files changed, 10 insertions(+)
diff --git a/mm/damon/lru_sort.c b/mm/damon/lru_sort.c
index 554559d72976..3fd176ef9d9c 100644
--- a/mm/damon/lru_sort.c
+++ b/mm/damon/lru_sort.c
@@ -294,6 +294,11 @@ static int damon_lru_sort_apply_parameters(void)
param_ctx->addr_unit = addr_unit;
param_ctx->min_region_sz = max(DAMON_MIN_REGION_SZ / addr_unit, 1);
+ if (!is_power_of_2(param_ctx->min_region_sz)) {
+ err = -EINVAL;
+ goto out;
+ }
+
if (!damon_lru_sort_mon_attrs.sample_interval) {
err = -EINVAL;
goto out;
diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c
index 86da14778658..2747eef5919d 100644
--- a/mm/damon/reclaim.c
+++ b/mm/damon/reclaim.c
@@ -204,6 +204,11 @@ static int damon_reclaim_apply_parameters(void)
param_ctx->addr_unit = addr_unit;
param_ctx->min_region_sz = max(DAMON_MIN_REGION_SZ / addr_unit, 1);
+ if (!is_power_of_2(param_ctx->min_region_sz)) {
+ err = -EINVAL;
+ goto out;
+ }
+
if (!damon_reclaim_mon_attrs.aggr_interval) {
err = -EINVAL;
goto out;
--
2.53.0
next reply other threads:[~2026-04-02 5:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 5:37 Liew Rui Yan [this message]
2026-04-02 7:08 ` (sashiko status) [PATCH v2] mm/damon: validate min_region_size to be power of 2 Liew Rui Yan
2026-04-02 14:03 ` SeongJae Park
2026-04-02 15:29 ` SeongJae Park
2026-04-03 8:29 ` Liew Rui Yan
2026-04-03 14:09 ` SeongJae Park
2026-04-03 14:12 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260402053756.26606-1-aethernet65535@gmail.com \
--to=aethernet65535@gmail.com \
--cc=damon@lists.linux.dev \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox