From: Liew Rui Yan <aethernet65535@gmail.com>
To: sj@kernel.org
Cc: yanquanmin1@huawei.com, damon@lists.linux.dev,
linux-mm@kvack.org, Liew Rui Yan <aethernet65535@gmail.com>
Subject: [PATCH v3 0/2] mm/damon: validate min_region_size to be power of 2
Date: Fri, 3 Apr 2026 13:23:48 +0800 [thread overview]
Message-ID: <20260403052837.58063-1-aethernet65535@gmail.com> (raw)
Problem
=======
When a user provides an invalid min_region_sz (not a power-of-2) via the
DAMON sysfs interface, damon_commit_ctx() fails the validation, which
causes the kdamond to terminate unexpectedly.
Reproduction steps:
1. Enable DAMON_LRU_SORT or DAMON_RECLAIM.
2. Set an invalid 'min_region_sz' by setting 'addr_unit' such that
'DAMON_MIN_REGION_SZ / addr_unit' is not a power-of-2 (e.g.,
addr_unit=3).
3. Commit the parameters via 'commit_inputs'.
4. kdamond terminates due to the validation failure.
Solution
========
Add power-of-2 validation in damon_lru_sort_apply_parameters() and
damon_reclaim_apply_parameters(), return -EINVAL immediately.
Patch 1 fixes the issue for DAMON_LRU_SORT.
Patch 2 fixes the issue for DAMON_RECLAIM.
Changes from v2
(https://lore.kernel.org/20260402053756.26606-1-aethernet65535@gmail.com)
- Split the patch into two per-module patches.
- Add Fixes: and Cc: stable tags.
- Elaborate user impact and reproduction steps.
Changes from v1
(https://lore.kernel.org/20260331073231.30060-1-aethernet65535@gmail.com)
- Fix memory leak issue.
Changes from first attempt
(https://lore.kernel.org/20260327062627.66426-1-aethernet65535@gmail.com)
- Renamed the subject.
- Validate min_region_sz rather than addr_unit.
Liew Rui Yan (2):
mm/damon/lru_sort: validate min_region_size to be power of 2
mm/damon/reclaim: validate min_region_size to be power of 2
mm/damon/lru_sort.c | 5 +++++
mm/damon/reclaim.c | 5 +++++
2 files changed, 10 insertions(+)
--
2.53.0
next reply other threads:[~2026-04-03 5:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-03 5:23 Liew Rui Yan [this message]
2026-04-03 5:23 ` [PATCH v3 1/2] mm/damon/lru_sort: validate min_region_size to be power of 2 Liew Rui Yan
2026-04-03 8:31 ` (sashiko review) " Liew Rui Yan
2026-04-03 15:55 ` SeongJae Park
2026-04-04 9:09 ` Liew Rui Yan
2026-04-04 20:18 ` SeongJae Park
2026-04-03 8:59 ` Quanmin Yan
2026-04-03 9:50 ` Liew Rui Yan
2026-04-03 16:19 ` SeongJae Park
2026-04-04 9:11 ` Liew Rui Yan
2026-04-04 20:30 ` SeongJae Park
2026-04-06 9:41 ` Liew Rui Yan
2026-04-06 15:50 ` SeongJae Park
2026-04-03 5:23 ` [PATCH v3 2/2] mm/damon/reclaim: " Liew Rui Yan
2026-04-03 8:33 ` (sashiko review) " Liew Rui Yan
2026-04-03 16:07 ` SeongJae Park
2026-04-03 16:20 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260403052837.58063-1-aethernet65535@gmail.com \
--to=aethernet65535@gmail.com \
--cc=damon@lists.linux.dev \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
--cc=yanquanmin1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox