From: Liew Rui Yan <aethernet65535@gmail.com>
To: sj@kernel.org
Cc: yanquanmin1@huawei.com, damon@lists.linux.dev,
linux-mm@kvack.org, Liew Rui Yan <aethernet65535@gmail.com>,
stable@vger.kernel.org
Subject: [PATCH v3 1/2] mm/damon/lru_sort: validate min_region_size to be power of 2
Date: Fri, 3 Apr 2026 13:23:49 +0800 [thread overview]
Message-ID: <20260403052837.58063-2-aethernet65535@gmail.com> (raw)
In-Reply-To: <20260403052837.58063-1-aethernet65535@gmail.com>
The damon_commit_ctx() checks if 'min_region_sz' is a power-of-2.
However, if an invalid input is provided via the DAMON_LRU_SORT
interface, the validation failure occurs too late, causing kdamond to
terminate unexpectedly.
To reproduce:
1. Enable DAMON_LRU_SORT.
2. Set an invalid 'addr_unit' (e.g., addr_unit=3) so that
'min_region_sz = DAMON_MIN_REGION_SZ / addr_unit' becomes
non-power-of-2.
3. Commit parameters, and observe kdamond termination.
This patch adds an early check in damon_lru_sort_apply_parameters() to
validate 'min_region_sz' and return -EINVAL immediately if it is not
a power-of-2, preventing unexpected kdamond termination.
Fixes: 2e0fe9245d6b ("mm/damon/lru_sort: support addr_unit for DAMON_LRU_SORT")
Cc: <stable@vger.kernel.org> # 6.18.x
Signed-off-by: Liew Rui Yan <aethernet65535@gmail.com>
---
mm/damon/lru_sort.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/mm/damon/lru_sort.c b/mm/damon/lru_sort.c
index 554559d72976..3fd176ef9d9c 100644
--- a/mm/damon/lru_sort.c
+++ b/mm/damon/lru_sort.c
@@ -294,6 +294,11 @@ static int damon_lru_sort_apply_parameters(void)
param_ctx->addr_unit = addr_unit;
param_ctx->min_region_sz = max(DAMON_MIN_REGION_SZ / addr_unit, 1);
+ if (!is_power_of_2(param_ctx->min_region_sz)) {
+ err = -EINVAL;
+ goto out;
+ }
+
if (!damon_lru_sort_mon_attrs.sample_interval) {
err = -EINVAL;
goto out;
--
2.53.0
next prev parent reply other threads:[~2026-04-03 5:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-03 5:23 [PATCH v3 0/2] mm/damon: validate min_region_size to be power of 2 Liew Rui Yan
2026-04-03 5:23 ` Liew Rui Yan [this message]
2026-04-03 8:31 ` (sashiko review) [PATCH v3 1/2] mm/damon/lru_sort: " Liew Rui Yan
2026-04-03 15:55 ` SeongJae Park
2026-04-04 9:09 ` Liew Rui Yan
2026-04-04 20:18 ` SeongJae Park
2026-04-03 8:59 ` Quanmin Yan
2026-04-03 9:50 ` Liew Rui Yan
2026-04-03 16:19 ` SeongJae Park
2026-04-04 9:11 ` Liew Rui Yan
2026-04-04 20:30 ` SeongJae Park
2026-04-06 9:41 ` Liew Rui Yan
2026-04-06 15:50 ` SeongJae Park
2026-04-03 5:23 ` [PATCH v3 2/2] mm/damon/reclaim: " Liew Rui Yan
2026-04-03 8:33 ` (sashiko review) " Liew Rui Yan
2026-04-03 16:07 ` SeongJae Park
2026-04-03 16:20 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260403052837.58063-2-aethernet65535@gmail.com \
--to=aethernet65535@gmail.com \
--cc=damon@lists.linux.dev \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
--cc=stable@vger.kernel.org \
--cc=yanquanmin1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox