Re: (sashiko review) [RFC PATCH 4/9] Docs/admin-guide/mm/damon/usage: document fail_charge_{num,denom} files

SeongJae Park
2026-04-04T21:01:29Z

Dropped individual recipients from Cc list, to reduce unnecessary traffic.

TL; DR: sashiko found real issues. I will fix those in the next revision.

Forwarding sashiko review in a reply format with my inline
comments below, for details of my view and doing discussions
via mails if needed.

> # review url: https://sashiko.dev/#/patchset/20260404163943.89278-5-sj@kernel.org
> # start of sashiko.dev inline review
> commit 5f8a4cfde3d93d0a4d4ac3d9a57f14f310c43e02
> Author: SeongJae Park <sj@kernel.org>
>
> Docs/admin-guide/mm/damon/usage: document fail_charge_{num,denom} files
>
> Update DAMON usage document for the DAMOS action failed regions quota charge
> ratio control sysfs files.
>
> > diff --git a/Documentation/admin-guide/mm/damon/usage.rst b/Documentation/admin-guide/mm/damon/usage.rst
> > index 534e1199cf091..3d6af6ce72d82 100644
> > --- a/Documentation/admin-guide/mm/damon/usage.rst
> > +++ b/Documentation/admin-guide/mm/damon/usage.rst
> [ ... ]
> > @@ -398,6 +401,13 @@ the background design of the feature and the name of the selectable algorithms.
> > Refer to :ref:`goals directory <sysfs_schemes_quota_goals>` for the goals
> > setup.
> >
> > +You can set the action-failed memory quota charging ratio by writing the
> > +numerator and the denominator for the ratio to ``fail_charge_num`` and
> > +`fail_charge_denom`` files, respectively. Reading those file will return the
>
> This isn't a bug, but fail_charge_denom has a single leading backtick and
> double trailing backticks.
>
> Additionally, should "Reading those file" be "Reading those files"?

Good catch! I will fix those in the next spin.

Thanks,
SJ

>
> > +current set values. Refer to :ref:`design
> > +<damon_design_damos_quotas_failed_memory_charging_ratio>` for more details of
> > +the ratio feature.
> > +
> > The time quota is internally transformed to a size quota. Between the
>
>
> # end of sashiko.dev inline review
> # review url: https://sashiko.dev/#/patchset/20260404163943.89278-5-sj@kernel.org

# hkml [1] generated a draft of this mail. You can regenerate
# this using below command:
#
# hkml patch sashiko_dev --for_forwarding \
# 20260404163943.89278-5-sj@kernel.org
#
# [1] https://github.com/sjp38/hackermail