public inbox for linux-mm@kvack.org
 help / color / mirror / Atom feed
From: Mike Rapoport <rppt@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>,
	David Hildenbrand <david@kernel.org>
Cc: Baolin Wang <baolin.wang@linux.alibaba.com>,
	Barry Song <baohua@kernel.org>, Dev Jain <dev.jain@arm.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	John Hubbard <jhubbard@nvidia.com>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>,
	Lance Yang <lance.yang@linux.dev>,
	Leon Romanovsky <leon@kernel.org>,
	Lorenzo Stoakes <ljs@kernel.org>, Mark Brown <broonie@kernel.org>,
	Michal Hocko <mhocko@suse.com>, Mike Rapoport <rppt@kernel.org>,
	Nico Pache <npache@redhat.com>, Peter Xu <peterx@redhat.com>,
	Ryan Roberts <ryan.roberts@arm.com>,
	Shuah Khan <shuah@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Vlastimil Babka <vbabka@kernel.org>, Zi Yan <ziy@nvidia.com>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-mm@kvack.org
Subject: [PATCH 18/53] selftests/mm: uffd-unit-tests: use kselftest framework
Date: Mon,  6 Apr 2026 17:17:00 +0300	[thread overview]
Message-ID: <20260406141735.2179309-19-rppt@kernel.org> (raw)
In-Reply-To: <20260406141735.2179309-1-rppt@kernel.org>

From: "Mike Rapoport (Microsoft)" <rppt@kernel.org>

Convert uffd-unit-tests to use kselftest framework for reporting and
tracking successful and failing runs.

Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
---
 tools/testing/selftests/mm/uffd-unit-tests.c | 79 +++++++++++---------
 1 file changed, 44 insertions(+), 35 deletions(-)

diff --git a/tools/testing/selftests/mm/uffd-unit-tests.c b/tools/testing/selftests/mm/uffd-unit-tests.c
index 6f5e404a446c..1a33db281f8a 100644
--- a/tools/testing/selftests/mm/uffd-unit-tests.c
+++ b/tools/testing/selftests/mm/uffd-unit-tests.c
@@ -86,39 +86,24 @@ typedef struct {
 	uffd_test_case_ops_t *test_case_ops;
 } uffd_test_case_t;
 
-static void uffd_test_report(void)
-{
-	printf("Userfaults unit tests: pass=%u, skip=%u, fail=%u (total=%u)\n",
-	       ksft_get_pass_cnt(),
-	       ksft_get_xskip_cnt(),
-	       ksft_get_fail_cnt(),
-	       ksft_test_num());
-}
+static char current_test[256];
 
 static void uffd_test_pass(void)
 {
-	printf("done\n");
-	ksft_inc_pass_cnt();
+	ksft_test_result_pass("%s\n", current_test);
 }
 
 #define  uffd_test_start(...)  do {		\
-		printf("Testing ");		\
-		printf(__VA_ARGS__);		\
-		printf("... ");			\
-		fflush(stdout);			\
+		snprintf(current_test, sizeof(current_test), __VA_ARGS__); \
 	} while (0)
 
 #define  uffd_test_fail(...)  do {		\
-		printf("failed [reason: ");	\
-		printf(__VA_ARGS__);		\
-		printf("]\n");			\
-		ksft_inc_fail_cnt();		\
+		ksft_test_result_fail("%s\n", current_test);	\
 	} while (0)
 
 static void uffd_test_skip(const char *message)
 {
-	printf("skipped [reason: %s]\n", message);
-	ksft_inc_xskip_cnt();
+	ksft_test_result_skip("%s (%s)\n", current_test, message);
 }
 
 /*
@@ -1701,6 +1686,26 @@ static void usage(const char *prog)
 	exit(KSFT_FAIL);
 }
 
+static int uffd_count_tests(int n_tests, int n_mems, const char *test_filter)
+{
+	uffd_test_case_t *test;
+	int i, j, count = 0;
+
+	if (!test_filter)
+		count += 2;	/* test_uffd_api(false) + test_uffd_api(true) */
+
+	for (i = 0; i < n_tests; i++) {
+		test = &uffd_tests[i];
+		if (test_filter && !strstr(test->name, test_filter))
+			continue;
+		for (j = 0; j < n_mems; j++)
+			if (test->mem_targets & mem_types[j].mem_flag)
+				count++;
+	}
+
+	return count;
+}
+
 int main(int argc, char *argv[])
 {
 	int n_tests = sizeof(uffd_tests) / sizeof(uffd_test_case_t);
@@ -1730,24 +1735,31 @@ int main(int argc, char *argv[])
 		}
 	}
 
-	if (!test_filter && !list_only) {
+	if (list_only) {
+		for (i = 0; i < n_tests; i++) {
+			test = &uffd_tests[i];
+			if (test_filter && !strstr(test->name, test_filter))
+				continue;
+			printf("%s\n", test->name);
+		}
+		return KSFT_PASS;
+	}
+
+	ksft_print_header();
+	ksft_set_plan(uffd_count_tests(n_tests, n_mems, test_filter));
+
+	if (!test_filter) {
 		has_uffd = test_uffd_api(false);
 		has_uffd |= test_uffd_api(true);
 
-		if (!has_uffd) {
-			printf("Userfaultfd not supported or unprivileged, skip all tests\n");
-			exit(KSFT_SKIP);
-		}
+		if (!has_uffd)
+			ksft_exit_skip("Userfaultfd not supported or unprivileged\n");
 	}
 
 	for (i = 0; i < n_tests; i++) {
 		test = &uffd_tests[i];
 		if (test_filter && !strstr(test->name, test_filter))
 			continue;
-		if (list_only) {
-			printf("%s\n", test->name);
-			continue;
-		}
 		for (j = 0; j < n_mems; j++) {
 			mem_type = &mem_types[j];
 
@@ -1794,10 +1806,7 @@ int main(int argc, char *argv[])
 		}
 	}
 
-	if (!list_only)
-		uffd_test_report();
-
-	return ksft_get_fail_cnt() ? KSFT_FAIL : KSFT_PASS;
+	ksft_finished();
 }
 
 #else /* __NR_userfaultfd */
@@ -1806,8 +1815,8 @@ int main(int argc, char *argv[])
 
 int main(void)
 {
-	printf("Skipping %s (missing __NR_userfaultfd)\n", __file__);
-	return KSFT_SKIP;
+	ksft_print_header();
+	ksft_exit_skip("missing __NR_userfaultfd definition\n");
 }
 
 #endif /* __NR_userfaultfd */
-- 
2.53.0



  parent reply	other threads:[~2026-04-06 14:19 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-06 14:16 [PATCH 00/53] selftests/mm: make MM selftests more CI friendly Mike Rapoport
2026-04-06 14:16 ` [PATCH 01/53] selftests/mm: hugetlb-read-hwpoison: add SIGBUS handler Mike Rapoport
2026-04-06 14:16 ` [PATCH 02/53] selftests/mm: khugepaged: enable collapse_single_pte_entry_compound for shmem Mike Rapoport
2026-04-06 14:16 ` [PATCH 03/53] selftests/mm: migration: don't assume hupe page is TWOMEG Mike Rapoport
2026-04-06 14:16 ` [PATCH 04/53] selftests/mm: run_vmtests.sh: don't gate THP and KSM tests on HAVE_HUGEPAGES Mike Rapoport
2026-04-06 14:16 ` [PATCH 05/53] selftests/mm: merge map_hugetlb into hugepage-mmap Mike Rapoport
2026-04-06 14:16 ` [PATCH 06/53] selftests/mm: rename hugepage-* tests to hugetlb-* Mike Rapoport
2026-04-06 14:16 ` [PATCH 07/53] selftests/mm: hugetlb-shm: use kselftest framework Mike Rapoport
2026-04-06 14:27   ` Mark Brown
2026-04-06 14:16 ` [PATCH 08/53] selftests/mm: hugetlb-vmemmap: " Mike Rapoport
2026-04-06 14:40   ` Mark Brown
2026-04-06 14:16 ` [PATCH 09/53] selftests/mm: hugetlb-madvise: " Mike Rapoport
2026-04-06 14:16 ` [PATCH 10/53] selftests/mm: hugetlb_madv_vs_map: " Mike Rapoport
2026-04-06 15:06   ` Mark Brown
2026-04-06 14:16 ` [PATCH 11/53] selftests/mm: hugetlb-read-hwpoison: " Mike Rapoport
2026-04-06 16:19   ` Mark Brown
2026-04-06 14:16 ` [PATCH 12/53] selftests/mm: khugepaged: group tests in an array Mike Rapoport
2026-04-06 16:49   ` Mark Brown
2026-04-06 14:16 ` [PATCH 13/53] selftests/mm: khugepaged: use ksefltest framework Mike Rapoport
2026-04-06 14:16 ` [PATCH 14/53] selftests/mm: ksm_tests: use kselftest framework Mike Rapoport
2026-04-06 14:16 ` [PATCH 15/53] selftests/mm: protection_keys: use descriptive test names in TAP output Mike Rapoport
2026-04-06 16:51   ` Mark Brown
2026-04-06 14:16 ` [PATCH 16/53] selftests/mm: protection_keys: use kselftest framework Mike Rapoport
2026-04-06 17:02   ` Mark Brown
2026-04-06 14:16 ` [PATCH 17/53] selftests/mm: uffd-stress: " Mike Rapoport
2026-04-06 14:17 ` Mike Rapoport [this message]
2026-04-06 14:17 ` [PATCH 19/53] selftests/mm: va_high_addr_switch: " Mike Rapoport
2026-04-06 14:17 ` [PATCH 20/53] selftests/mm: add atexit() and signal handlers to thp_settings Mike Rapoport
2026-04-06 14:17 ` [PATCH 21/53] selftests/mm: rename thp_settings.[ch] to hugepage_settings.[ch] Mike Rapoport
2026-04-06 14:17 ` [PATCH 22/53] selftests/mm: move HugeTLB helpers to hugepage_settings Mike Rapoport
2026-04-06 14:17 ` [PATCH 23/53] selftests/mm: hugepage_settings: use unsigned long in detect_hugetlb_page_size Mike Rapoport
2026-04-06 14:17 ` [PATCH 24/53] selftests/mm: hugepage_settings: add APIs to get and set nr_hugepages Mike Rapoport
2026-04-06 14:17 ` [PATCH 25/53] selftests/mm: hugepage_settings: rename get_free_hugepages() Mike Rapoport
2026-04-06 14:17 ` [PATCH 26/53] selftests/mm: hugepage_settings: add APIs for HugeTLB setup and teardown Mike Rapoport
2026-04-06 14:17 ` [PATCH 27/53] selftests/mm: move read_file(), read_num() and write_num() to vm_util Mike Rapoport
2026-04-06 14:17 ` [PATCH 28/53] selftests/mm: vm_util: add helpers to set and restore shm limits Mike Rapoport
2026-04-06 14:17 ` [PATCH 29/53] selftests/mm: compaction_test: use HugeTLB helpers Mike Rapoport
2026-04-06 14:17 ` [PATCH 30/53] selftests/mm: cow: add setup of HugeTLB pages Mike Rapoport
2026-04-06 14:17 ` [PATCH 31/53] selftests/mm: gup_longterm: " Mike Rapoport
2026-04-06 14:17 ` [PATCH 32/53] selftests/mm: gup_test: " Mike Rapoport
2026-04-06 14:17 ` [PATCH 33/53] selftests/mm: hmm-tests: " Mike Rapoport
2026-04-06 14:17 ` [PATCH 34/53] selftests/mm: hugepage_dio: " Mike Rapoport
2026-04-06 14:17 ` [PATCH 35/53] selftests/mm: hugetlb_fault_after_madv: " Mike Rapoport
2026-04-06 14:17 ` [PATCH 36/53] selftests/mm: hugetlb-madvise: " Mike Rapoport
2026-04-06 14:17 ` [PATCH 37/53] selftests/mm: hugetlb_madv_vs_map: " Mike Rapoport
2026-04-06 14:17 ` [PATCH 38/53] selftests/mm: hugetlb-mmap: " Mike Rapoport
2026-04-06 14:17 ` [PATCH 39/53] selftests/mm: hugetlb-mremap: " Mike Rapoport
2026-04-06 14:17 ` [PATCH 40/53] selftests/mm: hugetlb-shm: " Mike Rapoport
2026-04-06 14:17 ` [PATCH 41/53] selftests/mm: hugetlb-soft-online: " Mike Rapoport
2026-04-06 14:17 ` [PATCH 42/53] selftests/mm: hugetlb-vmemmap: " Mike Rapoport
2026-04-06 14:17 ` [PATCH 43/53] selftests/mm: migration: " Mike Rapoport
2026-04-06 14:17 ` [PATCH 44/53] selftests/mm: pagemap_ioctl: " Mike Rapoport
2026-04-06 14:17 ` [PATCH 45/53] selftests/mm: protection_keys: use library code for HugeTLB setup Mike Rapoport
2026-04-06 14:17 ` [PATCH 46/53] selftests/mm: thuge-gen: add setup of HugeTLB pages Mike Rapoport
2026-04-06 14:17 ` [PATCH 47/53] selftests/mm: uffd-stress: use hugetlb_save and alloc huge pages Mike Rapoport
2026-04-06 14:17 ` [PATCH 48/53] selftests/mm: uffd-unit-tests: add setup of HugeTLB pages Mike Rapoport
2026-04-06 14:17 ` [PATCH 49/53] selftests/mm: uffd-wp-mremap: " Mike Rapoport
2026-04-06 14:17 ` [PATCH 50/53] selftests/mm: va_high_addr_switch: " Mike Rapoport
2026-04-06 14:17 ` [PATCH 51/53] selftests/mm: va_high_addr_switch.sh: drop huge pages setup Mike Rapoport
2026-04-06 14:17 ` [PATCH 52/53] selftests/mm: run_vmtests.sh: free memory if available memory is low Mike Rapoport
2026-04-06 14:17 ` [PATCH 53/53] selftests/mm: run_vmtests.sh: drop detection and setup of HugeTLB Mike Rapoport

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260406141735.2179309-19-rppt@kernel.org \
    --to=rppt@kernel.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=broonie@kernel.org \
    --cc=david@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=jgg@ziepe.ca \
    --cc=jhubbard@nvidia.com \
    --cc=lance.yang@linux.dev \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=npache@redhat.com \
    --cc=peterx@redhat.com \
    --cc=ryan.roberts@arm.com \
    --cc=shuah@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox