Re: [PATCH 16/53] selftests/mm: protection_keys: use kselftest framework

Mark Brown
2026-04-06T17:02:48Z

[-- Attachment #1: Type: text/plain, Size: 760 bytes --]

On Mon, Apr 06, 2026 at 05:16:58PM +0300, Mike Rapoport wrote:

> Adjust dprintf0() printouts to use "#" in the beginning of the line for
> TAP compatibility and add fflush(stdout) in the end of the test to
> ensure all the ksft_print_*() messages are really output.

We should probably add those flushes to the kselftest helpers (eg, the
one at the end of the program should be in ksft_finished()) if they're
needed. It ought to be redundant though, we do set stdout to be line
buffered in ksft_print_header() which means that either ksft_finished()
will print a line and flush or for abort_hooks() it's immediately before
we call exit() which should do the right thing anyway. If exit() isn't
flushing I'd not be optimistic that fflush() is going to work.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]